Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Something optimize suggestion. #405

Closed
SteafanMrZhou opened this issue Dec 14, 2021 · 3 comments
Closed

Something optimize suggestion. #405

SteafanMrZhou opened this issue Dec 14, 2021 · 3 comments

Comments

@SteafanMrZhou
Copy link
Contributor

SteafanMrZhou commented Dec 14, 2021 •
edited
Loading

Describe the bug
When i studying source code of Disruptor,i find some optimize bugs,so i wana solve it.
eg.No @ Override、No Complete annotation.
Can i fix it? Cause i want be a contributor for Disruptor,thanks.
@Palmr
Copy link
Contributor

Palmr commented Dec 20, 2021

Yes, please raise a pull request and we will review.

@Palmr
Copy link
Contributor

Palmr commented Dec 31, 2021

Closing this issue while waiting for a PR to show up

@Palmr Palmr closed this as completed Dec 31, 2021
@SteafanMrZhou SteafanMrZhou mentioned this issue Jan 5, 2022
Merged
@SteafanMrZhou
Copy link
Contributor Author

@Palmr Hi,I'm so sorry to delay raising a pull request for issue#405,cause i'm very busy a period ago.
Awaiting your review,thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Palmr @SteafanMrZhou