New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kloosterman sum compute button on Dirichlet characters not working #2465
Comments
PR #2468 fixes this. However there is more discussion at #71 suggesting that (1) the sliders are unnecessary and (2) we should display the default values when the page loads. Hence I will keep this issue open even though I will merge #2468 on the grounds that having something working beats it not working, while we decide. |
This was first mentioned in LMFDB#71, although there is more discussion there. See also LMFDB#2465.
Yes, I was just figuring out how to display default values. (I'm still a javascript neophyte, but I think this is fine). I haven't removed the sliders. I was unsure whether opinions have changed on their utility. But if we do want to remove them, I know how. |
I vote that we remove them, I don't think they add any particular value and make the U/I different from the rest of the LMFDB. If you want to go ahead and add this to your outstanding PR (or a new PR if you prefer), I will review it and then we can close both this issue and #71. |
Ok. I've updated my PR to remove the sliders as well. |
@davidlowryduda, I am reopening this issue, as the character sums are not being hidden for very large modulus characters as they should be, see http://www.lmfdb.org/Character/Dirichlet/19265902/13392695 for example. |
@AndrewVSutherland Ok! I'll take a look at this today. |
It used to be that WebDirichletCharacter and WebSmallDirichletCharacter had different interfaces to the charsums function/property/dictionary. This makes it always available as a property. Resolves LMFDB#2465
Fixed via #2548 |
If you go to a Dirichlet character page, e.g. http://www.lmfdb.org/Character/Dirichlet/7/3 and enter a pair of numbers in the Kloosterman sum box (e.g. 1,2) and click the compute button nothing happens. The compute buttons for Gauss and Jacobi sums do seem to work, and the slider for Kloosterman sums does work (but also see #71).
The text was updated successfully, but these errors were encountered: