Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Fix RemoteVstPlugin not exiting when effect removed
  • Loading branch information
PhysSong committed May 30, 2018
1 parent b808631 commit 55d3fbc
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 12 deletions.
7 changes: 6 additions & 1 deletion plugins/VstEffect/VstEffectControlDialog.cpp
Expand Up @@ -289,7 +289,12 @@ void VstEffectControlDialog::showEvent(QShowEvent *_se)

VstEffectControlDialog::~VstEffectControlDialog()
{
//delete m_pluginWidget;
#if !(QT_VERSION < 0x050000 && defined(LMMS_BUILD_LINUX))
if (m_pluginWidget && layout()) {
layout()->removeWidget(m_pluginWidget);
m_pluginWidget->setParent(nullptr);
}
#endif
}


Expand Down
11 changes: 0 additions & 11 deletions src/gui/widgets/EffectView.cpp
Expand Up @@ -164,18 +164,7 @@ EffectView::EffectView( Effect * _model, QWidget * _parent ) :

EffectView::~EffectView()
{

#ifdef LMMS_BUILD_LINUX

delete m_subWindow;
#else
if( m_subWindow )
{
// otherwise on win32 build VST GUI can get lost
m_subWindow->hide();
}
#endif

}


Expand Down

0 comments on commit 55d3fbc

Please sign in to comment.