Skip to content

Commit

Permalink
JackMidi: Remove confusing warning at shutdown
Browse files Browse the repository at this point in the history
Warning is:

```
jack_port_unregister called with an incorrect port 0
Failed to unregister jack midi output
```
  • Loading branch information
JohannesLorenz committed May 15, 2020
1 parent e3cae80 commit 737fcd3
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/core/midi/MidiJack.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ MidiJack::MidiJack() :
/* jack midi out not implemented
JackMidiWrite and sendByte needs to be functional
before enabling this
If you enable this, also enable the
corresponding jack_port_unregister line below
m_output_port = jack_port_register(
jackClient(), "MIDI out", JACK_DEFAULT_MIDI_TYPE,
JackPortIsOutput, 0);
Expand Down Expand Up @@ -123,9 +125,11 @@ MidiJack::~MidiJack()
printf("Failed to unregister jack midi input\n");
}

/* Unused yet, see the corresponding jack_port_register call
if( jack_port_unregister( jackClient(), m_output_port) != 0){
printf("Failed to unregister jack midi output\n");
}
*/

if(m_jackClient)
{
Expand Down

0 comments on commit 737fcd3

Please sign in to comment.