Skip to content

Commit 737fcd3

Browse files
JackMidi: Remove confusing warning at shutdown
Warning is: ``` jack_port_unregister called with an incorrect port 0 Failed to unregister jack midi output ```
1 parent e3cae80 commit 737fcd3

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/core/midi/MidiJack.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,8 @@ MidiJack::MidiJack() :
9595
/* jack midi out not implemented
9696
JackMidiWrite and sendByte needs to be functional
9797
before enabling this
98+
If you enable this, also enable the
99+
corresponding jack_port_unregister line below
98100
m_output_port = jack_port_register(
99101
jackClient(), "MIDI out", JACK_DEFAULT_MIDI_TYPE,
100102
JackPortIsOutput, 0);
@@ -123,9 +125,11 @@ MidiJack::~MidiJack()
123125
printf("Failed to unregister jack midi input\n");
124126
}
125127

128+
/* Unused yet, see the corresponding jack_port_register call
126129
if( jack_port_unregister( jackClient(), m_output_port) != 0){
127130
printf("Failed to unregister jack midi output\n");
128131
}
132+
*/
129133

130134
if(m_jackClient)
131135
{

0 commit comments

Comments
 (0)