From e4bf9517331d9bd7b2fcb42ea27c943c982b68ed Mon Sep 17 00:00:00 2001
From: CYBERDEViL <cyberdevil@notabug.org>
Date: Sat, 27 Mar 2021 00:06:08 +0100
Subject: [PATCH] Address some minor [naming] coding conventions issues.

---
 plugins/carlabase/carla.cpp | 14 +++++---------
 plugins/carlabase/carla.h   |  2 +-
 2 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/plugins/carlabase/carla.cpp b/plugins/carlabase/carla.cpp
index 6a45da4f75e..3004e415d95 100644
--- a/plugins/carlabase/carla.cpp
+++ b/plugins/carlabase/carla.cpp
@@ -386,21 +386,17 @@ void CarlaInstrument::refreshParams(bool init)
 		fDescriptor->get_parameter_value != nullptr &&
 		fDescriptor->set_parameter_value != nullptr)
 	{
-		uint32_t param_count = fDescriptor->get_parameter_count(fHandle);
-
 		QList<QString> completerData;
 		QList<QString> groups; // used to count no. groups.
 
-		for (uint32_t i=0; i < param_count; ++i)
+		uint32_t paramCount = fDescriptor->get_parameter_count(fHandle);
+		for (uint32_t i=0; i < paramCount; ++i)
 		{
 			const NativeParameter* paramInfo(fDescriptor->get_parameter_info(fHandle, i));
 
 			m_paramModels[i]->setOutput((paramInfo->hints & NATIVE_PARAMETER_IS_OUTPUT));
 			m_paramModels[i]->setEnabled((paramInfo->hints & NATIVE_PARAMETER_IS_ENABLED));
-
-			float param_value = fDescriptor->get_parameter_value(fHandle, i);
-
-			m_paramModels[i]->setValue(param_value);
+			m_paramModels[i]->setValue(fDescriptor->get_parameter_value(fHandle, i));
 
 			// Get parameter name
 			QString name = "_NO_NAME_";
@@ -604,7 +600,7 @@ CarlaInstrumentView::CarlaInstrumentView(CarlaInstrument* const instrument, QWid
       fDescriptor(instrument->fDescriptor),
       fTimerId(fHandle != NULL && fDescriptor->ui_idle != NULL ? startTimer(30) : 0),
       m_carlaInstrument(instrument),
-      p_parent(parent),
+      m_parent(parent),
       m_paramsSubWindow(nullptr),
       m_paramsView(nullptr)
 {
@@ -703,7 +699,7 @@ void CarlaInstrumentView::toggleParamsWindow()
 {
 	if (!m_paramsSubWindow)
 	{
-		m_paramsView = new CarlaParamsView(this, p_parent);
+		m_paramsView = new CarlaParamsView(this, m_parent);
 		connect(m_paramsSubWindow, SIGNAL(uiClosed()), this, SLOT(paramsUiClosed()));
 	} else {
 		if (m_paramsSubWindow->isVisible()) {
diff --git a/plugins/carlabase/carla.h b/plugins/carlabase/carla.h
index d70c65e2a43..d9c2cc8a1a2 100644
--- a/plugins/carlabase/carla.h
+++ b/plugins/carlabase/carla.h
@@ -301,7 +301,7 @@ private slots:
     int fTimerId;
 
     CarlaInstrument* const m_carlaInstrument;
-    QWidget* const p_parent;
+    QWidget* const m_parent;
 
     QMdiSubWindow* m_paramsSubWindow;
     CarlaParamsView* m_paramsView;