(Apple) MIDI Support #1153

Closed
tresf opened this Issue Sep 11, 2014 · 26 comments

Projects

None yet

7 participants

@tresf
Member
tresf commented Sep 11, 2014

Per Google+ page:

Slapp Major: Is connecting a midi keyboard to LMMS not supported at this time? I can not get LMMS to recognize my Akai MPK mini. 

@eagles051387, do you have a midi device you can test with? Can you help troubleshoot this?

@tresf tresf added the bug label Sep 11, 2014
@eagles051387
Contributor

I do have a midi usb keyboard. Are there any related issues on other os's

On Thu, Sep 11, 2014 at 2:51 AM, Tres Finocchiaro notifications@github.com
wrote:

Per Google+ page:

Slapp Major: Is connecting a midi keyboard to LMMS not supported at
this time? I can not get LMMS to recognize my Akai MPK mini. 

@eagles051387 https://github.com/eagles051387, do you have a midi
device you can test with? Can you help troubleshoot this?


Reply to this email directly or view it on GitHub
#1153.

Jonathan Aquilina

@tresf
Member
tresf commented Sep 11, 2014

Great. Please post your progress here.

@tresf
Member
tresf commented Oct 24, 2014

@tobydox could this help with Mac Midi support?

http://www.music.mcgill.ca/~gary/rtmidi/

@tobydox
Member
tobydox commented Oct 26, 2014

Yes probably :-) We'd need an according MIDI backend for RtMidi in LMMS then.

@mattdeckard

Is anyone still working on this? I'd be happy to help if needed.

@tresf
Member
tresf commented Jul 3, 2015

@mattdeckard, no one is actively working on this. Help would be greatly appreciated.

@mattdeckard

Okay, I'm taking a look at it. I may have questions since I'm new to this codebase.

@tresf
Member
tresf commented Jul 4, 2015

Great. You'll have a lot of help. We have a great team to assist.

@Wallacoloo
Member
@mattdeckard

Awesome, that will be very helpful. Thanks @Wallacoloo

@rageboge
Contributor

If someone is interested, I'm writing a direct midi adapter (similar to WinMM) from lmms to Mac OS X CoreMidi.framework. As of now, I receive midi events from my Yamaha keyboard and feed them to lmms.
The code is very rough, but promising.

@tresf
Member
tresf commented Jul 30, 2015

I'm writing a direct midi adapter (similar to WinMM) from lmms to Mac OS X CoreMidi.framework

From the feedback we receive on Facebook, many people will be interested! :)

Edit: Also, feel free to start the Pull Request now if you want feedback from developers. You can add to your own personal repository and it will continue to feed into the Pull Request so that you can ask code-specific questions mid-development.

@tresf
Member
tresf commented Jul 30, 2015

Furthermore, @mattdeckard said he was starting this feature too, so you may want to collaborate with him (such as give him access to your personal repo or vice versa). This will ensure we don't have unnecessary redundancies in terms of work effort.

Edit: The #lmms channel on IRC is a good place to discuss as well.

@rageboge
Contributor

thanks for the info @tresf , I could test only my configuration and some feedback from other developers is more than welcome!
I'll try to clean it up a bit and have a look to the pull request procedure, the code is currently on my private git server cloned from github.

@rageboge
Contributor

created pull request for the feedback #2228

@tresf
Member
tresf commented Jul 31, 2015

@rageboge terrific! I've edited your post with a link to the PR. I've also edited the PR body text to include Closes #1153 to link them, from a merge perspective.

@rageboge
Contributor
rageboge commented Aug 1, 2015

thanks @tresf

@mattdeckard

@rageboge Thanks for working on this! I had started looking into it a few weeks back but then life got in the way and I wasn't able to get very far. If I have time this week I'll test a build with your pull request branch with my MIDI controller to see how it works.

@tresf
Member
tresf commented Aug 3, 2015

I'll test a build with your pull request branch with my MIDI controller to see how it works.

👍

@rageboge
Contributor
rageboge commented Aug 3, 2015

@mattdeckard you are welcome! That's life, I also try too many things, but then I have to focus on what is more important in that moment. It would be great if you have time for a test. I'm adjusting the code, but the main part is already in. Any feedback would be really appreciated 👍

@tresf
Member
tresf commented Aug 6, 2015

I vote we get the commits squashed and merge this. This is minimally impacting and we can make patches as we go along.

@rageboge
Contributor
rageboge commented Aug 7, 2015

I vote we get the commits squashed and merge this. This is minimally impacting and we can make patches as we go along.

👍
some testing would be nice to have, but I'm fine to get it merged and work with patches in case of issues or for improvements.
In case of updates (lmms was already installed), I think the value for midi interface should already be set to "dummy" as it was the normal value for mac, so the users have to explicitly select "apple midi". The feature could be set as experimental and eventually they can always disable it by setting again the value "dummy" as midi interface.

@tresf
Member
tresf commented Aug 7, 2015

@rageboge before you squash your commits, can you touch up the formatting as mentioned in the PR? Once that's done, we can merge it in. We create a release candidate prior to adding major features, so this will be downloadable as a DMG for a while prior to its official release, so hopefully that will bring in the testing needed to get any patches out the door prior to the official 1.2 release.

@rageboge
Contributor
rageboge commented Aug 8, 2015

@tresf I just pushed a commit which I should solve the formatting issues. One point is still pending (from your comment) but the other comments should be fixed now. I'll then squash the commits
The release plan you described looks very good, thanks for explaining.
Do you have a standard commit message that you want me to use?

@tresf
Member
tresf commented Aug 8, 2015

Responded via #2228 (comment), thanks.

As far as a commit message, your judgement is as good as ours. Your initial commit message "Add basic apple midi support" is just as good as any. 👍

@rageboge
Contributor
rageboge commented Aug 8, 2015

great! Thanks.

@rageboge rageboge added a commit to rageboge/lmms that referenced this issue Aug 8, 2015
@rageboge rageboge #1153: added basic apple midi support c15b675
@rageboge rageboge added a commit to rageboge/lmms that referenced this issue Aug 8, 2015
@rageboge rageboge #1153: added basic apple midi support f5f5f7b
@rageboge rageboge added a commit to rageboge/lmms that referenced this issue Aug 9, 2015
@rageboge rageboge #1153: added basic apple midi support 275bcb5
@Wallacoloo Wallacoloo closed this in #2228 Aug 9, 2015
@ThomasJClark ThomasJClark added a commit to ThomasJClark/lmms that referenced this issue Sep 12, 2015
@rageboge @ThomasJClark rageboge + ThomasJClark #1153: added basic apple midi support 5f2d8e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment