Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when moving mixer channels to left/right #1584

Closed
badosu opened this issue Jan 9, 2015 · 4 comments
Closed

Crash when moving mixer channels to left/right #1584

badosu opened this issue Jan 9, 2015 · 4 comments
Labels
bug
Milestone
1.2.0

Comments

@badosu
Copy link
Contributor

badosu commented Jan 9, 2015

Sometimes you are able to cause a Segmentation Fault when using the "Move Right"/"Move Left" functionality on mixer channels.

I was not able to identify how to reproduce this error deterministically, but you should be able to trigger this just moving nearby channels at the rightmost part of the mixer.

The backtrace shows that this is the offending line:

lmms/src/gui/widgets/FxLine.cpp

Line 208 in 4043868

contextMenu->exec( QCursor::pos() );

Full backtrace here: https://gist.github.com/badosu/54bf4c6cd2d504daaab0
@badosu badosu changed the title Segmentation Fault when moving mixer channels to left/right Crash when moving mixer channels to left/right Jan 9, 2015
@tresf
Copy link
Member

tresf commented Jan 9, 2015

#1545

@tresf tresf added the bug label Jan 9, 2015
@tresf tresf added this to the 1.2.0 milestone Jan 9, 2015
@badosu
Copy link
Contributor Author

badosu commented Jan 9, 2015

@tresf I don't know if this is exactly the same bug. But may be related.

@tresf
Copy link
Member

tresf commented Jan 9, 2015

@tresf I don't know if this is exactly the same bug. But may be related.

Yeah, I just wanted to link them in case they are. I should have put a contextual message with that tag. 🐓

@lukas-w
Copy link
Member

lukas-w commented Jan 9, 2015

Same issue as #872

badosu added a commit to badosu/lmms that referenced this issue Jan 14, 2015
@badosu
Fix segfault when moving channels
abc0461 
Fixes LMMS#1584
@badosu badosu mentioned this issue Jan 14, 2015
Closed
badosu added a commit to badosu/lmms that referenced this issue Jan 14, 2015
@badosu
Fix segfault when moving channels
a399a21 
Fixes LMMS#1584
badosu added a commit to badosu/lmms that referenced this issue Jan 23, 2015
@badosu
Fix segfault when moving channels
49d7d91 
This commit addresses a lot of issues, namely:

1. When the "Move left/right" action was selected on a mixer channel
menu sometimes it would segfault due to the fxline object being
deleted before it returned to a method inside itself

2. The Fader was declaring a new variable for the model whereas it
should used the inherited model from FloatModelView < AutomatableModelView

3. Some methods were doing more things than they should be and
performing unnecessary actions. A little cleanup/refactor was made

Please notice that a bug of the same class as the one referred at point 1
still exists: clicking on "Remove channel". This commit does not
addresses this issue.

Fixes LMMS#1584
@badosu badosu mentioned this issue Jan 23, 2015
Merged
badosu added a commit to badosu/lmms that referenced this issue Jan 23, 2015
@badosu
Fix segfault when moving channels
e919912 
This commit addresses a lot of issues, namely:

1. When the "Move left/right" action was selected on a mixer channel
menu sometimes it would segfault due to the fxline object being
deleted before it returned to a method inside itself

2. The Fader was declaring a new variable for the model whereas it
should used the inherited model from FloatModelView < AutomatableModelView

3. Some methods were doing more things than they should be and
performing unnecessary actions. A little cleanup/refactor was made

Please notice that a bug of the same class as the one referred at point 1
still exists: clicking on "Remove channel". This commit does not
addresses this issue.

Fixes LMMS#1584
@badosu badosu mentioned this issue Jan 23, 2015
Closed
Wallacoloo pushed a commit to Wallacoloo/lmms that referenced this issue Apr 19, 2015
@badosu @Wallacoloo
Fix segfault when moving channels
280b91c 
This commit addresses a lot of issues, namely:

1. When the "Move left/right" action was selected on a mixer channel
menu sometimes it would segfault due to the fxline object being
deleted before it returned to a method inside itself

2. The Fader was declaring a new variable for the model whereas it
should used the inherited model from FloatModelView < AutomatableModelView

3. Some methods were doing more things than they should be and
performing unnecessary actions. A little cleanup/refactor was made

Please notice that a bug of the same class as the one referred at point 1
still exists: clicking on "Remove channel". This commit does not
addresses this issue.

Fixes LMMS#1584
Wallacoloo pushed a commit to Wallacoloo/lmms that referenced this issue Apr 20, 2015
@badosu @Wallacoloo
Fix segfault when moving channels
00261eb 
This commit addresses a lot of issues, namely:

1. When the "Move left/right" action was selected on a mixer channel
menu sometimes it would segfault due to the fxline object being
deleted before it returned to a method inside itself

2. The Fader was declaring a new variable for the model whereas it
should used the inherited model from FloatModelView < AutomatableModelView

3. Some methods were doing more things than they should be and
performing unnecessary actions. A little cleanup/refactor was made

Please notice that a bug of the same class as the one referred at point 1
still exists: clicking on "Remove channel". This commit does not
addresses this issue.

Fixes LMMS#1584
@tresf tresf mentioned this issue Apr 23, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
3 participants
@badosu @lukas-w @tresf