Crash when moving mixer channels to left/right #1584

Closed
badosu opened this Issue Jan 9, 2015 · 4 comments

Projects

None yet

3 participants

@badosu
Contributor
badosu commented Jan 9, 2015

Sometimes you are able to cause a Segmentation Fault when using the "Move Right"/"Move Left" functionality on mixer channels.

I was not able to identify how to reproduce this error deterministically, but you should be able to trigger this just moving nearby channels at the rightmost part of the mixer.

The backtrace shows that this is the offending line: https://github.com/LMMS/lmms/blob/40438689922e843fcf07d22dd52378cb7e5237d5/src/gui/widgets/FxLine.cpp#L208

Full backtrace here: https://gist.github.com/badosu/54bf4c6cd2d504daaab0

@badosu badosu changed the title from Segmentation Fault when moving mixer channels to left/right to Crash when moving mixer channels to left/right Jan 9, 2015
@tresf
Member
tresf commented Jan 9, 2015
@tresf tresf added the bug label Jan 9, 2015
@tresf tresf added this to the 1.2.0 milestone Jan 9, 2015
@badosu
Contributor
badosu commented Jan 9, 2015

@tresf I don't know if this is exactly the same bug. But may be related.

@tresf
Member
tresf commented Jan 9, 2015

@tresf I don't know if this is exactly the same bug. But may be related.

Yeah, I just wanted to link them in case they are. I should have put a contextual message with that tag. 🐓

@Lukas-W
Member
Lukas-W commented Jan 9, 2015

Same issue as #872

@badosu badosu added a commit to badosu/lmms that referenced this issue Jan 14, 2015
@badosu badosu Fix segfault when moving channels
Fixes #1584
abc0461
@badosu badosu added a commit to badosu/lmms that referenced this issue Jan 14, 2015
@badosu badosu Fix segfault when moving channels
Fixes #1584
a399a21
@badosu badosu added a commit to badosu/lmms that referenced this issue Jan 23, 2015
@badosu badosu Fix segfault when moving channels
This commit addresses a lot of issues, namely:

1. When the "Move left/right" action was selected on a mixer channel
menu sometimes it would segfault due to the fxline object being
deleted before it returned to a method inside itself

2. The Fader was declaring a new variable for the model whereas it
should used the inherited model from FloatModelView < AutomatableModelView

3. Some methods were doing more things than they should be and
performing unnecessary actions. A little cleanup/refactor was made

Please notice that a bug of the same class as the one referred at point 1
still exists: clicking on "Remove channel". This commit does not
addresses this issue.

Fixes #1584
49d7d91
@badosu badosu added a commit to badosu/lmms that referenced this issue Jan 23, 2015
@badosu badosu Fix segfault when moving channels
This commit addresses a lot of issues, namely:

1. When the "Move left/right" action was selected on a mixer channel
menu sometimes it would segfault due to the fxline object being
deleted before it returned to a method inside itself

2. The Fader was declaring a new variable for the model whereas it
should used the inherited model from FloatModelView < AutomatableModelView

3. Some methods were doing more things than they should be and
performing unnecessary actions. A little cleanup/refactor was made

Please notice that a bug of the same class as the one referred at point 1
still exists: clicking on "Remove channel". This commit does not
addresses this issue.

Fixes #1584
e919912
@tresf tresf closed this in #1678 Apr 17, 2015
@Wallacoloo Wallacoloo added a commit to Wallacoloo/lmms that referenced this issue Apr 19, 2015
@badosu @Wallacoloo badosu + Wallacoloo Fix segfault when moving channels
This commit addresses a lot of issues, namely:

1. When the "Move left/right" action was selected on a mixer channel
menu sometimes it would segfault due to the fxline object being
deleted before it returned to a method inside itself

2. The Fader was declaring a new variable for the model whereas it
should used the inherited model from FloatModelView < AutomatableModelView

3. Some methods were doing more things than they should be and
performing unnecessary actions. A little cleanup/refactor was made

Please notice that a bug of the same class as the one referred at point 1
still exists: clicking on "Remove channel". This commit does not
addresses this issue.

Fixes #1584
280b91c
@Wallacoloo Wallacoloo added a commit to Wallacoloo/lmms that referenced this issue Apr 20, 2015
@badosu @Wallacoloo badosu + Wallacoloo Fix segfault when moving channels
This commit addresses a lot of issues, namely:

1. When the "Move left/right" action was selected on a mixer channel
menu sometimes it would segfault due to the fxline object being
deleted before it returned to a method inside itself

2. The Fader was declaring a new variable for the model whereas it
should used the inherited model from FloatModelView < AutomatableModelView

3. Some methods were doing more things than they should be and
performing unnecessary actions. A little cleanup/refactor was made

Please notice that a bug of the same class as the one referred at point 1
still exists: clicking on "Remove channel". This commit does not
addresses this issue.

Fixes #1584
00261eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment