New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when moving mixer channels to left/right #1584

Closed
badosu opened this Issue Jan 9, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@badosu
Contributor

badosu commented Jan 9, 2015

Sometimes you are able to cause a Segmentation Fault when using the "Move Right"/"Move Left" functionality on mixer channels.

I was not able to identify how to reproduce this error deterministically, but you should be able to trigger this just moving nearby channels at the rightmost part of the mixer.

The backtrace shows that this is the offending line:

contextMenu->exec( QCursor::pos() );

Full backtrace here: https://gist.github.com/badosu/54bf4c6cd2d504daaab0

@badosu badosu changed the title from Segmentation Fault when moving mixer channels to left/right to Crash when moving mixer channels to left/right Jan 9, 2015

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf
Member

tresf commented Jan 9, 2015

@tresf tresf added the bug label Jan 9, 2015

@tresf tresf added this to the 1.2.0 milestone Jan 9, 2015

@badosu

This comment has been minimized.

Show comment
Hide comment
@badosu

badosu Jan 9, 2015

Contributor

@tresf I don't know if this is exactly the same bug. But may be related.

Contributor

badosu commented Jan 9, 2015

@tresf I don't know if this is exactly the same bug. But may be related.

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Jan 9, 2015

Member

@tresf I don't know if this is exactly the same bug. But may be related.

Yeah, I just wanted to link them in case they are. I should have put a contextual message with that tag. 🐓

Member

tresf commented Jan 9, 2015

@tresf I don't know if this is exactly the same bug. But may be related.

Yeah, I just wanted to link them in case they are. I should have put a contextual message with that tag. 🐓

@lukas-w

This comment has been minimized.

Show comment
Hide comment
@lukas-w

lukas-w Jan 9, 2015

Member

Same issue as #872

Member

lukas-w commented Jan 9, 2015

Same issue as #872

badosu added a commit to badosu/lmms that referenced this issue Jan 14, 2015

badosu added a commit to badosu/lmms that referenced this issue Jan 14, 2015

badosu added a commit to badosu/lmms that referenced this issue Jan 23, 2015

Fix segfault when moving channels
This commit addresses a lot of issues, namely:

1. When the "Move left/right" action was selected on a mixer channel
menu sometimes it would segfault due to the fxline object being
deleted before it returned to a method inside itself

2. The Fader was declaring a new variable for the model whereas it
should used the inherited model from FloatModelView < AutomatableModelView

3. Some methods were doing more things than they should be and
performing unnecessary actions. A little cleanup/refactor was made

Please notice that a bug of the same class as the one referred at point 1
still exists: clicking on "Remove channel". This commit does not
addresses this issue.

Fixes #1584

badosu added a commit to badosu/lmms that referenced this issue Jan 23, 2015

Fix segfault when moving channels
This commit addresses a lot of issues, namely:

1. When the "Move left/right" action was selected on a mixer channel
menu sometimes it would segfault due to the fxline object being
deleted before it returned to a method inside itself

2. The Fader was declaring a new variable for the model whereas it
should used the inherited model from FloatModelView < AutomatableModelView

3. Some methods were doing more things than they should be and
performing unnecessary actions. A little cleanup/refactor was made

Please notice that a bug of the same class as the one referred at point 1
still exists: clicking on "Remove channel". This commit does not
addresses this issue.

Fixes #1584

@tresf tresf closed this in #1678 Apr 17, 2015

Wallacoloo added a commit to Wallacoloo/lmms that referenced this issue Apr 19, 2015

Fix segfault when moving channels
This commit addresses a lot of issues, namely:

1. When the "Move left/right" action was selected on a mixer channel
menu sometimes it would segfault due to the fxline object being
deleted before it returned to a method inside itself

2. The Fader was declaring a new variable for the model whereas it
should used the inherited model from FloatModelView < AutomatableModelView

3. Some methods were doing more things than they should be and
performing unnecessary actions. A little cleanup/refactor was made

Please notice that a bug of the same class as the one referred at point 1
still exists: clicking on "Remove channel". This commit does not
addresses this issue.

Fixes #1584

Wallacoloo added a commit to Wallacoloo/lmms that referenced this issue Apr 20, 2015

Fix segfault when moving channels
This commit addresses a lot of issues, namely:

1. When the "Move left/right" action was selected on a mixer channel
menu sometimes it would segfault due to the fxline object being
deleted before it returned to a method inside itself

2. The Fader was declaring a new variable for the model whereas it
should used the inherited model from FloatModelView < AutomatableModelView

3. Some methods were doing more things than they should be and
performing unnecessary actions. A little cleanup/refactor was made

Please notice that a bug of the same class as the one referred at point 1
still exists: clicking on "Remove channel". This commit does not
addresses this issue.

Fixes #1584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment