Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting -- Placeholder folders (and files) in user directory for Ladspa, VSTs, themes and templates #1807

Closed
curlymorphic opened this issue Mar 2, 2015 · 85 comments
Labels
Milestone

Comments

@curlymorphic
Copy link
Contributor

@curlymorphic curlymorphic commented Mar 2, 2015

This issue is to keep track of progress in #1541 as it covers a lot or areas. I am planing on breaking it down into the following areas

  • Settings Dialog
    • Add Scrollbar to path selection list
    • Move STK raw waves, Default SF2, to bottom of list
    • This dialog needs instructions and possibly enhanced to allow multiple selections. It's not obvious that you can have more than one search path for some of these values, that should be spelled out IMO.
    • Artwork should be renamed "Themes" in my opinion, kept on paths page.
  • Folders
    • Sample, GIG, SF2, folders created (#1541)
    • Add folders to setting tab
    • Connect up to make these folders the default when open this type of file.
  • Plugins
    • Add user directories,
    • Options added to setting dialog

I plan on keeping this initial post updated

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented Mar 2, 2015

If we are to have a Miscellaneous tab on the setting dialog, we are going to need an icon. I am unfamiliar with lmms artwork, do we already have an icon we can use, or what is required in making one. My gimp skill are not the best, is anyone able to help this this please?

image

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented Mar 2, 2015

ty for cleaning up my original post :)

@Sti2nd
Copy link
Contributor

@Sti2nd Sti2nd commented Mar 2, 2015

I am not against a new tab, but I want to point out that you could possibly make the window scrollable if you think some settings belong to for example the path tab

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented Mar 2, 2015

you could possibly make the window scrollable

Thats a nice idea. It would give us room to expand with ease, and have mimimal impact, on both the user experience, and current code base.

@tresf
Copy link
Member

@tresf tresf commented Mar 2, 2015

I am not against a new tab, but I want to point out that you could possibly make the window scrollable if you think some settings belong to for example the path tab

True... we could just put them at the bottom.

In regards to the artwork, if you make a new button, please make it as ugly as possible. It makes people cringe and then they make a better one.

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented Mar 2, 2015

image
There is the new icon :) until someone donates better

if we need one. Lets see what everyone thinks?

@tresf
Copy link
Member

@tresf tresf commented Mar 2, 2015

There is the new icon :)

Perfect! Haha.

Lets see what everyone thinks?

I think the scroll area is just fine in this case. I think if we put the less used ancillary ones at the very bottom it is actually more effective then putting them on an unrelated Misc tab. 👍

@Spekular
Copy link
Contributor

@Spekular Spekular commented Mar 2, 2015

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented Mar 4, 2015

Small progress. I have wrapped the Path options in a scroll area, and adjusted sizes to suit.

image

This dialog needs instructions and possibly enhanced to allow multiple selections. It's not obvious that you can have more than one search path for some of these values, that should be spelled out IMO.

It's so un obvious I don't know what ones can have multiple selections, or how. So i gess the questions are

  1. what paths can have multiple selections
  2. how should be be portrayed in the gui.
@tresf
Copy link
Member

@tresf tresf commented Mar 4, 2015

what paths can have multiple selections

Can:

  • LADSPA PLUGIN PATHS

Should:

  • VST-PLUGIN DIRECTORY

Will when we add support for it:

  • SF2-PLUGINS DIRECTORY (name?)
  • VST-INTRUMENT-PLUGIN DIRECTORY (name?)

Doesn't but may eventually:

  • THEMES DIRECTORY
  • STK RAWWAVE DIRECTORY

Can't:

  • LMMS WORKING DIRECTORY
  • BACKGROUND ARTWORK
  • FL STUDIO INSTALLATION DIRECTORY
  • DEFAULT SOUNDFONT

how should be be portrayed in the gui.

I would recommend a single folder icon for "set directory value" and a different icon (with a plus or multiple folder icon) for "add additional directory value".

-Tres

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented Mar 5, 2015

When we are referring to multiple selections, are we meaning the default locations + 1 user location, I currently cant find a way to set more than 1 LADSPA directory.

I would recommend a single folder icon for "set directory value" and a different icon (with a plus or multiple folder icon) for "add additional directory value".

Would clicking on the "plus" icon, add an additional row to the table, with the heading duplicated?

i.e adding a second vst directory would result in this list?

working dir
vst
vst
Themes
backg.........

@Sti2nd
Copy link
Contributor

@Sti2nd Sti2nd commented Mar 5, 2015

I currently cant find a way to set more than 1 LADSPA directory.

If you cannot by separating the paths with semicolon I guess it is not supported?

@tresf
Copy link
Member

@tresf tresf commented Mar 5, 2015

I currently cant find a way to set more than 1 LADSPA directory.

Neither could #1170 ;)

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented Mar 5, 2015

Neither could #1170 ;)

well we have a standard. we use comma separated lists.

now a plus sign makes more sense.

I think i might do a couple of mock up's for this, im having trouble visualizing this on the ui.

@tresf
Copy link
Member

@tresf tresf commented Mar 5, 2015

For starters, we can probably get away with treating the data as a CSV so we don't muck up the GUI too much for a small enhancement and just leave the fields as-is.

We should also consider consolidating on either "PATH" or "DIRECTORY" in the descriptions to be consistent.

image

-Tres

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented Mar 5, 2015

@tresf 👍
That is much better than what I had in mind. I will try and get this done tomorrow, the ui at least.

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented Mar 5, 2015

Having experimented, currenlty if you click on the folder icon next to LADSPA, it adds it to a cvs list.

should we keep this current behaviour, or add the plus button?

@tresf
Copy link
Member

@tresf tresf commented Mar 5, 2015

you click on the folder icon next to LADSPA, it adds it to a cvs list.

should we keep this current behaviour, or add the plus button?

Keep, but we should make it clear what is happening. I suggest we use the plural (PATHS or DIRECORIES) and make a modified browse button with a Plus indicator.

If you'd rather not fiddle with the artwork, an ugly mockup should be sufficient until someone has time to make a new pixmap. 👍

-Tres

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented Mar 5, 2015

I suggest we use the plural (PATHS or DIRECORIES)

Paths or Directories?

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented Mar 6, 2015

image

Changed The Icon to show Directories that can have multiple values, currenly thats just LADSPA plugings. I will leave the creation of the user plugin directorys, until the plugin phase of this project.
Other than a reorder of the list hopefully the setting dialog is now ready to move onto the next stage.

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented Mar 6, 2015

Folders

If i suggest a file structure here, at least we have something to work from.

lmms
____projects
____templates
____samples
________gig
________sf2
____presets
____themes
____plugins
________ladspa
________vsteffects
________vstinstruments

Are there any comments on this, what have I missed?

@tresf
Copy link
Member

@tresf tresf commented Mar 6, 2015

The +folder icon needs to be replaced with a new placeholder I feel (that one is for

Besides that, the GUI looks great to me.

As far as establishing places for this stuff moving forward, I'd really like @Umcaruje @Sti2nd @mikobuntu @grejppi @cubician's opinions. Once we pick these folder names, we're bound to stick with them for year to come, so opinions matter here... :)

@mikobuntu
Copy link
Contributor

@mikobuntu mikobuntu commented Mar 6, 2015

@tresf @curlymorphic I will have a good think about the folder names and the file structure, but for now yes I agree the "+" icon could do with being more noticeable and I would like the Plugins to actually have their own tab, this I will need to get out pen and paper and have a good think about , but basically " anything that is part of the sound creation should not be in the same tab as themes, installation directories, background artwork etc" imo ;)

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented Mar 6, 2015

@curlymorphic"stops coding until design is completed"

@mikobuntu
Copy link
Contributor

@mikobuntu mikobuntu commented Mar 6, 2015

@curlymorphic " curlymorphic looks at the issue tracker and works on another bug " haha ;)

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented Mar 6, 2015

@curlymorphic decides to atleast finish connecting the gig directory up before moving on

@tresf
Copy link
Member

@tresf tresf commented Mar 27, 2015

Dave, thanks for staying on top of this. Please rebase the PR and I think we can merge it in.

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented Mar 27, 2015

@tresf you want me to rebase #1791 ?

on a positive note, looking at the code I had already done, theses not too much left to be done on this :)

ps. Ive already just rebased my branch for this issue.

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented Mar 27, 2015

Please ignore the above question. :(

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented Mar 27, 2015

The Directories are now all correctly added. The new locations are used in there relavant place, (sf2 player uses the sf2 folder), The new folders have been added to the path dialog in a scroll area.

The only outstanding item is @mikobuntu redesign of the dialog, I feel maybe this should be a separate issue?

If anyone wants to look

git clone -b pathDialog https://github.com/curlymorphic/lmms.git

@tresf is it ok / desirable for me to post a test windows build here?'

@tresf
Copy link
Member

@tresf tresf commented Mar 27, 2015

@tresf is it ok / desirable for me to post a test windows build here?'

Please feel free to do to this for any items that you feel aren't getting the proper user feedback. It certainly helps, and then you can tag the Windows users. Just remember that this is a 1.2.x release which may come with some undiscovered bugs of its own! 👍

@tresf
Copy link
Member

@tresf tresf commented Mar 27, 2015

@curlymorphic if you are not sure where to upload the Windows builds to, I would recommend you upload them to https://github.com/curlymorphic/lmms/releases

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented Mar 27, 2015

if you are not sure where to upload the Windows builds to, I would recommend you upload them to https://github.com/curlymorphic/lmms/releases

https://github.com/curlymorphic/lmms/releases/download/untagged-5486edfa53ee8f0a37f6/lmmsCurlyDefaultFolderTestmk1.exe.

note. lmms will used currently save folders if you already have them set ( if your reading this im 99.999% sure you do ) so you may want to rename your .lmmsrc.xml so a fresh config is created.

@musikBear
Copy link

@musikBear musikBear commented Mar 28, 2015

download link leads to a 404 error

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented Mar 28, 2015

@musikBear sorry. Maybe I didn,t set up the release properly. I think its done now
https://github.com/curlymorphic/lmms/releases/tag/paths

@musikBear
Copy link

@musikBear musikBear commented Mar 29, 2015

@curlymorphic its fine now. i will install and come back 👍


..Back :p
What i have done:
Removed' current lmmsrc.xml
Installed PR
The installation goes perfect, except that the info on the forms are in-correctly showing 'installing 1.1.0'
lmms113installerrors

Opend PR
Settings form opens automatically as wanted
Deleted all default path
Inserted new dummies
It is possible to insert a combo-path for ladspa, but not for vst
Saved
lmms correctly shows warning about effectiveness of changes.
Closed & reopend lmms
All path created are preserved

Are there any other tests we want done?

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented Mar 29, 2015

@musikBear

thanks for doing this testing :)

in-correctly showing 'installing 1.1.0'

this is based on master, that is still set to 1.1.0, I am assuming that once this forks into the 1.2 branch that will change.

It is possible to insert a combo-path for ladspa, but not for vst

At the moment yes, but that will get addressed by #1837

Are there any other tests we want done?

could be worth checking the sf2 player opens the correct folder, same for gig, please.

I can finally feel a PR comming up :)

@tresf
Copy link
Member

@tresf tresf commented Mar 29, 2015

👍

@musikBear
Copy link

@musikBear musikBear commented Mar 30, 2015

could be worth checking the sf2 player opens the correct folder, same for gig, please.

will do that later -only thing though -I dont have any 'gig' files, and i do not know where to get any.. so :|

@tresf
Copy link
Member

@tresf tresf commented Mar 30, 2015

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented Mar 30, 2015

@musikBear cheers for the effort, The tests my end work ok, so im going to open a PR.

@musikBear
Copy link

@musikBear musikBear commented Mar 30, 2015

@musikBear cheers for the effort, The tests my end work ok, so im going to open a PR.

@curlymorphic -Just ping me if you like more tests. Looking fwd to the PR 👍

@tresf
Copy link
Member

@tresf tresf commented Mar 30, 2015

@musikBear did you manage to download and test a .gig file? Here's a small one: FS_Percussion.tar.bz2. Extract with 7-zip on Windows.

image

-Tres

@musikBear
Copy link

@musikBear musikBear commented Mar 31, 2015

Here's a small one:

Harh harh ha.. u 👹
I found one, but it wont unpack - Besides, These files unpack to gigabyte size.. Oo
What is so absurdly marvelous with gig? They are 'real' samples, i guess, but is that quality preserved in exports. At least my, admitted outdated, system, does not have space for samples in gigabyte disk-size, nor does my isp monthly '-limit' fair-use allow me to dl files of that size..

@tresf
Copy link
Member

@tresf tresf commented Mar 31, 2015

What is so absurdly marvelous with gig?

Very similar to soundfonts. If you don't appreciate soundfonts, you won't appreciate Giga banks either.

I found one, but it wont unpack - Besides, These files unpack to gigabyte size..

I linked one for you that was in MB, not GB. #1807 (comment)

@tresf
Copy link
Member

@tresf tresf commented Apr 13, 2015

@curlymorphic how are we with test results on this? Should we merge?

-Tres

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented Apr 13, 2015

@tresf

So far this has only been tested by myself and @musikBear , My test releases seem to not get too much attention.

I would say merge it,

@tresf tresf closed this in #1908 Apr 13, 2015
@tresf
Copy link
Member

@tresf tresf commented Apr 13, 2015

Tremendous Dave. This puts a big smile on my face. 🚀

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented Apr 13, 2015

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
9 participants
You can’t perform that action at this time.