LMMS displays templates as last opened project

[Sti2nd]

Since I have edited the default template, and that is loaded on startup, LMMS ALWAYS says that default.mpt was the last project. So it should not say it for default.mpt, at least

[Sti2nd]

PS: I like how the slashes are mixed between forward and backward

[tresf]

PS: I like how the slashes are mixed between forward and backward

Yeah that is a cleanup task for us to tackle on a rainy day. :)

LMMS [...] says that default.mpt was the last project.

Good find. We should remove all templates from that list via ConfigManager.cpp#L192.

Something like this perhaps...

void ConfigManager::addRecentlyOpenedProject( const QString & _file )
{
    ////  ADD TEMPLATE EXTENSION CHECK
    if ( ! _file.endsWith( ".mpt" ) ) {
        m_recentlyOpenedProjects.removeAll( _file );
        if( m_recentlyOpenedProjects.size() > 15 )
        {
            m_recentlyOpenedProjects.removeLast();
        }
        m_recentlyOpenedProjects.push_front( _file );
        ConfigManager::inst()->saveConfigFile();
    }
}

[M374LX]

Actually, the template used is shown as the last opened project every time one creates a project from a template, not only from the default one. This should not happen with any template at all.

A better solution than @tresf's suggestion is to check the file name within Song::loadProject(), which is called from Song::createNewProjectFromTemplate().

At Song.cpp line 1045, we could replace:

ConfigManager::inst()->addRecentlyOpenedProject( fileName );

with

if ( !fileName.endsWith( ".mpt" ) )
{
    ConfigManager::inst()->addRecentlyOpenedProject( fileName );
}

[tresf]

Yes, much cleaner!

[M374LX]

One more detail is that creating a new project from a template created with an old version of LMMS show a message like
This project was created with LMMS version x.x.x, but version x.x.x is installed
It is better to use the word "template" instead of "project".

The method where the message is shown is DataFile::loadData().

[tresf]

One more detail is that creating a new project from a template created with an old version of LMMS show a message like
This project was created with LMMS version x.x.x, but version x.x.x is installed
It is better to use the word "template" instead of "project".

We should probably file a separate issue for that.

[tresf]

@M374LX actually, I think my proposed solution is more scalable. Why put the logic in an unrelated class?

[M374LX]

@tresf
I have just seen that ConfigManager::addRecentlyOpenedProject() is also called from Song::guiSaveProject(). So, in case you prefer saved templates not to be listed as recent projects, your solution is really better.

[tresf]

👍

[M374LX]

We should probably file a separate issue for that.

Filed: #1869