New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent clamping behavior in automation editor #1907

Closed
Wallacoloo opened this Issue Mar 30, 2015 · 7 comments

Comments

Projects
None yet
3 participants
@Wallacoloo
Member

Wallacoloo commented Mar 30, 2015

When moving a point in the automation editor, if I drag the cursor outside of the window to the right, the point will still follow the cursor. But if I drag it outside the left of the editor, then it stops updating. The gif below should explain it better.

Inconsistent Automation Editing

This behavior seems inconsistent. Is it by design or is it a flaw?

(This behavior was observed in a fresh build from the git repository using the latest commit: c1a2fde)

@Spekular

This comment has been minimized.

Show comment
Hide comment
@Spekular

Spekular Mar 30, 2015

Contributor
Contributor

Spekular commented Mar 30, 2015

@Wallacoloo

This comment has been minimized.

Show comment
Hide comment
@Wallacoloo

Wallacoloo Mar 30, 2015

Member

To be clear, there is about another 1.25 measures offscreen to the left in that gif. This was not the result of trying to place an automation point at some time < 0.

Member

Wallacoloo commented Mar 30, 2015

To be clear, there is about another 1.25 measures offscreen to the left in that gif. This was not the result of trying to place an automation point at some time < 0.

@Spekular

This comment has been minimized.

Show comment
Hide comment
@Spekular

Spekular Mar 30, 2015

Contributor

Yup, I noticed the scrollbar. I'm just guessing that the reason for the boundary is to prevent
people from placing points too far left, and no exception has been made for
when you've actually got a valid area on the left. Would be cool if even when you're at the edge it would let you drag beyond and place the point at the intersect of the edge and the line between your cursor and the next point (to make it behave as if there were a point beyond the edge). Or "just" snap properly to the edge and get the cursor height.

Contributor

Spekular commented Mar 30, 2015

Yup, I noticed the scrollbar. I'm just guessing that the reason for the boundary is to prevent
people from placing points too far left, and no exception has been made for
when you've actually got a valid area on the left. Would be cool if even when you're at the edge it would let you drag beyond and place the point at the intersect of the edge and the line between your cursor and the next point (to make it behave as if there were a point beyond the edge). Or "just" snap properly to the edge and get the cursor height.

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Mar 30, 2015

Member

Possible location:

AutomationEditor.cpp#L613

It should set the point to 0 rather than not processing the mouse move event. It is a rather large function, but should be a relatively small change. @Spekular you have some experience in this regard... do you have any interest in patching this behavior?

Member

tresf commented Mar 30, 2015

Possible location:

AutomationEditor.cpp#L613

It should set the point to 0 rather than not processing the mouse move event. It is a rather large function, but should be a relatively small change. @Spekular you have some experience in this regard... do you have any interest in patching this behavior?

@tresf tresf added the enhancement label Mar 30, 2015

@tresf tresf added this to the 1.3.0 milestone Mar 30, 2015

@Wallacoloo

This comment has been minimized.

Show comment
Hide comment
@Wallacoloo

Wallacoloo Mar 30, 2015

Member

Unless you really want to take this on, I'd like to give it a try instead. Been meaning to contribute to lmms for a while.

Member

Wallacoloo commented Mar 30, 2015

Unless you really want to take this on, I'd like to give it a try instead. Been meaning to contribute to lmms for a while.

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Mar 30, 2015

Member

Unless you really want to take this on, I'd like to give it a try instead. Been meaning to contribute to lmms for a while.

Absolutely, please do! 👍 If you need any help to get started, please ask!

Member

tresf commented Mar 30, 2015

Unless you really want to take this on, I'd like to give it a try instead. Been meaning to contribute to lmms for a while.

Absolutely, please do! 👍 If you need any help to get started, please ask!

Wallacoloo added a commit to Wallacoloo/lmms that referenced this issue Mar 30, 2015

tresf added a commit that referenced this issue Apr 1, 2015

Merge pull request #1910 from Wallacoloo/master
Fix for #1907 - inconsistent clamping behavior in automation editor
@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Apr 1, 2015

Member

Closed via #1910. Thanks @Wallacoloo!

Member

tresf commented Apr 1, 2015

Closed via #1910. Thanks @Wallacoloo!

@tresf tresf closed this Apr 1, 2015

@tresf tresf modified the milestones: 1.2.0, 1.3.0 Apr 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment