Marked semitones should be marked across all octaves. #2193

Closed
musikBear opened this Issue Jul 19, 2015 · 9 comments

Projects

None yet

5 participants

@musikBear

I think it would be better if this marked/unmarked all identical semitones over all octaves
(or 'over all octaves' could be added as new option)

(thought its been up before, but search did not reveal anything..?)

@Umcaruje
Member

@musikBear please offer some screenshots, mockups and further clarify this issue.

@musikBear

@Umcaruje i have added pictures, does that help?

current behavior
marksemicurrent

Suggested behavior
marksemicurrentsugg

from experience i find that there are two primary reason for semi-tone-marking:

  • I want to mark the tone, because i want to insert notes on that tone
  • I want to exclude that note from already existing markings (f.i. a marked scale)

If i want to insert, then i may like to insert on the note on more than one octave, if so, its neat that all identical semitones in all octaves are marked, if i dont, its quite easy to see what octave im working in, because they have numbers, so additional marked notes wont be a real problem.

If i want to exclude a note from already marked notes, it is logical to exclude that note from all octaves, and with current behavior, i will have to that manually, Suggested will do that for me.

most valuable would be where you examine f.i. a midi score, and like to see which semitones a certain notes has been used over many octaves. Specific, which notes has been doubled over 4 octaves. Marking.method like picture Suggested behavior, would make that task almost automatically

weather or not the current 'single method' still is needed, must be discussed, but a method to achieve, picture Suggested behavior, would enhance the workflow

@Umcaruje Umcaruje changed the title from Piano-roll, context option "Mark/unmark current semitone" to Marked semitones should be marked across all octaves. Aug 3, 2015
@unfa
Contributor
unfa commented Aug 15, 2015

I had this idea too. It'd make the option much more helpful.

@waxspin
Contributor
waxspin commented Sep 23, 2015

@musikBear @unfa I propose making it an additional option in the popup menu, so that the user has the option. I am implementing this now, but it's easy enough to not include the option in the menu if anyone thinks we shouldn't. To clarify, I mean have both the single mode, and the multi-mark mode as items in the menu.

EDIT: Clarification.

@musikBear

@waxspin that is a very fine solution. 👍

@waxspin waxspin added a commit to waxspin/lmms that referenced this issue Sep 24, 2015
@waxspin waxspin Add functionality to allow feature mentioned in #2193.
Fix declaration of return value.

Add mapping and new menu option for octave-marking of semitones.

Finish switch case for add/remove multiple octave semitones.

Fix segfault due to illogical access using iterators from one collection on another.
31a39ca
@waxspin waxspin added a commit to waxspin/lmms that referenced this issue Sep 24, 2015
@waxspin waxspin Add functionality to allow feature mentioned in #2193.
Fix declaration of return value.

Add mapping and new menu option for octave-marking of semitones.

Finish switch case for add/remove multiple octave semitones.

Fix segfault due to illogical access using iterators from one collection on another.
aaa412c
@waxspin waxspin added a commit to waxspin/lmms that referenced this issue Sep 24, 2015
@waxspin waxspin Add functionality to allow feature mentioned in #2193.
Fix declaration of return value.

Add mapping and new menu option for octave-marking of semitones.

Finish switch case for add/remove multiple octave semitones.

Fix segfault due to illogical access using iterators from one collection on another.

Make loop more succinct.
c40e5e3
@waxspin waxspin added a commit to waxspin/lmms that referenced this issue Sep 24, 2015
@waxspin waxspin Add functionality to allow feature mentioned in #2193.
Fix declaration of return value.

Add mapping and new menu option for octave-marking of semitones.

Finish switch case for add/remove multiple octave semitones.

Fix segfault due to illogical access using iterators from one collection on another.

Make loop more succinct.

Move PianoRoll::getAllOctavesForKey method to private access.
8fe3f17
@waxspin
Contributor
waxspin commented Sep 24, 2015

@musikBear @unfa I have completed this, and uploaded a win32 validation build here for you to test. Thanks in advance for the help!

@musikBear

@waxspin Very nice! It works very well indeed. 👍

Btw and Not related, but I think the differences in shading between marked notes, and the marked 'current-note' is too small:
forlilleforskel

The shading of the note in focus, 'current-note' is almost indistinct-able, from the notes that shows the current selected scale -Perhaps that need to be looked at in a different ticket.

@waxspin
Contributor
waxspin commented Sep 25, 2015

Awesome, glad it works well! I think the same about the highlighting, but perhaps we should open a new ticket for that.

@tresf
Member
tresf commented Sep 25, 2015

Closed via #2377.

@tresf tresf closed this Sep 25, 2015
@tresf tresf added this to the 1.2.0 milestone Sep 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment