Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sustain pedal not working with soundfont #2758

Closed
autumna opened this issue May 7, 2016 · 5 comments
Closed

sustain pedal not working with soundfont #2758

autumna opened this issue May 7, 2016 · 5 comments
Labels
bug
Milestone

Comments

@autumna
Copy link

@autumna autumna commented May 7, 2016

version: 1.1.91
Soundfont doesn't seem to detect the sustain in 1.1.91. This feature used to work on 1.1.3.

@DeRobyJ
Copy link
Contributor

@DeRobyJ DeRobyJ commented May 7, 2016

Related to #1700 maybe?

@autumna
Copy link
Author

@autumna autumna commented May 7, 2016

I did run into #1700 using both 1.1.3 and this current build. Sustain didn't and still doesn't record. :) However, the issue I am referring to is related to how the notes play as the notes are inputted from a midi keyboard:
In 1.1.3 when using sustain during recording, sound reflects the sustain even if it didn't record to the piano roll.
In 1.1.91 when you play with sustain not only you cannot hear the sustain, some of the long pressed begins sounding stacatto. (even through they are recording with what their current length would be without sustain).

@DeRobyJ
Copy link
Contributor

@DeRobyJ DeRobyJ commented May 8, 2016

Maybe the sustain pedal has been linked to decay. Seems like a bug then!

@tresf
Copy link
Member

@tresf tresf commented May 28, 2016

@softrabbit do you recall us touching any of the code that would impact MIDI/SF2 since 1.1.3?

@tresf tresf added this to the 1.2.0 milestone May 28, 2016
@softrabbit
Copy link
Member

@softrabbit softrabbit commented May 30, 2016

@softrabbit do you recall us touching any of the code that would impact MIDI/SF2 since 1.1.3?

Can't say I do. My understanding is that the SF2 player doesn't receive MIDI input at all, so the problem should be somewhere between the MIDI port and the spot where the NotePlayHandles or whatever are created. And it should then affect most instruments in a similar way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.