Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move search and refresh fields above file navigator #3657

Closed
WrillicR opened this issue Jun 23, 2017 · 16 comments
Closed

Move search and refresh fields above file navigator #3657

WrillicR opened this issue Jun 23, 2017 · 16 comments

Comments

@WrillicR
Copy link
Member

Moving the search field and the refresh button to the top of the file navigator would help the user's experience in many ways. It would:

  • Bring it to the direction of the user's eye (Then nobody has to "search" for the search)

  • Make it where people actually know it exists (I've heard many times of people not even knowing it existed)

  • Make the search more standard (you don't see Google's search on the bottom of the page)

(I may be able to provide some concept pictures tomorrow)

Thanks

@WrillicR
Copy link
Member Author

WrillicR commented Jun 23, 2017

Also adding a "Search" placeholder text in the text box would help. Here's the concept image:

image

@Sawuare
Copy link
Member

Sawuare commented Jun 23, 2017

Great proposal!
I didn't know that there were a search field and a refresh button tbh. 😆

michaelgregorius added a commit to michaelgregorius/lmms that referenced this issue Jun 23, 2017
…S#3657)

Move the search bar on top of the file browser for the following sidebar
windows:
* "My Projects"
* "My Samples"
* "My Presets"
* "My Home"
* "My Computer"

Also rename some variable names to something more meaningful. Rename the
member m_l of FileBrowser to m_fileBrowserTreeWidget. Rename the
following local variables in the constructor of FileBrowser:
* ops -> searchWidget
* opl -> searchWidgetLayout
@michaelgregorius
Copy link
Contributor

Move of the search bar to the top is implemented in pull request #3662 which is based on master.

@michaelgregorius
Copy link
Contributor

Commit 96b136f adds the placeholder text "Search". This is how it currently looks:
3657-filebrowser

Adding the default text was one line and much simpler than I would have thought. Qt for the win! 😄

@WrillicR
Copy link
Member Author

How does it look in the classic theme?

@michaelgregorius
Copy link
Contributor

@Mark-Agent003 This is how it looks with the classic theme:
3657-filebrowser-classic

@RebeccaDeField
Copy link
Contributor

@michaelgregorius Nicely done!

@BaraMGB
Copy link
Contributor

BaraMGB commented Jun 24, 2017

@Mark-Agent003 why do you closed this issue?

@michaelgregorius
Copy link
Contributor

Reopening this one so it can be closed once #3662 is integrated.

@WrillicR
Copy link
Member Author

I closed it because we already had a pull request open for this, and I didn't think we needed two separate discussions about the same thing. Do we actually need this open?

@grejppi
Copy link
Contributor

grejppi commented Jun 24, 2017

Yes, because it will be closed once the pull request is merged

@WrillicR
Copy link
Member Author

Ok, that's fine

@michaelgregorius
Copy link
Contributor

Shall I merge this one?

@tresf
Copy link
Member

tresf commented Jul 6, 2017

Shall I merge this one?

👍 from me.

@zonkmachine
Copy link
Member

Tested. Works much better on top!

michaelgregorius added a commit to michaelgregorius/lmms that referenced this issue Jul 7, 2017
…S#3657)

Move the search bar on top of the file browser for the following sidebar
windows:
* "My Projects"
* "My Samples"
* "My Presets"
* "My Home"
* "My Computer"

Add the greyed out text "Search" to the search text edit.
The text is only shown as long as no text is entered in the search field.

Also rename some variable names to something more meaningful. Rename the
member m_l of FileBrowser to m_fileBrowserTreeWidget. Rename the
following local variables in the constructor of FileBrowser:
* ops -> searchWidget
* opl -> searchWidgetLayout
michaelgregorius added a commit that referenced this issue Jul 7, 2017
Move the search bar on top of the file browser for the following sidebar
windows:
* "My Projects"
* "My Samples"
* "My Presets"
* "My Home"
* "My Computer"

Add the greyed out text "Search" to the search text edit.
The text is only shown as long as no text is entered in the search field.

Also rename some variable names to something more meaningful. Rename the
member m_l of FileBrowser to m_fileBrowserTreeWidget. Rename the
following local variables in the constructor of FileBrowser:
* ops -> searchWidget
* opl -> searchWidgetLayout
@michaelgregorius
Copy link
Contributor

Closed with #3662.

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this issue Jun 28, 2022
…S#3657)

Move the search bar on top of the file browser for the following sidebar
windows:
* "My Projects"
* "My Samples"
* "My Presets"
* "My Home"
* "My Computer"

Add the greyed out text "Search" to the search text edit.
The text is only shown as long as no text is entered in the search field.

Also rename some variable names to something more meaningful. Rename the
member m_l of FileBrowser to m_fileBrowserTreeWidget. Rename the
following local variables in the constructor of FileBrowser:
* ops -> searchWidget
* opl -> searchWidgetLayout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants