Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piano Roll: Show note labels on notes #4466

Closed
MrcSnm opened this issue Jul 6, 2018 · 7 comments
Closed

Piano Roll: Show note labels on notes #4466

MrcSnm opened this issue Jul 6, 2018 · 7 comments

Comments

@MrcSnm
Copy link

MrcSnm commented Jul 6, 2018

51234

This is basically what i want you to do, when you used too much fl studio you really miss this, it is quite boring needing to make a horizontal line with your eyes backing to you can know what note you're actually playing, for some reason just appear the root note, already searched for things like this in LMMS but never found it

@PhysSong
Copy link
Member

PhysSong commented Jul 6, 2018

For piano keys, you can turn on Enable note labels in piano roll in Edit->Settings. It's not implemented for notes, but I think it won't be hard.

@MrcSnm
Copy link
Author

MrcSnm commented Jul 6, 2018

So, the problem is that I find it pretty polluted
5123

Dunno if it is just for me, but it really is hard to be seeing things like this.

@lukas-w
Copy link
Member

lukas-w commented Jul 6, 2018

@MrcSnm Note labels on keys have already been implemented via #2285 and will be part of the 1.2 release:

image

Having note labels on each note is covered by #521. However, #521 lacks a screenshot illustrating the proposal so I'll close that one as a duplicate.

@lukas-w lukas-w changed the title [Piano Roll] [Request] Showing every note name in every piano key and every note played Piano Roll: Show note labels on notes Jul 6, 2018
michaelgregorius added a commit to michaelgregorius/lmms that referenced this issue Jul 7, 2018
Add the option to show note values on notes in the Piano Roll. This
functionality is currently coupled with the option "Enable note labels
in piano roll" which can be found in the main menu.

The notes are rendered at about 80% of the notes height. They are only
rendered if they fit on the whole note and if the font does not become
too tiny.

Enable the configuration of the note value text's color via the
stylesheets and set the value to white for both shipped themes.

Other changes:
* Clean up some warnings about old school casts and implicit casts.
@michaelgregorius
Copy link
Contributor

Implemented with #4467. Here's how it looks:

lmms-4466-notetext

@musikBear
Copy link

@michaelgregorius -lovely little added feature. Will benefit newcomers, and since it's toggable in Settings, no adverse things here - Nice ! 🎆

@jibin1573
Copy link

Great!! Thanks!

michaelgregorius added a commit that referenced this issue Jul 10, 2018
Add the option to show note values on notes in the Piano Roll. This
functionality is currently coupled with the option "Enable note labels
in piano roll" which can be found in the main menu.

The notes are rendered at about 80% of the notes height. They are only
rendered if they fit on the whole note and if the font does not become
too tiny.

Enable the configuration of the note value text's color via the
stylesheets and set the value to white for both shipped themes.

Other changes:
* Clean up some warnings about old school casts and implicit casts.
@michaelgregorius
Copy link
Contributor

Closing this issue as #4467 has just been merged into master.

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this issue Jun 28, 2022
Add the option to show note values on notes in the Piano Roll. This
functionality is currently coupled with the option "Enable note labels
in piano roll" which can be found in the main menu.

The notes are rendered at about 80% of the notes height. They are only
rendered if they fit on the whole note and if the font does not become
too tiny.

Enable the configuration of the note value text's color via the
stylesheets and set the value to white for both shipped themes.

Other changes:
* Clean up some warnings about old school casts and implicit casts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants