Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Bug zasfx-UI crashes lmms #892

Closed
musikBear opened this Issue · 17 comments

4 participants

@musikBear

win 32 1.0.91 219614
crash of lmms when 'show voice parameters' button in zasfx is pressed
http://snag.gy/WTxUy.jpg

and #703

@tresf
Owner

1.0.91 x64 (windows 8) crashes for me when the Show GUI button is clicked. Looks like ZASF has some bugs that need to be worked out prior to the release of 1.1. @diizy or @eagles051387 can you tag this bug for 1.1?

@tresf
Owner

So after some discussion about #916, I tried the installer via Wine.
Interesting enough... the Wine error messages are actually very useful: :angel:

@tobydox Did we change the way linking works with 1.1? This seems to be directly related to library linking:

err:module:import_dll Library QtSvg4.dll (which is needed by L"Z:\\opt\\mingw32\\lib\\qt4\\plugins\\iconengines\\qsvgicon4.dll") not found
err:module:import_dll Library QtSvg4.dll (which is needed by L"Z:\\opt\\mingw32\\lib\\qt4\\plugins\\iconengines\\qsvgicon4.dll") not found
fixme:win:FlashWindowEx 0x86f19c
QtXmlWrapper::loadXMLfile(): empty data 
err:module:import_dll Library libfltk.dll (which is needed by L"C:\\Program Files (x86)\\LMMS\\plugins\\RemoteZynAddSubFx.exe") not found
err:module:LdrInitializeThunk Main exe initialization for L"C:\\Program Files (x86)\\LMMS\\plugins\\RemoteZynAddSubFx.exe" failed, status c0000135
@tresf
Owner

Ok, so this just seems to be a packaging issue. A proposed fix to the two missing libraries is to add the following lines to CMakeLists.txt: Note FLTK is in lib, NOT bin.

IF(LMMS_BUILD_WIN32)
...
INSTALL(FILES
   ...
   "${MINGW_PREFIX}/bin/QtSvg4.dll"
   ...
   "${MINGW_PREFIX}/lib/libfltk.dll"
   ...

In addition:

   ...
    "${MINGW_PREFIX}/bin/libjpeg-9.dll"
   ...

It also complains about vstbase.dll but that might be a false positive or a 32/64 bit problem since I'm using Wine to troubleshoot missing libraries.

My instinct is that the old 1.0 and older customized version of Zyn did the FLTK part for us so it's probably better to be permanently addressed there if -- for instance -- Zyn is removed from the dependencies list on Win32 (unlikely but possible).

Off topic but the NSIS integration into cmake sure is slick. :alien: :)

Will make some 32-bit and 64-bit packages and then issue a pull request.

image

@diizy
Owner
@tresf tresf referenced this issue from a commit
@tresf tresf Fix win32 missing dlls
For bug #892 on `stable-1.1`
d3a1a2a
@tresf
Owner

Here are the updated installers which address the hard Zyn crash on Win32/Win64:

32-bit

https://drive.google.com/file/d/0B4PpvIwHd1U0UzNOdWd4QUNoNzg/edit?usp=sharing

64-bit

https://drive.google.com/file/d/0B4PpvIwHd1U0Q1BHOUthYkFLMlE/edit?usp=sharing

Note these do not include @diizy 's Zyn sync from pull request #916 so the Instrument Edit artifacts are still present in this build.

#919

@musikBear

unfortunale tresf' buil from 1. june does not fix this. The behavior has changed. Now there is one more error-message, but the crash happens at the same event
http://snag.gy/f4RlE.jpg
So in native xp 32 (not wine) This bug persists
Need confirmation from other xp'er!

@tresf
Owner

unfortunale tresf' buil from 1. june does not fix this

I assume you mean July 1st. I've confirmed this bug still exists in Windows XP.

It is probably safe to assume this will end up like #704 and be marked as wontfix due to being isolated to Windows XP (unless this is related to another open bug such as the slow load times or slider artifacts mentioned in #759).

image

I even tried forcing Wine to use Windows XP, Windows 2000 and Windows NT 4.0 to try to reproduce this in a more verbose environment to no avail (it works every time).

image

I would strongly suggest moving to a more modern OS. Contact me personally if you need "help" with this. :)

@tresf
Owner

Ok.. some good news...

I downloaded fftw-3.3.4-dll32.zip (March 16, 2014) and extracted:

  • libfftw3-3.dll
  • libfftw3f-3.dll

    to Program Files/LMMS and it fixes this specific issue on Windows XP (but not #704, sorry)

image

So @tobydox where do we get our fftw dlls? Should we update those? (or have they been updated I just need to grab the news ones?)

@diizy
Owner
@tresf
Owner

it's up to whoever does the windows build to use up-to-date sources

Currently they come from @tobydox 's custom repo at this stage (step 4 or 5) of the build process.

Interesting enough, Toby's version seems to reflect 3.3.4-1 as opposed to FFTW's version 3.3.4 so he's probably already on the latest.

In terms of patching this, the packaging person can certainly grab a custom version directly from FFTW or any 3rd party site, but it's probably best corrected in Toby's mirror since that's what we're all using.

IIRC I've seen previous Windows bugs get fixed by Toby simply by recompiling so I'm interested to hear if this is compiler related or code related.

Here are FFTW's build notes about the Windows Version:

We have created precompiled DLL files for FFTW 3.3.4 in single/double/long-double precision, along with the associated test programs. We hope that these are sufficient for most users, so that you need not worry about compiling FFTW:

These DLLs were created by us, cross-compiled from GNU/Linux using MinGW; the 64-bit version is possible thanks to the mingw-w64 project. You should be able to call them from any compiler. In order to link to them from Visual C++, you will need to create .lib "import libraries" using the lib.exe program included with VC++.

I wouldn't be surprised if Toby strips out the test programs to reduce file size as his DLLs are much smaller in size.

@diizy
Owner
@tresf
Owner

Here are the updated Windows installers which address the #892 "show voice parameters" Zyn crash on Windows XP as well as the #759 "visual artifacts" bugs.

I intentionally and prematurely bumped the version of these installers to 1.0.92 as to easily distinguish from the previous versions.

32-bit

https://drive.google.com/file/d/0B4PpvIwHd1U0dERvS2xpNUY1Nms/edit?usp=sharing

64-bit

https://drive.google.com/file/d/0B4PpvIwHd1U0Nk9GQ0hDcnZJSzg/edit?usp=sharing

@tobydox
Owner

We have all required libraries in my PPA. Advantage: they are all built using the same toolchain (GCC, binutils, mingw64 runtime, ...) and thus we reach the highest possible degree of binary compatibility and do not have external dependencies (like VisualStudio runtime DLLs etc.). Last but not least, everything is cleanly built from upstream source, thus no license issues (in terms of unfree components linked in like ASIO in PortAudio or similar) and definitely no virus/malware infections.

If you need updates for certain packages, just tell me.

@tresf
Owner

What are your thoughts on fftw? Why do you think XP doesn't crash with the DLLs from the project site? (They claim to use MINGW as well)

@tobydox
Owner

Looks like my build scripts (debian/rules) needed some tweaks. Can you please try installing

http://www-user.tu-chemnitz.de/~doto/lmms/mingw32-x-fftw_3.3.4-2_all.deb
http://www-user.tu-chemnitz.de/~doto/lmms/mingw64-x-fftw_3.3.4-2_all.deb

in your build environment (or extract the DLLs using "dpkg -x") and see whether they work? At least things are almost identical now to ftp://ftp.fftw.org/pub/fftw/BUILD-MINGW32.sh and ftp://ftp.fftw.org/pub/fftw/BUILD-MINGW64.sh

@tobydox
Owner

Should be fixed in latest FFTW package in my PPA - please upgrade.

@tobydox tobydox closed this
@tresf
Owner

Confirmed.

(Updated fftw packages, recompiled, tested on XP)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.