New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFXR: Avoid NaNs by making envelope length minimum 1 sample #1879

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@softrabbit
Member

softrabbit commented Mar 17, 2015

The values in the env_length array are used as divisors, so if they are allowed a range down to 0 the divisions will result in NaN, which propagates through env_vol all the way to ssample, which is the output. This change might remove some minimal amount of "snap" from the sound, but that would in many cases be the sound of some component not liking NaNs.

This should at least partly fix #1877. I'm not saying SFXR doesn't include other calculations that might lead to NaN.

@diizy

This comment has been minimized.

Show comment
Hide comment
@diizy

diizy Mar 19, 2015

Contributor

Since this is a bugfix for a bug that I assume also exists in 1.1, it might be a good idea to rebase this for the stable-1.1 branch?

Contributor

diizy commented Mar 19, 2015

Since this is a bugfix for a bug that I assume also exists in 1.1, it might be a good idea to rebase this for the stable-1.1 branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment