New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show native plugin info in the effect selection dialog #1985

Merged
merged 1 commit into from Apr 20, 2015

Conversation

Projects
None yet
4 participants
@michaelgregorius
Contributor

michaelgregorius commented Apr 19, 2015

The effect selection dialog now also shows the information for the native
plugins. This included name, description, author as well as the plugin
icon.

Also removed the group box with the title "Plugin description" because
it should be rather obvious to the user that further information about
the plugin is shown. This removes some clutter from the dialog.

Show native plugin info in the effect selection dialog
The effect selection dialog now also shows the information for the native
plugins. This included name, description, author as well as the plugin
icon.

Also removed the group box with the title "Plugin description" because
it should be rather obvious to the user that further information about
the plugin is shown. This removes some clutter from the dialog.
@michaelgregorius

This comment has been minimized.

Show comment
Hide comment
@michaelgregorius

michaelgregorius Apr 19, 2015

Contributor

With this patch the dialog now looks as follows on my system:
1985-screenshot

Contributor

michaelgregorius commented Apr 19, 2015

With this patch the dialog now looks as follows on my system:
1985-screenshot

@Wallacoloo

This comment has been minimized.

Show comment
Hide comment
@Wallacoloo

Wallacoloo Apr 19, 2015

Member

I like this idea. It's useful to have description/author info for native plugins. I just tested your change, and it works fine on my system (Ubuntu 14.10, x86_64).

As for the icons, literally all but four of my plugins have that same one shown in your screenshot. And the other four simply don't have icons. But note that I haven't installed any plugins not distributed with lmms.

Member

Wallacoloo commented Apr 19, 2015

I like this idea. It's useful to have description/author info for native plugins. I just tested your change, and it works fine on my system (Ubuntu 14.10, x86_64).

As for the icons, literally all but four of my plugins have that same one shown in your screenshot. And the other four simply don't have icons. But note that I haven't installed any plugins not distributed with lmms.

@michaelgregorius

This comment has been minimized.

Show comment
Hide comment
@michaelgregorius

michaelgregorius Apr 19, 2015

Contributor

Yes, unfortunately all plugins seem to have the same icon. Perhaps showing them in the dialog will motivate some artists to create individual icons for the effects to give them more character. 🎨 😃

Contributor

michaelgregorius commented Apr 19, 2015

Yes, unfortunately all plugins seem to have the same icon. Perhaps showing them in the dialog will motivate some artists to create individual icons for the effects to give them more character. 🎨 😃

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Apr 20, 2015

Member

Perhaps showing them in the dialog will motivate some artists to create individual icons for the effects to give them more character.

Agreed.

Member

tresf commented Apr 20, 2015

Perhaps showing them in the dialog will motivate some artists to create individual icons for the effects to give them more character.

Agreed.

@curlymorphic

This comment has been minimized.

Show comment
Hide comment
@curlymorphic

curlymorphic Apr 20, 2015

Contributor

I like this. A nice improvement. It would be nice if all these Icons were designed by the same person, so there is some consistency.

Contributor

curlymorphic commented Apr 20, 2015

I like this. A nice improvement. It would be nice if all these Icons were designed by the same person, so there is some consistency.

hbox->addWidget(textualInfoWidget);
QVBoxLayout * textWidgetLayout = new QVBoxLayout( textualInfoWidget);

This comment has been minimized.

@curlymorphic

curlymorphic Apr 20, 2015

Contributor

I much prefer the name textWidgetLayout to the old one l 👍

@curlymorphic

curlymorphic Apr 20, 2015

Contributor

I much prefer the name textWidgetLayout to the old one l 👍

This comment has been minimized.

@michaelgregorius

michaelgregorius Apr 20, 2015

Contributor

Thanks! I think in times of IDEs with autocompletion variable names like l should be made a thing of the past. :)

@michaelgregorius

michaelgregorius Apr 20, 2015

Contributor

Thanks! I think in times of IDEs with autocompletion variable names like l should be made a thing of the past. :)

@curlymorphic

This comment has been minimized.

Show comment
Hide comment
@curlymorphic

curlymorphic Apr 20, 2015

Contributor

I just tested this, and looked over the code, every thing looks good to me.

Contributor

curlymorphic commented Apr 20, 2015

I just tested this, and looked over the code, every thing looks good to me.

tresf added a commit that referenced this pull request Apr 20, 2015

Merge pull request #1985 from michaelgregorius/EffectSelectDialog
Show native plugin info in the effect selection dialog

@tresf tresf merged commit f869b35 into LMMS:master Apr 20, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@michaelgregorius michaelgregorius deleted the michaelgregorius:EffectSelectDialog branch Apr 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment