Show native plugin info in the effect selection dialog #1985

Merged
merged 1 commit into from Apr 20, 2015

Projects

None yet

4 participants

@michaelgregorius
Contributor

The effect selection dialog now also shows the information for the native
plugins. This included name, description, author as well as the plugin
icon.

Also removed the group box with the title "Plugin description" because
it should be rather obvious to the user that further information about
the plugin is shown. This removes some clutter from the dialog.

@michaelgregorius michaelgregorius Show native plugin info in the effect selection dialog
The effect selection dialog now also shows the information for the native
plugins. This included name, description, author as well as the plugin
icon.

Also removed the group box with the title "Plugin description" because
it should be rather obvious to the user that further information about
the plugin is shown. This removes some clutter from the dialog.
70b063b
@michaelgregorius
Contributor

With this patch the dialog now looks as follows on my system:
1985-screenshot

@Wallacoloo
Member

I like this idea. It's useful to have description/author info for native plugins. I just tested your change, and it works fine on my system (Ubuntu 14.10, x86_64).

As for the icons, literally all but four of my plugins have that same one shown in your screenshot. And the other four simply don't have icons. But note that I haven't installed any plugins not distributed with lmms.

@michaelgregorius
Contributor

Yes, unfortunately all plugins seem to have the same icon. Perhaps showing them in the dialog will motivate some artists to create individual icons for the effects to give them more character. 🎨 😃

@tresf
Member
tresf commented Apr 20, 2015

Perhaps showing them in the dialog will motivate some artists to create individual icons for the effects to give them more character.

Agreed.

@curlymorphic
Contributor

I like this. A nice improvement. It would be nice if all these Icons were designed by the same person, so there is some consistency.

@curlymorphic curlymorphic commented on the diff Apr 20, 2015
src/gui/EffectSelectDialog.cpp
+
+ if ( descriptor.logo )
+ {
+ QLabel *logoLabel = new QLabel( m_descriptionWidget );
+ logoLabel->setPixmap( descriptor.logo->pixmap() );
+ logoLabel->setSizePolicy(QSizePolicy::Minimum, QSizePolicy::Minimum);
+
+ hbox->addWidget( logoLabel );
+ hbox->setAlignment( logoLabel, Qt::AlignTop);
+ }
+
+ QWidget *textualInfoWidget = new QWidget( m_descriptionWidget );
+
+ hbox->addWidget(textualInfoWidget);
+
+ QVBoxLayout * textWidgetLayout = new QVBoxLayout( textualInfoWidget);
@curlymorphic
curlymorphic Apr 20, 2015 Contributor

I much prefer the name textWidgetLayout to the old one l 👍

@michaelgregorius
michaelgregorius Apr 20, 2015 Contributor

Thanks! I think in times of IDEs with autocompletion variable names like l should be made a thing of the past. :)

@curlymorphic
Contributor

I just tested this, and looked over the code, every thing looks good to me.

@tresf tresf merged commit f869b35 into LMMS:master Apr 20, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@michaelgregorius michaelgregorius deleted the michaelgregorius:EffectSelectDialog branch Apr 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment