Arpeggiator extended by zonkmachine · Pull Request #2130 · LMMS/lmms

zonkmachine · 2015-06-23T13:40:05Z

Se issue: #2080
Here are some of the new arpeggiator functions.

New functions:

Skip - Skips notes. Full on 1% of the notes are played.
Miss - Miss notes. Full on this is the same as having 'Random' setting in direction.

zonkmachine · 2015-06-25T00:57:33Z

I couldn't make the original 'Skip' function work as I intended it and I'm not sure it's my coding that's the problem this time. It could be some other bug that's being exposed here.
Anyway. I let the Skip function mute notes last in the arpeggiator function instead and that's a bit wasteful compared to the earlier method of actually skipping over notes but now it works.

zonkmachine · 2015-09-17T22:15:41Z

Toggle switch removed + Squashed.

tresf · 2015-09-17T22:31:56Z

👍

zonkmachine · 2016-02-24T22:53:05Z

@Fastigium
With the fix in #2603 this hack got one step closer to merge.
I rebased it to the latest master and reverted/commented out, a workaround to counter for the base notes hanging which got especially annoying at higher randomness. With #2603 this is fixed but not for the single streamed instruments. The workaround unfortunately leaves lb302 totally untouched by the effect. There is a muted lb302 track in the BBTrack of the demo.
~~arpextendeddemo.mmp.zip~~

Fastigium · 2016-02-25T09:08:50Z

@zonkmachine Woah there, I'm not sure I get everything you're saying/asking. Let me see...
You're talking about your new Skip function, right? I'm actually not sure why #2603 fixed the base notes hanging for certain instruments. Normally, the NotePlayHandle that was originally sent to an instrument with stacking/arpeggio enabled gets muted because it gets child NotePlayHandles. You can see this here. NotePlayHandle::isMasterNote() returns true if the NotePlayHandle has subnotes or has had them in the past.
So that means that if you skip the first arpeggio note, the original note (base note?) does not get muted that way. Perhaps it gets muted some other way for non-single-streamed instruments now? Weird stuff.

As for the muted lb302 track in the BBTrack, I can't seem to find it. The B&B Editor only shows a kick and a snare, and the lb302 track under the BBTrack is not muted. That one does leave the original NotePlayHandle hanging though, probably for the reason I outlined above. To prevent it, you could add a method setMasterNote() to NotePlayHandle that sets m_hadChildren to true. That'd allow you to mute the base note without actually instantiating a child note.

zonkmachine · 2016-09-07T07:41:26Z

@Fastigium Thank you so very much! I'm sorry for not replying earlier but I fell out of coding a bit. My post wasn't very clear and the demo project was ill labelled, but you managed to get what I was after.
Anyway, this was precisely what I needed to stomp out the hanging notes bug and by doing so finishing a coding project that's been following me for over two years.

To prevent it, you could add a method setMasterNote() to NotePlayHandle that sets m_hadChildren to true. That'd allow you to mute the base note without actually instantiating a child note.

Worked like a charm... together with setUsesBuffer( false );

@LMMS/developers The new arpeggiator functions for randomisation skip and miss are now ready for testing. ~~Also, a new range limiting function is under development.~~

zonkmachine · 2016-09-08T14:24:08Z

Since the 'hanging note bug' is fixed I'm now switching this back to 1.2

jasp00 · 2016-09-09T00:05:00Z

+		if( m_arpSkipModel.value() )
+		{
+
+			if( 101 * ( (float) rand() / (float) RAND_MAX ) < m_arpSkipModel.value() )


Why 101 * r / RM < skip instead of 100 * r / (RM + 1) < skip? 100% skip rate should skip always.

Yeah. I was trying to find a more interesting response from the knobs. I've reverted to the same algorithm for both functions. Keep it simple, etc...

100% skip rate should skip always.

You're right, and i promised full amnesia.

jasp00 · 2016-09-09T00:10:54Z

+		tr( "The skip function will make the arpeggiator pause one step "
+			"randomly. From it's start in full counter clockwise "
+			"position and no effect it will gradually progress to "
+			"more or less full amnesia at maximum setting.") );


more or less should not be necessary.

zonkmachine · 2016-09-09T02:27:37Z

@jasp00 I've complied with all of your suggestions. 🐶

jasp00 · 2016-09-10T02:00:20Z



+	m_arpSkipKnob->setLabel( tr( "SKIP" ) );
+	m_arpSkipKnob->setHintText( tr( "Skip rate:" ) + " ", " " + tr( "%" ) );


According to the general style, there is no space before %.

The description is trimmed, so there is no need for a space after tr( "Skip rate:" ).

Fixed! I have not clue as to what precisely I was thinking when laying out the text. The Gate knob already has the layout I needed?

zonkmachine · 2016-09-10T03:43:01Z

🎉

Thanks for meticulous scrutiny and merge!

* master: (213 commits) Update Pattern and AutomationPattern length (LMMS#3037) Refresh i18n strings Hint text update Drop notes with length zero (LMMS#3031) Background tweak Background Update Flanger Exclude .ts files from the Github linguist Redesign Multitap echo (LMMS#3008) Update i18n source strings Extended arpeggiator functions (LMMS#2130) Fix sample track playback in BB tracks (LMMS#3023) Sort plug-in embedded resources (LMMS#3014) Implement version major.minor.release-stage.build (LMMS#3011) Fix regressions on loading broken projects (LMMS#3013) Improved file input validation. (LMMS#2523) Fix sample track view in BB editor (LMMS#3002) Request change in model when dropping a track (LMMS#3000) Add LocklessAllocator and use it in LocklessList (LMMS#2998) Drop forceStep in AutomatableModel (LMMS#3010) ...

tresf force-pushed the master branch 2 times, most recently from 8c45c1f to 4da73f3 Compare September 15, 2015 18:32

Wallacoloo mentioned this pull request Sep 17, 2015

New arpeggiator functions #2080

Open

7 tasks

zonkmachine force-pushed the arpeggiator-extended-squashed branch from d158166 to fa77617 Compare September 17, 2015 22:03

tresf added the enhancement label Sep 18, 2015

tresf added this to the 1.2.0 milestone Sep 18, 2015

zonkmachine modified the milestones: 1.3.0, 1.2.0 Feb 16, 2016

zonkmachine mentioned this pull request Feb 23, 2016

Update two NotePlayHandle methods to ignore child NotePlayHandles #2603

Merged

zonkmachine force-pushed the arpeggiator-extended-squashed branch from 06deb0e to 85193bc Compare February 24, 2016 22:22

zonkmachine added the in progress label Feb 24, 2016

zonkmachine force-pushed the arpeggiator-extended-squashed branch from 85193bc to 527e33d Compare February 24, 2016 22:32

zonkmachine force-pushed the arpeggiator-extended-squashed branch from 527e33d to 7737b2b Compare September 7, 2016 02:00

zonkmachine mentioned this pull request Sep 7, 2016

Feat. req. ARP Sync timings #1836

Open

zonkmachine changed the title ~~[WIP] Arpeggiator extended~~ Arpeggiator extended Sep 7, 2016

zonkmachine force-pushed the arpeggiator-extended-squashed branch 2 times, most recently from abbb028 to 175dd42 Compare September 8, 2016 13:33

zonkmachine removed the in progress label Sep 8, 2016

zonkmachine modified the milestones: 1.2.0, 1.3.0 Sep 8, 2016

jasp00 reviewed Sep 9, 2016
View reviewed changes

zonkmachine force-pushed the arpeggiator-extended-squashed branch 2 times, most recently from 6277410 to e7a2dd2 Compare September 9, 2016 02:20

jasp00 reviewed Sep 10, 2016
View reviewed changes

Extended arpeggiator functions

b8b8a93

zonkmachine force-pushed the arpeggiator-extended-squashed branch from e7a2dd2 to b8b8a93 Compare September 10, 2016 02:39

jasp00 merged commit a4f5834 into LMMS:master Sep 10, 2016

zonkmachine deleted the arpeggiator-extended-squashed branch September 10, 2016 03:43

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022

Extended arpeggiator functions (LMMS#2130)

ecb5cc6



		m_arpSkipKnob->setLabel( tr( "SKIP" ) );
		m_arpSkipKnob->setHintText( tr( "Skip rate:" ) + " ", " " + tr( "%" ) );

Uh oh!

Conversation

zonkmachine commented Jun 23, 2015 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zonkmachine commented Jun 25, 2015

Uh oh!

zonkmachine commented Sep 17, 2015

Uh oh!

tresf commented Sep 17, 2015

Uh oh!

zonkmachine commented Feb 24, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fastigium commented Feb 25, 2016

Uh oh!

zonkmachine commented Sep 7, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zonkmachine commented Sep 8, 2016

Uh oh!

jasp00 Sep 9, 2016

Choose a reason for hiding this comment

Uh oh!

zonkmachine Sep 9, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasp00 Sep 9, 2016

Choose a reason for hiding this comment

Uh oh!

zonkmachine commented Sep 9, 2016

Uh oh!

jasp00 Sep 10, 2016

Choose a reason for hiding this comment

Uh oh!

jasp00 Sep 10, 2016

Choose a reason for hiding this comment

Uh oh!

zonkmachine Sep 10, 2016

Choose a reason for hiding this comment

Uh oh!

zonkmachine commented Sep 10, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zonkmachine commented Jun 23, 2015 •

edited

Loading

zonkmachine commented Feb 24, 2016 •

edited

Loading

zonkmachine commented Sep 7, 2016 •

edited

Loading

zonkmachine Sep 9, 2016 •

edited

Loading