Make it workable on OpenBSD

[devnexen]

• Additional LMMS_BUILD flag.
• Disallow on plugins -Wl,-no-undefined which triggers undefined references.
• Make sure X11 headers are found.

[tresf]

No objections here...

I couldn't get a compile to fire due to such and old gcc version (4.2, failed due to the -std=c++-0x). What technique did you use to get on a modern gcc version? Also, OpenBSD 5.8 or 5.9?

Command log for reference:

#////// DEPS //////
su -
export PKG_PATH=http://ftp5.usa.openbsd.org/pub/OpenBSD/$(uname -r)/packages/$(machine -a)/
 # ^-- rit mirror, closest to me; placed in /root/.profile

pkg_add git cmake qt5 fftw3-float libogg libvorbis libsndfile libsamplerate jack sdl \
 fluidsynth fltk gcc-4.9.3p0 g++-4.9.3p0
 # ^-- couldn't find stk, but easy enough to dl/compile if needed
exit # or CTRL+D leave root

#////// BUILD //////
git clone -b master https://github.com/lmms/lmms
cd lmms; mkdir build target; cd build;

# gcc 4.9
cmake .. -DCMAKE_INSTALL_PREFIX=../target/ \
 -DCMAKE_C_COMPILER=egcc \
 -DCMAKE_CXX_COMPILER=eg++ \
 -DWANT_QT5=True \
 -DCMAKE_PREFIX_PATH=/usr/local/lib/qt5/cmake
 # ^-- pkgconfig couldn't find qt5, hence prefix

# -- OR --

# clang
cmake .. -DCMAKE_INSTALL_PREFIX=../target/ \
 -DCMAKE_C_COMPILER=clang \
 -DCMAKE_CXX_COMPILER=clang++ \
 -DWANT_QT5=True \
 -DCMAKE_PREFIX_PATH=/usr/local/lib/qt5/cmake

[devnexen]

There is either clang or gcc 4.9 (in this case compilers are egcc and eg++) port/package.

[devnexen]

As from kind @tresf request, and he mentioned the base compiler is far too old to compile even c++0x code ; hence this is how to test properly on OpenBSD (tested with the current stable), here is a little update of his command log reference

• pkg_add git cmake qt5 fftw3-float libogg libvorbis libsndfile libsamplerate jack sdl fluidsynth fltk gcc-4.9.3p0 g++-4.9.3p0 (or the two last can be replaced by llvm which installs as well the clang frontends).
• cmake .. -DCMAKE_INSTALL_PREFIX=../target/ -DCMAKE_C_COMPILER=(egcc or clang) -DCMAKE_CXX_COMPILER=(eg++ or clang++) -DWANT_QT5=True -DCMAKE_PREFIX_PATH=/usr/local/lib/qt5/cmake

Hope it is useful.

[tresf]

@devnexen Much obliged. I'll try those this evening (western hemisphere) and post back. 👍

[tresf]

Not incorrect, but this can be simplified to ELSE(), ENDIF(), etc.

[devnexen]

Is it correct with older version of cmake ?

[tresf]

Is it correct with older version of cmake ?

Yes, this is a readability practice. e.g. if you have many nested IF()'s.

IF(FOO)
  MESSAGE("IN FOO")
  IF(BAR)
    MESSAGE("IN BAR")
  ENDIF(FOO)
ENDIF(BAR)

It's fine to leave, but we've been slowly cleaning them up in many places as we visit them as they start to loose their effectiveness when there are too many params.

IF(FOO OR BAR OR LOREM OR IPSUM OR DOLOR OR SIT OR AMET)
  MESSAGE("HELLO FOO BAR LOREM IPSUM DOLOR SIT AMET")
ENDIF(FOO OR BAR OR LOREM OR IPSUM OR DOLOR OR SIT OR AMET)

vs.

IF(FOO OR BAR OR LOREM OR IPSUM OR DOLOR OR SIT OR AMET)
  MESSAGE("HELLO FOO BAR LOREM IPSUM DOLOR SIT AMET")
ENDIF()

[devnexen]

fair point. updating.

[tresf]

No major issues with the PR. Nice work. I've left a few comments where we could do things slightly better. Feedback welcome.

Test results with GCC 4.9 pass. I've updated my snippet above to reflect your suggestions.

Next is clang... From your dragon avatar, I can only assume that's your compiler of choice? :)

[tresf]

Ok, so clang is a bit shotty at the moment... Without -stdlib=libc++:

/usr/local/include/X11/qt5/QtCore/qflags.h:43:10: fatal error: 'initializer_list' file not found
#include <initializer_list>

With -stdlib=libc++:

/usr/local/include/X11/qt5/QtCore/qcompilerdetection.h:890:11: fatal error: 'utility' file not found
# include <utility>
          ^
1 error generated.
*** Error 1 in . (plugins/flp_import/CMakeFiles/flpimport.dir/build.make:79 'plugins/flp_import/CMakeFiles/flpimport.dir/unrtf.cpp.o': cd /h...)
*** Error 2 in . (CMakeFiles/Makefile2:1189 'plugins/flp_import/CMakeFiles/flpimport.dir/all')
*** Error 2 in /home/openbsd/lmms-clang/build (Makefile:137 'all')

That's as far as I got. If you're ok leaving out support for clang for now, so are we. 👍

[devnexen]

Hi and thanks for the feedback.

I admit for clang I tested with OpenBSD current which is clang 3.8, I think with OpenBSD 5.8 it is 3.5 so we can leave it for the moment.
About the ifdef I think it is because INT32_MAX was already defined if I remember well on OpenBSD.

[tresf]

Formatting looks slightly off here.

[tresf]

@devnexen thanks again for this. If you could touch up the formatting and squash your commits e.g. git rebase -i HEAD~6; git push --force (where 6 is the number of commits in the PR -- there's 5 now, assuming you'll add one more) then we'll have this merged. 👍

[devnexen]

Ok thanks for your patience :)