New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 'Set Linear' not saving properly (#1642) #2742

Merged
merged 3 commits into from Aug 14, 2016

Conversation

Projects
None yet
4 participants
@serdnab
Contributor

serdnab commented Apr 28, 2016

I added setScaleType( Linear ) when the loading element doesn't have a child element (containing scale type or automation data) as this is the default save way for non automated linear knobs
fixes #1642

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje Apr 30, 2016

Member

@serdnab could you please rename the PR to something more descriptive like " Fix 'Set Linear' not saving properly"

It'd be also very good if you renamed your commit too (git commit --amend) and afterwards you'll need to force push (git push -f)

Member

Umcaruje commented Apr 30, 2016

@serdnab could you please rename the PR to something more descriptive like " Fix 'Set Linear' not saving properly"

It'd be also very good if you renamed your commit too (git commit --amend) and afterwards you'll need to force push (git push -f)

@serdnab serdnab changed the title from fix for #1642 to fix 'Set Linear' not saving properly (#1642) May 1, 2016

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje May 1, 2016

Member

Did a quick test, seems to fix #1642 for me. I'm not comfortable with merging this though, without any more extensive testing, because I'm not familiar with this part of the codebase at all.

Member

Umcaruje commented May 1, 2016

Did a quick test, seems to fix #1642 for me. I'm not comfortable with merging this though, without any more extensive testing, because I'm not familiar with this part of the codebase at all.

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje Jun 12, 2016

Member

@LMMS/developers could someone else review/test this PR out, so we could merge?

Member

Umcaruje commented Jun 12, 2016

@LMMS/developers could someone else review/test this PR out, so we could merge?

@jasp00

This comment has been minimized.

Show comment
Hide comment
@jasp00

jasp00 Jun 12, 2016

Member

Should not the backward compatibility code be in an upgrade method in src/core/DataFile.cpp?

Member

jasp00 commented Jun 12, 2016

Should not the backward compatibility code be in an upgrade method in src/core/DataFile.cpp?

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje Jul 5, 2016

Member

@serdnab could you please address the issue @jasp00 pointed out?

Member

Umcaruje commented Jul 5, 2016

@serdnab could you please address the issue @jasp00 pointed out?

@serdnab

This comment has been minimized.

Show comment
Hide comment
@serdnab

serdnab Jul 9, 2016

Contributor

Which is your opinion on opening old projects that their origin versions of lmms didn't have logarithmic knobs. Open it linear or as detected by isLogarithmic() in LadspaManager.cpp?

Contributor

serdnab commented Jul 9, 2016

Which is your opinion on opening old projects that their origin versions of lmms didn't have logarithmic knobs. Open it linear or as detected by isLogarithmic() in LadspaManager.cpp?

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Jul 9, 2016

Member

Which is your opinion on opening old projects that their origin versions of lmms didn't have logarithmic knobs. Open it linear or as detected by isLogarithmic() in LadspaManager.cpp?

Linear.

Member

tresf commented Jul 9, 2016

Which is your opinion on opening old projects that their origin versions of lmms didn't have logarithmic knobs. Open it linear or as detected by isLogarithmic() in LadspaManager.cpp?

Linear.

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Jul 9, 2016

Member

Also as @jasp00 points out, we want to always preserve the bug for older projects when possible. e.g. if it was incorrectly setting Logarithmic before when Linear was explicitly being clicked, write Logarithmic to the config and make them change it again to take effect. These things can really destroy projects if not upgraded properly.

Member

tresf commented Jul 9, 2016

Also as @jasp00 points out, we want to always preserve the bug for older projects when possible. e.g. if it was incorrectly setting Logarithmic before when Linear was explicitly being clicked, write Logarithmic to the config and make them change it again to take effect. These things can really destroy projects if not upgraded properly.

@serdnab

This comment has been minimized.

Show comment
Hide comment
@serdnab

serdnab Jul 21, 2016

Contributor

@Umcaruje

could you please address the issue @jasp00 pointed out?

done

Contributor

serdnab commented Jul 21, 2016

@Umcaruje

could you please address the issue @jasp00 pointed out?

done

@jasp00

This comment has been minimized.

Show comment
Hide comment
@jasp00

jasp00 Jul 21, 2016

Member

@serdnab: This branch has conflicts that must be resolved

Member

jasp00 commented Jul 21, 2016

@serdnab: This branch has conflicts that must be resolved

@serdnab

This comment has been minimized.

Show comment
Hide comment
@serdnab

serdnab Jul 22, 2016

Contributor

@jasp00

This branch has conflicts that must be resolved

solved

Contributor

serdnab commented Jul 22, 2016

@jasp00

This branch has conflicts that must be resolved

solved

Show outdated Hide outdated include/DataFile.h
Show outdated Hide outdated src/core/DataFile.cpp
@serdnab

This comment has been minimized.

Show comment
Hide comment
@serdnab

serdnab Jul 29, 2016

Contributor

@jasp00

addressed your requests

Contributor

serdnab commented Jul 29, 2016

@jasp00

addressed your requests

Show outdated Hide outdated src/core/DataFile.cpp
@serdnab

This comment has been minimized.

Show comment
Hide comment
@serdnab

serdnab Aug 10, 2016

Contributor

@jasp00

done
deleted the unnecessary variable

Contributor

serdnab commented Aug 10, 2016

@jasp00

done
deleted the unnecessary variable

void DataFile::upgrade_1_0_99()
{
jo_id_t last_assigned_id = 0;

This comment has been minimized.

@jasp00

jasp00 Aug 14, 2016

Member

Empty lines should not have any indentation, but coding conventions are not against this.

@jasp00

jasp00 Aug 14, 2016

Member

Empty lines should not have any indentation, but coding conventions are not against this.

@jasp00

This comment has been minimized.

Show comment
Hide comment
@jasp00

jasp00 Aug 14, 2016

Member

Current projects do not need a manual upgrade in this case.

Member

jasp00 commented Aug 14, 2016

Current projects do not need a manual upgrade in this case.

@jasp00 jasp00 merged commit 07021ed into LMMS:master Aug 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment