Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style for Qt5 about dialog #2781

Merged
merged 1 commit into from May 15, 2016
Merged

Fix style for Qt5 about dialog #2781

merged 1 commit into from May 15, 2016

Conversation

@tresf
Copy link
Member

@tresf tresf commented May 15, 2016

Feedback/merging from the themers is appreciated.

Qt5 doesn't theme the About dialog properly with the default theme, per #2611.

Before:
image

After:
image

Per #2611
@Umcaruje
Copy link
Member

@Umcaruje Umcaruje commented May 15, 2016

LGTM 👍

@liushuyu
Copy link
Member

@liushuyu liushuyu commented May 15, 2016

@Umcaruje
Copy link
Member

@Umcaruje Umcaruje commented May 15, 2016

This is also the last issue in #2611, so we can actually close it after merging this 🎉

@liushuyu
Copy link
Member

@liushuyu liushuyu commented May 15, 2016

@Umcaruje
Copy link
Member

@Umcaruje Umcaruje commented May 15, 2016

@liushuyu let me test it out.

@Umcaruje
Copy link
Member

@Umcaruje Umcaruje commented May 15, 2016

Tested, works, merging.

@Umcaruje Umcaruje merged commit 0613299 into LMMS:master May 15, 2016
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@tresf tresf mentioned this pull request May 15, 2016
16 of 16 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.