Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rename option in controller context menu #2804

Merged
merged 2 commits into from
Jul 5, 2016
Merged

Add Rename option in controller context menu #2804

merged 2 commits into from
Jul 5, 2016

Conversation

DeRobyJ
Copy link
Contributor

@DeRobyJ DeRobyJ commented May 30, 2016

This time I did it with branches, so I hope everything is fine!

(With this, I'm fixing #2744 )

@Umcaruje
Copy link
Member

Please convert all your indentation from spaces to tabs.

@DeRobyJ
Copy link
Contributor Author

DeRobyJ commented May 30, 2016

I can just update it in my branch and this pull request will be fixed for that automatically?

@Umcaruje
Copy link
Member

@DeRobyJ Yup, when you push to your branch it automatically gets updated in the PR.

@DeRobyJ
Copy link
Contributor Author

DeRobyJ commented May 30, 2016

Fixed it.
Problem was, Qt creator was set up to put spaces instead of tabs °-°

this, SLOT( deleteController() ) );
contextMenu->addAction( tr("Re&name this controller"), this, SLOT( renameController() ));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a typo? should it be &Rename this controller?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, the &r is used for Remove already

@Umcaruje
Copy link
Member

Umcaruje commented Jul 5, 2016

Tested this out, works good, looks like a valuable addition and the code lgtm. Merging.

@Umcaruje Umcaruje merged commit 0d8a3c7 into LMMS:master Jul 5, 2016
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
* add Rename option in controller context menu

* code conv. fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants