Add Rename option in controller context menu #2804

Merged
merged 2 commits into from Jul 5, 2016

Projects

None yet

2 participants

@DeRobyJ
Contributor
DeRobyJ commented May 30, 2016

This time I did it with branches, so I hope everything is fine!

(With this, I'm fixing #2744 )

@Umcaruje
Member

Please convert all your indentation from spaces to tabs.

@DeRobyJ
Contributor
DeRobyJ commented May 30, 2016 edited

I can just update it in my branch and this pull request will be fixed for that automatically?

@Umcaruje
Member

@DeRobyJ Yup, when you push to your branch it automatically gets updated in the PR.

@DeRobyJ
Contributor
DeRobyJ commented May 30, 2016

Fixed it.
Problem was, Qt creator was set up to put spaces instead of tabs °-°

@Umcaruje Umcaruje commented on the diff Jun 1, 2016
src/gui/widgets/ControllerView.cpp
this, SLOT( deleteController() ) );
+ contextMenu->addAction( tr("Re&name this controller"), this, SLOT( renameController() ));
@Umcaruje
Umcaruje Jun 1, 2016 Member

Is this a typo? should it be &Rename this controller?

@DeRobyJ
DeRobyJ Jun 1, 2016 Contributor

Nope, the &r is used for Remove already

@Umcaruje
Member
Umcaruje commented Jul 5, 2016

Tested this out, works good, looks like a valuable addition and the code lgtm. Merging.

@Umcaruje Umcaruje merged commit 0d8a3c7 into LMMS:master Jul 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment