New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rename option in controller context menu #2804

Merged
merged 2 commits into from Jul 5, 2016

Conversation

Projects
None yet
2 participants
@DeRobyJ
Contributor

DeRobyJ commented May 30, 2016

This time I did it with branches, so I hope everything is fine!

(With this, I'm fixing #2744 )

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje May 30, 2016

Member

Please convert all your indentation from spaces to tabs.

Member

Umcaruje commented May 30, 2016

Please convert all your indentation from spaces to tabs.

@DeRobyJ

This comment has been minimized.

Show comment
Hide comment
@DeRobyJ

DeRobyJ May 30, 2016

Contributor

I can just update it in my branch and this pull request will be fixed for that automatically?

Contributor

DeRobyJ commented May 30, 2016

I can just update it in my branch and this pull request will be fixed for that automatically?

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje May 30, 2016

Member

@DeRobyJ Yup, when you push to your branch it automatically gets updated in the PR.

Member

Umcaruje commented May 30, 2016

@DeRobyJ Yup, when you push to your branch it automatically gets updated in the PR.

@DeRobyJ

This comment has been minimized.

Show comment
Hide comment
@DeRobyJ

DeRobyJ May 30, 2016

Contributor

Fixed it.
Problem was, Qt creator was set up to put spaces instead of tabs °-°

Contributor

DeRobyJ commented May 30, 2016

Fixed it.
Problem was, Qt creator was set up to put spaces instead of tabs °-°

this, SLOT( deleteController() ) );
contextMenu->addAction( tr("Re&name this controller"), this, SLOT( renameController() ));

This comment has been minimized.

@Umcaruje

Umcaruje Jun 1, 2016

Member

Is this a typo? should it be &Rename this controller?

@Umcaruje

Umcaruje Jun 1, 2016

Member

Is this a typo? should it be &Rename this controller?

This comment has been minimized.

@DeRobyJ

DeRobyJ Jun 1, 2016

Contributor

Nope, the &r is used for Remove already

@DeRobyJ

DeRobyJ Jun 1, 2016

Contributor

Nope, the &r is used for Remove already

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje Jul 5, 2016

Member

Tested this out, works good, looks like a valuable addition and the code lgtm. Merging.

Member

Umcaruje commented Jul 5, 2016

Tested this out, works good, looks like a valuable addition and the code lgtm. Merging.

@Umcaruje Umcaruje merged commit 0d8a3c7 into LMMS:master Jul 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment