New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModernNoir Theme For The New Default #2806

Merged
merged 1 commit into from May 31, 2016

Conversation

Projects
None yet
7 participants
@RebeccaDeField
Contributor

RebeccaDeField commented May 31, 2016

In this pull request, I am proposing that we use the ModernNoir theme as the new default, and the previous theme as a classic option as many people have suggested.

Modern Noir As Default
shot-2016-05-30_00-36-20

Previous Design As Classic
shot-2016-05-29_21-27-40

Please note: this is my version of the Modern Noir theme. This version will be added to the LSP. If this were to be the new default, I am not at all opposed to anyone making changes that do not match the style of my original preview, as there will always be a version available on the LSP. I am also doing this so that I can upload a version for the older release.

A little history
This theme started here, where many people stated that they were interested in having this as an alternate theme option. Development for the theme continued on my fork here. @tresf posted this, opening up the discussion for this theme to become the default. We came to the consensus that many people wanted me to move the theme into a pull request, hence the PR that I am posting here.

I would like to thank everyone for their support, feedback and contributions! 馃槃

@liushuyu

This comment has been minimized.

Show comment
Hide comment
@liushuyu

liushuyu May 31, 2016

Member

@RebeccaDeField Looks like your first PR (in your life) is pretty professional 馃憤
If there is no objections, we will merge this ASAP (within several hours)

Thx

This fixes #2587

==> No immediate objections, will merge shortly.

Member

liushuyu commented May 31, 2016

@RebeccaDeField Looks like your first PR (in your life) is pretty professional 馃憤
If there is no objections, we will merge this ASAP (within several hours)

Thx

This fixes #2587

==> No immediate objections, will merge shortly.

@liushuyu liushuyu merged commit ce8e523 into LMMS:master May 31, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@liushuyu

This comment has been minimized.

Show comment
Hide comment
@liushuyu

liushuyu May 31, 2016

Member

@RebeccaDeField Thanks for you valiant contributions!

Member

liushuyu commented May 31, 2016

@RebeccaDeField Thanks for you valiant contributions!

@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB May 31, 2016

Contributor

@RebeccaDeField that's a very clean and good looking theme! Thanks for the hard work on it. Can you tell me which font you use for the LFO label?
bildschirmfoto von 2016-05-31 11-58-46

Contributor

BaraMGB commented May 31, 2016

@RebeccaDeField that's a very clean and good looking theme! Thanks for the hard work on it. Can you tell me which font you use for the LFO label?
bildschirmfoto von 2016-05-31 11-58-46

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje May 31, 2016

Member

@liushuyu I'm sorry, but this Pull Request was merged way too soon.

No immediate objections, will merge shortly.

You merged it in around an hour, I live in a different timezone and I was unable to object. I don't get the need to merge stuff quickly. The general rule is to always wait at least 24 hours so a PR can properly get tested.

There are many issues that need to be adressed here.

The theme has left some things very inconsistent in the overall look of the software.

For example, the LB302 instrument looks really bad now, because of lack of proper background on the waveform selectors:
screenshot from 2016-05-31 12 07 12

Same with Vibed:
screenshot from 2016-05-31 12 13 01

Since the scrollbars now have a different height/width, there are uninitalised areas in the plugins (I'll fix this in a PR probably):
screenshot from 2016-05-31 12 08 13
and the Piano roll/Automation editor scrollbars look weird, because they are too wide:
screenshot from 2016-05-31 12 13 39

The LFO controller is the only plugin that was redesigned, and that left the peak controller looking very inconsistent:
screenshot from 2016-05-31 12 11 26

There may be some other issues I overlooked, but the point is this PR should've had proper testing before merging. I know we are all excited about the new theme, as we all worked hard on it, but rushing at the end was not the way to go.

Member

Umcaruje commented May 31, 2016

@liushuyu I'm sorry, but this Pull Request was merged way too soon.

No immediate objections, will merge shortly.

You merged it in around an hour, I live in a different timezone and I was unable to object. I don't get the need to merge stuff quickly. The general rule is to always wait at least 24 hours so a PR can properly get tested.

There are many issues that need to be adressed here.

The theme has left some things very inconsistent in the overall look of the software.

For example, the LB302 instrument looks really bad now, because of lack of proper background on the waveform selectors:
screenshot from 2016-05-31 12 07 12

Same with Vibed:
screenshot from 2016-05-31 12 13 01

Since the scrollbars now have a different height/width, there are uninitalised areas in the plugins (I'll fix this in a PR probably):
screenshot from 2016-05-31 12 08 13
and the Piano roll/Automation editor scrollbars look weird, because they are too wide:
screenshot from 2016-05-31 12 13 39

The LFO controller is the only plugin that was redesigned, and that left the peak controller looking very inconsistent:
screenshot from 2016-05-31 12 11 26

There may be some other issues I overlooked, but the point is this PR should've had proper testing before merging. I know we are all excited about the new theme, as we all worked hard on it, but rushing at the end was not the way to go.

@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB May 31, 2016

Contributor

@Umcaruje if @RebeccaDeField has no time for, I would like adjust the peak controller design. In my opinion it should look similar to the LFO controller in appearance and (!) size. Actually I work on this, yet. I have to know the font. I think it is Spaceport2006. there could be a license issue. That we have to prove. If I'm right, fonts have to be under a free license for lmms, isn't it?

Regards

Contributor

BaraMGB commented May 31, 2016

@Umcaruje if @RebeccaDeField has no time for, I would like adjust the peak controller design. In my opinion it should look similar to the LFO controller in appearance and (!) size. Actually I work on this, yet. I have to know the font. I think it is Spaceport2006. there could be a license issue. That we have to prove. If I'm right, fonts have to be under a free license for lmms, isn't it?

Regards

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje May 31, 2016

Member

@BaraMGB I think it might be Orbitron
screenshot from 2016-05-31 12 58 02

Member

Umcaruje commented May 31, 2016

@BaraMGB I think it might be Orbitron
screenshot from 2016-05-31 12 58 02

@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB May 31, 2016

Contributor

馃憤 @Umcaruje

Contributor

BaraMGB commented May 31, 2016

馃憤 @Umcaruje

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf May 31, 2016

Member

Well, that happened quickly. I agree with @Umcaruje when a merge has so many affected files (in this case, 488), we need to be a bit more careful when we merge. That's OK though, we'll make due.

My biggest concern is that I thought we had agreed to not keep around the classic theme.

Well anyway, @Umcaruje approves all theme merges from here on out please.

Member

tresf commented May 31, 2016

Well, that happened quickly. I agree with @Umcaruje when a merge has so many affected files (in this case, 488), we need to be a bit more careful when we merge. That's OK though, we'll make due.

My biggest concern is that I thought we had agreed to not keep around the classic theme.

Well anyway, @Umcaruje approves all theme merges from here on out please.

@RebeccaDeField

This comment has been minimized.

Show comment
Hide comment
@RebeccaDeField

RebeccaDeField May 31, 2016

Contributor

I was also definitely surprised by how quickly this was merged, but I think we can still collaborate to test and update the theme where needed.

@tresf perhaps we should leave the classic option for now, so that we can make up for the fast merge? I think that usually people test PRs so leaving the other theme for now could give a bit of a buffer.

@BaraMGB Yes, Orbitron was the font I used. It is under the Open Font License.

I noticed that all of the plugins had a unique look and so I assumed that it was important to you guys that it stayed that way. With that in mind, I tried to design the knobs in a way that they would look transparent but still be visible in the other parts of the program. Now I see that people would like it to look more consistent.

@Umcaruje You mentioned here that there was a simpler way to re-theme all of the plugins. Maybe we could implement that on all of the plugins for more consistency?

On the subject of the scroll bars, I think we have two options. We can either restore them to the same size as the previous ones and update the radius to match, or we can update the size in the Automation editor and just create matching graphics for the plugins with the new size in mind. Either way works for me.

I can also give the waveform selectors a dark background to add more contrast.

Right now might be a good time to add my source files to the repository so that other people can use them if they want contribute to this. I tried to layout my files in a way that would be easy to use for that reason.

Contributor

RebeccaDeField commented May 31, 2016

I was also definitely surprised by how quickly this was merged, but I think we can still collaborate to test and update the theme where needed.

@tresf perhaps we should leave the classic option for now, so that we can make up for the fast merge? I think that usually people test PRs so leaving the other theme for now could give a bit of a buffer.

@BaraMGB Yes, Orbitron was the font I used. It is under the Open Font License.

I noticed that all of the plugins had a unique look and so I assumed that it was important to you guys that it stayed that way. With that in mind, I tried to design the knobs in a way that they would look transparent but still be visible in the other parts of the program. Now I see that people would like it to look more consistent.

@Umcaruje You mentioned here that there was a simpler way to re-theme all of the plugins. Maybe we could implement that on all of the plugins for more consistency?

On the subject of the scroll bars, I think we have two options. We can either restore them to the same size as the previous ones and update the radius to match, or we can update the size in the Automation editor and just create matching graphics for the plugins with the new size in mind. Either way works for me.

I can also give the waveform selectors a dark background to add more contrast.

Right now might be a good time to add my source files to the repository so that other people can use them if they want contribute to this. I tried to layout my files in a way that would be easy to use for that reason.

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje May 31, 2016

Member

@Umcaruje You mentioned here that there was a simpler way to re-theme all of the plugins. Maybe we could implement that on all of the plugins for more consistency?

No, that is just if you want to change up the plugins on a seperate theme. For the default we edit the artwork files directly, since that is easier. The method I mentioned may be used by a theme designer such as yourself to quickly test out the new look of the plugin you're working on, without recompiling.

On the subject of the scroll bars, I think we have two options. We can either restore them to the same size as the previous ones and update the radius to match, or we can update the size in the Automation editor and just create matching graphics for the plugins with the new size in mind. Either way works for me.

I'm already working on reducing the size, but I really think the handlebar would benefit from a 1px margin, since when applied to the plugin window it just looks too near the piano:
screenshot from 2016-05-31 20 26 06
I'll try to finish up the PR soon.

Right now might be a good time to add my source files to the repository so that other people can use them if they want contribute to this. I tried to layout my files in a way that would be easy to use for that reason.

You need to fork https://github.com/LMMS/artwork and just add files to the src dir, and make a PR just like you did here :)

I noticed that all of the plugins had a unique look and so I assumed that it was important to you guys that it stayed that way. With that in mind, I tried to design the knobs in a way that they would look transparent but still be visible in the other parts of the program. Now I see that people would like it to look more consistent, which I prefer myself.

Well I'd like for the instrument plugins to stay the same, but for the effect plugins I think we should have a consistent redesign.


P.S. @RebeccaDeField you might wanna consider joining our gitter chat (https://gitter.im/LMMS/lmms) to have another way of communication and to discuss the theme stuff.

Member

Umcaruje commented May 31, 2016

@Umcaruje You mentioned here that there was a simpler way to re-theme all of the plugins. Maybe we could implement that on all of the plugins for more consistency?

No, that is just if you want to change up the plugins on a seperate theme. For the default we edit the artwork files directly, since that is easier. The method I mentioned may be used by a theme designer such as yourself to quickly test out the new look of the plugin you're working on, without recompiling.

On the subject of the scroll bars, I think we have two options. We can either restore them to the same size as the previous ones and update the radius to match, or we can update the size in the Automation editor and just create matching graphics for the plugins with the new size in mind. Either way works for me.

I'm already working on reducing the size, but I really think the handlebar would benefit from a 1px margin, since when applied to the plugin window it just looks too near the piano:
screenshot from 2016-05-31 20 26 06
I'll try to finish up the PR soon.

Right now might be a good time to add my source files to the repository so that other people can use them if they want contribute to this. I tried to layout my files in a way that would be easy to use for that reason.

You need to fork https://github.com/LMMS/artwork and just add files to the src dir, and make a PR just like you did here :)

I noticed that all of the plugins had a unique look and so I assumed that it was important to you guys that it stayed that way. With that in mind, I tried to design the knobs in a way that they would look transparent but still be visible in the other parts of the program. Now I see that people would like it to look more consistent, which I prefer myself.

Well I'd like for the instrument plugins to stay the same, but for the effect plugins I think we should have a consistent redesign.


P.S. @RebeccaDeField you might wanna consider joining our gitter chat (https://gitter.im/LMMS/lmms) to have another way of communication and to discuss the theme stuff.

@RebeccaDeField

This comment has been minimized.

Show comment
Hide comment
@RebeccaDeField

RebeccaDeField Jun 1, 2016

Contributor

No, that is just if you want to change up the plugins on a separate theme.

Ah, looks like I didn't understand the comment perfectly, thanks for clearing that up.

You need to fork https://github.com/LMMS/artwork and just add files to the src dir, and make a PR just like you did here :)

Will do.

Well I'd like for the instrument plugins to stay the same, but for the effect plugins I think we should have a consistent redesign.

Okay, sounds good. I'll make a pull request with the updated waveform selectors. It looks like @BaraMGB is taking on the Peak Controller. Can someone make a list of the plugins that we want to redesign to match?

P.S. @RebeccaDeField you might wanna consider joining our gitter chat.

Thanks for the invite! I'll try to join in if I can, but I'm pretty busy right now so chat might not work for me as I'm only commenting when I can find time to spare here or there.

Contributor

RebeccaDeField commented Jun 1, 2016

No, that is just if you want to change up the plugins on a separate theme.

Ah, looks like I didn't understand the comment perfectly, thanks for clearing that up.

You need to fork https://github.com/LMMS/artwork and just add files to the src dir, and make a PR just like you did here :)

Will do.

Well I'd like for the instrument plugins to stay the same, but for the effect plugins I think we should have a consistent redesign.

Okay, sounds good. I'll make a pull request with the updated waveform selectors. It looks like @BaraMGB is taking on the Peak Controller. Can someone make a list of the plugins that we want to redesign to match?

P.S. @RebeccaDeField you might wanna consider joining our gitter chat.

Thanks for the invite! I'll try to join in if I can, but I'm pretty busy right now so chat might not work for me as I'm only commenting when I can find time to spare here or there.

@IvanMaldonado

This comment has been minimized.

Show comment
Hide comment
@IvanMaldonado

IvanMaldonado Jun 1, 2016

Contributor

Can someone make a list of the plugins that we want to redesign to match?

Basically, all of these.

plugins

And I personally think these should be redesigned as well, to match the modern look of Rebecca's work.

synths

EDIT: @Umcaruje merging this as quick as you said could not be that bad, this can help with this specific problem on the forums:

https://lmms.io/forum/viewtopic.php?f=7&p=18093&sid=7df324cb952b29777a8f50b202935269

I had experienced this before myself but since I create my own themes, I had no problem with it, yet the average user does not do this so they may have found this a bit annoying, just saying.

Contributor

IvanMaldonado commented Jun 1, 2016

Can someone make a list of the plugins that we want to redesign to match?

Basically, all of these.

plugins

And I personally think these should be redesigned as well, to match the modern look of Rebecca's work.

synths

EDIT: @Umcaruje merging this as quick as you said could not be that bad, this can help with this specific problem on the forums:

https://lmms.io/forum/viewtopic.php?f=7&p=18093&sid=7df324cb952b29777a8f50b202935269

I had experienced this before myself but since I create my own themes, I had no problem with it, yet the average user does not do this so they may have found this a bit annoying, just saying.

@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB Jun 1, 2016

Contributor

That are a lot of plugins for redesign. Perhaps we should specify something like a design convention.

Contributor

BaraMGB commented Jun 1, 2016

That are a lot of plugins for redesign. Perhaps we should specify something like a design convention.

@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB Jun 2, 2016

Contributor

@RebeccaDeField Can I please you to create a background image for the peak controller? The size is 240x100 and it should look like this:

peak_controller_artwork

I don't get the label looking like yours.

Contributor

BaraMGB commented Jun 2, 2016

@RebeccaDeField Can I please you to create a background image for the peak controller? The size is 240x100 and it should look like this:

peak_controller_artwork

I don't get the label looking like yours.

@mikobuntu

This comment has been minimized.

Show comment
Hide comment
@mikobuntu

mikobuntu Jun 2, 2016

Contributor

I agree and especially as I am the author of the Carla plug-in artwork, I did this in a hurry, but would be willing to update this to keep in tune with the new default theme.

On 1 Jun 2016 08:10, BaraMGB notifications@github.com wrote:That are a lot of plugins for redesign. Perhaps we should specify something like a design convention.

鈥擸ou are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

Contributor

mikobuntu commented Jun 2, 2016

I agree and especially as I am the author of the Carla plug-in artwork, I did this in a hurry, but would be willing to update this to keep in tune with the new default theme.

On 1 Jun 2016 08:10, BaraMGB notifications@github.com wrote:That are a lot of plugins for redesign. Perhaps we should specify something like a design convention.

鈥擸ou are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

@RebeccaDeField

This comment has been minimized.

Show comment
Hide comment
@RebeccaDeField

RebeccaDeField Jun 2, 2016

Contributor

Can I please you to create a background image for the peak controller?

Of course :) I think have an idea of why it's not matching. Will reply with more details and graphics later today.

Contributor

RebeccaDeField commented Jun 2, 2016

Can I please you to create a background image for the peak controller?

Of course :) I think have an idea of why it's not matching. Will reply with more details and graphics later today.

@RebeccaDeField

This comment has been minimized.

Show comment
Hide comment
@RebeccaDeField

RebeccaDeField Jun 5, 2016

Contributor

Looking at how many effects plugins that people want redesigned, I think that it would be a good idea to create a separate issue for the plugins where I can outline some good standard that people can follow to create plugins that match the rest of the theme and we can collaborate to get it done. What do you guys think?

@Umcaruje @BaraMGB @IvanMaldonado @mikobuntu

Contributor

RebeccaDeField commented Jun 5, 2016

Looking at how many effects plugins that people want redesigned, I think that it would be a good idea to create a separate issue for the plugins where I can outline some good standard that people can follow to create plugins that match the rest of the theme and we can collaborate to get it done. What do you guys think?

@Umcaruje @BaraMGB @IvanMaldonado @mikobuntu

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje Jun 7, 2016

Member

Looking at how many effects plugins that people want redesigned, I think that it would be a good idea to create a separate issue for the plugins where I can outline some good standard that people can follow to create plugins that match the rest of the theme and we can collaborate to get it done. What do you guys think?

Yes, please that'd be really nice and helpful

Member

Umcaruje commented Jun 7, 2016

Looking at how many effects plugins that people want redesigned, I think that it would be a good idea to create a separate issue for the plugins where I can outline some good standard that people can follow to create plugins that match the rest of the theme and we can collaborate to get it done. What do you guys think?

Yes, please that'd be really nice and helpful

@RebeccaDeField RebeccaDeField referenced this pull request Jun 9, 2016

Closed

Redesign The Effects Plugins #2831

14 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment