Change the minimum width of the B&B editor #2808

Merged
merged 1 commit into from Jul 5, 2016

Projects

None yet

4 participants

@Umcaruje
Member

Adresses #2636 (comment)

Before:
screenshot from 2016-06-01 00 43 06

After:
screenshot from 2016-06-01 00 41 38

@RebeccaDeField
Contributor

Perfect, thank you!

@IvanMaldonado
Contributor

What happens when you add more steps?

@tresf
Member
tresf commented Jun 1, 2016 edited

Changing the default width for better sane defaults/cosmetic reasons versus changing the minimum width are two separate things. As long as we allow shorter step counts, shouldn't we allow smaller window sizes?

Edit: Looking at the code suggest this may be somewhat based on step size already. If that's the case, great.

@RebeccaDeField
Contributor
RebeccaDeField commented Jun 1, 2016 edited

@tresf I see what you are saying. I thought that making a minimum size would help with having just one less variable that made the BBeditor pixelated, but if it causes usability issues, then just making it default to the right size, while still allowing people to scale the window down could be a great solution too.

@tresf
Member
tresf commented Jul 5, 2016

It's a benign change. We'll get more feedback when RC2 is release and it's easy enough to revert if people complain.

BTW, we're still dealing with magic numbers here... The value of 384 I assume is the width of the other components to the left such as the track label, etc. This WILL be problematic if anything changes size due to a theme, a higher resolution display, etc. The proper fix would be to eliminate the magic number completely.

@tresf tresf merged commit d84263e into LMMS:master Jul 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Umcaruje
Member
Umcaruje commented Jul 5, 2016

The value of 384 I assume is the width of the other components to the left such as the track label

No, actually those are some hard-coded variables that are taken to account. The 384 is actually the width of a default B&B pattern (16 step pixmaps + the various spacing between them).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment