Added LocklessList and use it for new play handles#2895
Conversation
|
Qt5 build fixed. |
| e->next = m_first; | ||
| #endif | ||
| } | ||
| while( !m_first.testAndSetOrdered( e->next, e ) ); |
There was a problem hiding this comment.
This looks like a busy-wait... is it likely to cause a performance problem, or can you use some kind of blocking thing here?
There was a problem hiding this comment.
Ah, upon reading a little bit about lockless lists, it seems that the while condition is much more likely to succeed than fail (because, of course, no lock is being held). So this should be fine. 👍
|
Hanging bug fixed with your patch but cpu usage is still high. the interesting part is that with or without your fix, a QThread makes system load average go up to 9!!! |
|
performance problem introduced in e55ec80. |
|
The high CPU usage is fixed in #2893. |
Added LocklessList and use it for new play handles
3 participants
This should fix #2886.