New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FLP import, revert to GPLv2+ only #2904

Merged
merged 1 commit into from Jul 12, 2016

Conversation

Projects
None yet
4 participants
@grejppi
Contributor

grejppi commented Jul 10, 2016

The fact that searching for flp gives only three results somehow tells me it won't be missed. @LMMS/developers, Y/n?

This should also close #2752 and resolve the GPLv3 issues once and for all.

May still contain traces in the translation files. @liushuyu, should they be edited on Transifex, your lmms-translations repository, or here?

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje Jul 10, 2016

Member

Yes from me, it didn't import properly anyways, and if it clashes with our license that's another reason to remove it.

Member

Umcaruje commented Jul 10, 2016

Yes from me, it didn't import properly anyways, and if it clashes with our license that's another reason to remove it.

@liushuyu

This comment has been minimized.

Show comment
Hide comment
@liushuyu

liushuyu Jul 11, 2016

Member

May still contain traces in the translation files.@liushuyu, should they be edited on Transifex, your lmms-translations repository, or here?

My lmms-translations repository is just a mirror of Transifex stash.
And if you don't want to refresh the translation file yourself, I will do the job. Just simply run lupdate -Iinclude/ src/ plugins/ -ts data/locale/en.ts on working copy of LMMS source directory.

And for the "traces" you have mentioned, Qt will mark these translations as deprecated by default instead of wiping them out, so do you want to just make them hidden or totally delete them?

Member

liushuyu commented Jul 11, 2016

May still contain traces in the translation files.@liushuyu, should they be edited on Transifex, your lmms-translations repository, or here?

My lmms-translations repository is just a mirror of Transifex stash.
And if you don't want to refresh the translation file yourself, I will do the job. Just simply run lupdate -Iinclude/ src/ plugins/ -ts data/locale/en.ts on working copy of LMMS source directory.

And for the "traces" you have mentioned, Qt will mark these translations as deprecated by default instead of wiping them out, so do you want to just make them hidden or totally delete them?

@DeRobyJ

This comment has been minimized.

Show comment
Hide comment
@DeRobyJ

DeRobyJ Jul 11, 2016

Contributor

I agree on this too: it's better to export the FLStudio project (or any other daw) to MIDI and import that in LMMS, so we should concentrate on MIDI rather than FLP files.

Contributor

DeRobyJ commented Jul 11, 2016

I agree on this too: it's better to export the FLStudio project (or any other daw) to MIDI and import that in LMMS, so we should concentrate on MIDI rather than FLP files.

@grejppi

This comment has been minimized.

Show comment
Hide comment
@grejppi

grejppi Jul 11, 2016

Contributor

Alright, this has got quite a few 👍s already, so I guess I'll merge this in 24 hours unless someone else does it first unless there are no objections.

Contributor

grejppi commented Jul 11, 2016

Alright, this has got quite a few 👍s already, so I guess I'll merge this in 24 hours unless someone else does it first unless there are no objections.

@grejppi grejppi merged commit 2d1813f into LMMS:master Jul 12, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment