New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename tracks directly on TrackLableButton in a QLineEdit #2916

Merged
merged 1 commit into from Jul 21, 2016

Conversation

Projects
None yet
5 participants
@BaraMGB
Contributor

BaraMGB commented Jul 14, 2016

renametrack

With this one we can edit the track name directly in the track. This avoids a dialog window.

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Jul 14, 2016

Member

👍 👍

Member

tresf commented Jul 14, 2016

👍 👍

@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB Jul 14, 2016

Contributor

I cleaned up the code a little bit.

Contributor

BaraMGB commented Jul 14, 2016

I cleaned up the code a little bit.

@jasp00

This comment has been minimized.

Show comment
Hide comment
@jasp00

jasp00 Jul 15, 2016

Member

I get these errors when using compact track buttons:

QWidget::setMinimumSize: (/QLineEdit) Negative sizes (-1,0) are not possible
QWidget::setMaximumSize: (/QLineEdit) Negative sizes (-1,16777215) are not possible
Member

jasp00 commented Jul 15, 2016

I get these errors when using compact track buttons:

QWidget::setMinimumSize: (/QLineEdit) Negative sizes (-1,0) are not possible
QWidget::setMaximumSize: (/QLineEdit) Negative sizes (-1,16777215) are not possible
@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB Jul 16, 2016

Contributor

@jasp00 Thank you for revisiting this PR. I have exclude the resize in case of compact track buttons now.

Contributor

BaraMGB commented Jul 16, 2016

@jasp00 Thank you for revisiting this PR. I have exclude the resize in case of compact track buttons now.

@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB Jul 20, 2016

Contributor

Why this->width() instead of width()?

Updated

Contributor

BaraMGB commented Jul 20, 2016

Why this->width() instead of width()?

Updated

@jasp00 jasp00 merged commit 7a98b3e into LMMS:master Jul 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje Jul 24, 2016

Member

@BaraMGB Should this also get reworked to use a disabled QLineEdit like #2918?

Member

Umcaruje commented Jul 24, 2016

@BaraMGB Should this also get reworked to use a disabled QLineEdit like #2918?

@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB Jul 24, 2016

Contributor

@Umcaruje no, the button is labeled with setText(). That's no QLabel or PaintEvent.

Contributor

BaraMGB commented Jul 24, 2016

@Umcaruje no, the button is labeled with setText(). That's no QLabel or PaintEvent.

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Jul 24, 2016

Member

^ right. The difference here is we have a button object already that we're working from, which would make the task much more difficult. In the case of the Mixer, it was just a label, making the consolidation a no-brainer.

One could argue to abolish the button altogether, but then the button-press behavior would have to be painted, we'd essentially find ourselves making a new button-like class and the underlying logic would look very much like what's been done already.

@Umcaruje I had thought of that too when I made the recommendation on the Mixer and then realized it's a button paint (or in this case a setText(...)) and not much we could do. 👍

Member

tresf commented Jul 24, 2016

^ right. The difference here is we have a button object already that we're working from, which would make the task much more difficult. In the case of the Mixer, it was just a label, making the consolidation a no-brainer.

One could argue to abolish the button altogether, but then the button-press behavior would have to be painted, we'd essentially find ourselves making a new button-like class and the underlying logic would look very much like what's been done already.

@Umcaruje I had thought of that too when I made the recommendation on the Mixer and then realized it's a button paint (or in this case a setText(...)) and not much we could do. 👍

@midi-pascal

This comment has been minimized.

Show comment
Hide comment
@midi-pascal

midi-pascal Jul 24, 2016

Contributor

Just to let you know: if a track or a fx is renamed Lmms does not consider the project as modified.
You can quit with no question about saving...

Contributor

midi-pascal commented Jul 24, 2016

Just to let you know: if a track or a fx is renamed Lmms does not consider the project as modified.
You can quit with no question about saving...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment