rename FxLine directly in a QLineEdit by BaraMGB · Pull Request #2918 · LMMS/lmms

BaraMGB · 2016-07-15T10:48:45Z

Same as #2916. For avoiding dialog window we can use a QLineEdit for renaming the FxLine. I used a QGraphicsView for rotating the QLineEdit.

Umcaruje · 2016-07-17T17:46:59Z

The beginning of the qlinedit is higher than the text's original position, which seems inconsistent to me. Other than that, looks good and avoids dialogs, so I'm all for that.

tresf · 2016-07-17T17:52:49Z

Can someone explain the purpose of using two components over one in this instance? For example, can't we simply keep the input a QLineEdit and change the behavior depending on whether or not we're in edit mode by setting readOnly to true?

Umcaruje · 2016-07-17T18:02:53Z

Can someone explain the purpose of using two components over one in this instance? For example, can't we simply keep the input a QLineEdit and change the behavior depending on whether or not we're in edit mode by setting readOnly to true?

Well, if one can make the disabled QLineEdit completely backgroundless and borderless, then that would be a better solution.

BaraMGB · 2016-07-22T08:26:52Z

Update: Now it uses for both (labeling and renaming) a QLineEdit.

Umcaruje · 2016-07-24T12:59:59Z

Tested, looks and works like a charm 👍

Umcaruje · 2016-07-24T13:03:50Z

src/gui/widgets/FxLine.cpp

+	m_scene->setSceneRect( 0, 0, 33, FxLineHeight );
+
+	m_view = new QGraphicsView( this );
+	m_view->setStyleSheet( "border-style: none; background: transparent;" );


Shouldn't you do this in the CSS?

I don't think so. The QGraphicsView is only a container for the QLineEdit. With it we can rotate the QLineEdit. I can't imagine a situation where the view should have borders or a background color. It's an internal solution the user (themer) don't need to know.

Ah, ok, thanks for clarifying 👍. This looks good to merge.

Just to let you know: if a track or a fx is renamed Lmms does not consider the project as modified.
You can quit with no question about saving...

BaraMGB · 2016-07-24T19:08:24Z

@jasp00 Thanks for your revisiting. I updated the branch.
@midi-pascal interesting. I have to figure out how to fix that. perhaps you file an issue for that.

zonkmachine · 2016-07-24T19:32:10Z

I have to figure out how to fix that. perhaps you file an issue for that.

I think you just add Engine::getSong()->setModified(); after your changes.

jasp00 · 2016-07-24T20:00:26Z

Undo and redo should work with renaming. A StringModel should be implemented.

BaraMGB · 2016-07-25T08:32:44Z

I think you just add Engine::getSong()->setModified(); after your changes.

@zonkmachine works!

Undo and redo should work with renaming. A StringModel should be implemented.

@jasp00 can you point me to some code where I can learn how to do this?

tresf · 2016-07-25T14:31:59Z

The model classes are generated dynamically, si they're a bit hard to find in the code, but search for IntModel for an example of an Integer version.

BaraMGB · 2016-07-26T09:43:05Z

I have updated. Now the project is set modified if the FxLine is renamed. But I fear I have no clue how to handle the undo/redo stuff. 😟

jasp00 · 2016-07-26T20:22:32Z

But I fear I have no clue how to handle the undo/redo stuff.

That can be done later.

Umcaruje · 2016-07-27T17:21:40Z

Tested this one out too, works like a charm. Here's a GIF:

jasp00 · 2016-07-28T01:44:54Z

src/gui/widgets/FxLine.cpp

+		setToolTip( m_newName );
 	}
+	m_renameLineEdit->setText( elideName( m_newName ) );
+	Engine::getSong()->setModified();


setModified() should be called only if text has changed.

BaraMGB · 2016-07-28T09:05:29Z

So, now it should works better.

jasp00 · 2016-08-01T23:00:56Z

include/FxLine.h

-
-	QStaticText m_staticTextName;
+	bool m_inRename;
+	QString m_newName;


It looks like this member is not needed. A local variable newName would be better.

jasp00 · 2016-08-01T23:15:52Z

src/gui/widgets/FxLine.cpp

+QString FxLine::elideName( QString name )
+{
+	const int maxTextHeight = 70;
+	QFontMetrics metrics( FxLine::font() );


Why FxLine::font() instead of font()?

BaraMGB · 2016-08-02T12:28:17Z

Update. @jasp00 thank you very much for your revisiting!

jasp00 · 2016-08-04T00:25:01Z

src/gui/widgets/FxLine.cpp

+	m_renameLineEdit = new QLineEdit();
+	m_renameLineEdit->setText( name );
+	m_renameLineEdit->setFixedWidth( 65 );
+	m_renameLineEdit->setFont( pointSizeF( FxLine::font(), 7.5f ) );


Just one ~~FxLine::~~font() more.

BaraMGB · 2016-08-04T14:32:45Z

👍

zonkmachine · 2016-08-04T15:38:12Z

Cool!

One comment. When you hover over the text ( shows horizontally ) the string is remembered.
If you now change the text and hover over it again it's the previous line that shows up.
Edit: Before you hit enter that is....

jasp00 · 2016-08-05T02:59:42Z

include/FxLine.h

 private:
-	void drawFxLine( QPainter* p, const FxLine *fxLine, const QString& name, bool isActive, bool sendToThis, bool receiveFromThis );
+	void drawFxLine( QPainter* p, const FxLine *fxLine, bool isActive, bool sendToThis, bool receiveFromThis );
+	QString elideName( QString name );


const QString & name should be used instead of QString name to avoid the copy of the QString.

BaraMGB · 2016-08-05T20:39:20Z

@jasp00 update. 👍
@zonkmachine I turned the tool tip off in rename mode now. Good catch!

* rename FxLine directly in a QLineEdit * set project modified only if FxLine text is changed * clean up some code. Optimize some things * optimizing code / removing a couple of member variables * minor code optimizations * turn off the tool tip in rename mode / minor code changes

BaraMGB force-pushed the FxLineRename branch from 498b87f to 6138820 Compare July 22, 2016 08:24

BaraMGB force-pushed the FxLineRename branch from 6138820 to 94cb3b7 Compare July 22, 2016 09:19

Umcaruje mentioned this pull request Jul 24, 2016

rename tracks directly on TrackLableButton in a QLineEdit #2916

Merged

Umcaruje reviewed Jul 24, 2016
View reviewed changes

BaraMGB force-pushed the FxLineRename branch from 94cb3b7 to 0b32941 Compare July 24, 2016 18:59

rename FxLine directly in a QLineEdit

e8c520a

BaraMGB force-pushed the FxLineRename branch from 0b32941 to e8c520a Compare July 26, 2016 08:24

jasp00 reviewed Jul 28, 2016
View reviewed changes

BaraMGB added 2 commits July 28, 2016 10:42

set project modified only if FxLine text is changed

e68122e

clean up some code. Optimize some things

0ec5b3f

jasp00 reviewed Aug 1, 2016
View reviewed changes

optimizing code / removing a couple of member variables

7112b8a

jasp00 reviewed Aug 4, 2016
View reviewed changes

minor code optimizations

aeb3d47

jasp00 reviewed Aug 5, 2016
View reviewed changes

turn off the tool tip in rename mode / minor code changes

6e26d8c

jasp00 merged commit a72ddf0 into LMMS:master Aug 7, 2016

Uh oh!

Conversation

BaraMGB commented Jul 15, 2016

Uh oh!

Umcaruje commented Jul 17, 2016

Uh oh!

tresf commented Jul 17, 2016

Uh oh!

Umcaruje commented Jul 17, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BaraMGB commented Jul 22, 2016

Uh oh!

Umcaruje commented Jul 24, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BaraMGB commented Jul 24, 2016

Uh oh!

zonkmachine commented Jul 24, 2016

Uh oh!

jasp00 commented Jul 24, 2016

Uh oh!

BaraMGB commented Jul 25, 2016

Uh oh!

tresf commented Jul 25, 2016

Uh oh!

BaraMGB commented Jul 26, 2016

Uh oh!

jasp00 commented Jul 26, 2016

Uh oh!

Umcaruje commented Jul 27, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BaraMGB commented Jul 28, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BaraMGB commented Aug 2, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BaraMGB commented Aug 4, 2016

Uh oh!

zonkmachine commented Aug 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BaraMGB commented Aug 5, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Umcaruje commented Jul 17, 2016 •

edited

Loading

zonkmachine commented Aug 4, 2016 •

edited

Loading