Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable minimization on all subwindows #2983

Merged
merged 7 commits into from Sep 27, 2016
Merged

Conversation

Umcaruje
Copy link
Member

@Umcaruje Umcaruje commented Aug 19, 2016

Fixes #2976
All subwindows now have a flag set to disable the minimize button. I have also removed its drawing code and pixmaps. EffectView was also modified to properly set the window flags. Screenshot:
screenshot from 2016-08-19 23 40 39

@RebeccaDeField
Copy link
Contributor

RebeccaDeField commented Sep 17, 2016

My 2 cents: If we do decide to git rid of the minimize button, it seems to me that the maximize icon could be changed. That specific kind of maximize icon is used with a minimize icon very frequently, whereas a "full screen" style icon is not always paired with a minimize icon.

@Umcaruje I actually think that you have already created an icon like what I am thinking for the title bars in the past. I found the link to it.
maximize

@Umcaruje
Copy link
Member Author

Umcaruje commented Sep 27, 2016

Here's how it looks with the new icon:
screenshot from 2016-09-27 19 03 22

This is rebased, conflicts removed and ready to be merged.

@liushuyu
Copy link
Member

liushuyu commented Sep 27, 2016

@BaraMGB
Copy link
Contributor

BaraMGB commented Sep 27, 2016

I'll test this out, tonight.

@Umcaruje
Copy link
Member Author

Umcaruje commented Sep 27, 2016

After some discussion over on Discord @RebeccaDeField modified the maximize icon so it fits better with the close icon:
screenshot from 2016-09-27 22 52 59

@BaraMGB
Copy link
Contributor

BaraMGB commented Sep 27, 2016

Okay, let's see what the people say.

@BaraMGB BaraMGB merged commit be5cc66 into LMMS:master Sep 27, 2016
@Umcaruje Umcaruje deleted the nominimizenomore branch Sep 28, 2016
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
* Disable minimization on all subwindows

* Change the maximize button icon

* Remove redundant boolean

* Make the maximize icon play better with the close icon

* I removed too much maaan

* Fix spaces

* Change comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants