New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable minimization on all subwindows #2983

Merged
merged 7 commits into from Sep 27, 2016

Conversation

Projects
4 participants
@Umcaruje
Member

Umcaruje commented Aug 19, 2016

Fixes #2976
All subwindows now have a flag set to disable the minimize button. I have also removed its drawing code and pixmaps. EffectView was also modified to properly set the window flags. Screenshot:
screenshot from 2016-08-19 23 40 39

@RebeccaDeField

This comment has been minimized.

Show comment
Hide comment
@RebeccaDeField

RebeccaDeField Sep 17, 2016

Contributor

My 2 cents: If we do decide to git rid of the minimize button, it seems to me that the maximize icon could be changed. That specific kind of maximize icon is used with a minimize icon very frequently, whereas a "full screen" style icon is not always paired with a minimize icon.

@Umcaruje I actually think that you have already created an icon like what I am thinking for the title bars in the past. I found the link to it.
maximize

Contributor

RebeccaDeField commented Sep 17, 2016

My 2 cents: If we do decide to git rid of the minimize button, it seems to me that the maximize icon could be changed. That specific kind of maximize icon is used with a minimize icon very frequently, whereas a "full screen" style icon is not always paired with a minimize icon.

@Umcaruje I actually think that you have already created an icon like what I am thinking for the title bars in the past. I found the link to it.
maximize

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje Sep 27, 2016

Member

Here's how it looks with the new icon:
screenshot from 2016-09-27 19 03 22

This is rebased, conflicts removed and ready to be merged.

Member

Umcaruje commented Sep 27, 2016

Here's how it looks with the new icon:
screenshot from 2016-09-27 19 03 22

This is rebased, conflicts removed and ready to be merged.

@liushuyu

This comment has been minimized.

Show comment
Hide comment
@liushuyu

liushuyu Sep 27, 2016

Member
Member

liushuyu commented Sep 27, 2016

@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB Sep 27, 2016

Contributor

I'll test this out, tonight.

Contributor

BaraMGB commented Sep 27, 2016

I'll test this out, tonight.

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje Sep 27, 2016

Member

After some discussion over on Discord @RebeccaDeField modified the maximize icon so it fits better with the close icon:
screenshot from 2016-09-27 22 52 59

Member

Umcaruje commented Sep 27, 2016

After some discussion over on Discord @RebeccaDeField modified the maximize icon so it fits better with the close icon:
screenshot from 2016-09-27 22 52 59

@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB Sep 27, 2016

Contributor

Okay, let's see what the people say.

Contributor

BaraMGB commented Sep 27, 2016

Okay, let's see what the people say.

@BaraMGB BaraMGB merged commit be5cc66 into LMMS:master Sep 27, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Umcaruje Umcaruje deleted the Umcaruje:nominimizenomore branch Sep 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment