Fader redesign#3056
Merged
Merged
Conversation
Umcaruje
force-pushed
the
faderredesign
branch
from
040ed60 to
2f567d6
Compare
Contributor
|
This looks great to me. I am planning on merging tomorrow if this does not receive any further comments with any changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gif has wonky colors, here's a screenshot:
Based on @RebeccaDeField's newest redesign of the faders. I made the faders more square and added seperate colors for the LED's. Red is everything >= 0 dB, so you always know when you're clipping. Yellow is everything >= -6dB. Persistent peaks now have the same colors as the fader LED's and I added the yellow color.
Comments and testing welcome, as always.