Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fader redesign #3056

Merged
merged 1 commit into from Sep 30, 2016
Merged

Fader redesign #3056

merged 1 commit into from Sep 30, 2016

Conversation

@Umcaruje
Copy link
Member

Umcaruje commented Sep 28, 2016

gifrecord_2016-09-28_165632

The gif has wonky colors, here's a screenshot:
screenshot from 2016-09-28 17 01 19

Based on @RebeccaDeField's newest redesign of the faders. I made the faders more square and added seperate colors for the LED's. Red is everything >= 0 dB, so you always know when you're clipping. Yellow is everything >= -6dB. Persistent peaks now have the same colors as the fader LED's and I added the yellow color.

Comments and testing welcome, as always.

@Umcaruje Umcaruje force-pushed the Umcaruje:faderredesign branch from 040ed60 to 2f567d6 Sep 29, 2016
@RebeccaDeField
Copy link
Contributor

RebeccaDeField commented Sep 30, 2016

This looks great to me. I am planning on merging tomorrow if this does not receive any further comments with any changes.

@RebeccaDeField RebeccaDeField merged commit d4fb937 into LMMS:master Sep 30, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.