dBV is actually mislabeled dBFS #3095

Merged
merged 3 commits into from Nov 7, 2016

Projects

None yet

3 participants

@Umcaruje
Member

So, after some looking around, I realised LMMS already used dBFS values but labeled them as dBV. according to wikipedia, dBV is a decibel that's relative to 1V of voltage, which does not quite fit in software.

dBFS on the other hand is relative to the maximum value of a digital full scale, which in our case is 1 in the linear scale, so the conclusion is that we are indeed actually using dBFS in LMMS.

Also @michaelgregorius also came to this conclusion in #2672 but probably never got around to this rename job.

@BaraMGB
Contributor
BaraMGB commented Oct 28, 2016

Agreed!

qa->setCheckable( true );
- qa->setChecked( ConfigManager::inst()->value( "app", "displaydbv" ).toInt() );
+ qa->setChecked( ConfigManager::inst()->value( "app", "displaydbfs" ).toInt() );
@tresf
tresf Oct 28, 2016 Member

Is this going to need an upgrade()?

@Umcaruje
Umcaruje Oct 29, 2016 Member

Do we even do upgrades for .lmmsrc.xml? If so, yes I can write an upgrade.

@tresf
tresf Oct 30, 2016 Member

Albeit rather recently, yes we do.

@Umcaruje
Umcaruje Oct 30, 2016 Member

Ok, I'll look into it.

@Umcaruje
Umcaruje Oct 31, 2016 edited Member

@tresf done per 5a7acd3

@tresf
Member
tresf commented Nov 1, 2016 edited

I don't know enough about dbfs to merge, but otherwise the PR is good to merge. I did notice some inconsistent whitespace formatting that this commit introduces. We should probably decide eventually which one of these is correct, but this PR isn't the place for that decision.

     if (foo) {
           // foo
+          whitepsace option 1
+whitespace option 2
           // bar
     }
@BaraMGB
Contributor
BaraMGB commented Nov 1, 2016

For what I've learned in Wikipedia dB FS is the unit used by all digital audio signals. For analog signals is dbv used (voltage).

@Umcaruje
Member
Umcaruje commented Nov 3, 2016

@tresf please comment on the code where you see that issue. This is a simple find/replace job, and I didn't touch the whitespace.

src/core/ConfigManager.cpp
@@ -144,14 +154,19 @@ void ConfigManager::upgrade()
{
return;
}
-
+
@tresf
tresf Nov 3, 2016 Member

whitespace

@Umcaruje
Umcaruje Nov 4, 2016 Member

Oh, ok, I accidentaly added whitespace there. I'll remove it.

@tresf tresf merged commit c961896 into LMMS:master Nov 7, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Umcaruje Umcaruje deleted the Umcaruje:dbvtodbfs branch Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment