Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTML markup for knob labels #3134

Merged
merged 10 commits into from Jan 28, 2021
Merged

Conversation

liushuyu
Copy link
Member

@liushuyu liushuyu commented Nov 27, 2016

Add HTML rich text support for knob label


This change is Reviewable

@jasp00
Copy link
Member

jasp00 commented Nov 27, 2016

This is another example of why #3071 should be solved. Most of this patch is about format changes.

Regarding the main purpose, what kind of HTML effects do you plan to use that cannot be done through the style sheet? Is this feature for knob labels only or will this be extended to all labels?

@liushuyu
Copy link
Member Author

This is another example of why #3071 should be solved. Most of this patch is about format changes.

Right... That's because I have integrated a code formatter in git commit hook. So each time I commit something, the changed files will be formatted.

Regarding the main purpose, what kind of HTML effects do you plan to use that cannot be done through the style sheet? Is this feature for knob labels only or will this be extended to all labels?

Well, that's relating to some chatter in our chat room: multi-line labels are not supported in knob labels, either <br> tag or \n didn't work at all.

@jasp00
Copy link
Member

jasp00 commented Jan 6, 2017

multi-line labels are not supported in knob labels

Have you tried using QLabel?

@liushuyu
Copy link
Member Author

liushuyu commented Jan 8, 2017

Have you tried using QLabel?

QLabel works though.

@tresf
Copy link
Member

tresf commented Nov 16, 2017

@liushuyu what is our decision on this? We can support HTML labels if it helps things, but I have to agree with @jasp00 about the unnecessary code formatting.

@Sawuare
Copy link
Member

Sawuare commented Nov 10, 2019

Bumping. ^

@PhysSong
Copy link
Member

I reverted some formatting changes and resolved conflicts. There are some things to change more, e.g., fix a memory from m_tdRenderer by either setting QObject ownership or using std::unique_ptr, replacing <font> with style attribute.

@LmmsBot
Copy link

LmmsBot commented Dec 22, 2020

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

Windows

macOS

🤖
{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://12201-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.72%2Bgfe48bfb-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12201?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://12204-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.72%2Bgfe48bfbef-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12204?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://12202-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.72%2Bgfe48bfbef-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12202?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/cioion0x98emrqgh/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/37389943"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/tl0c8a9f4tb3npef/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/37389943"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://12205-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.72%2Bgfe48bfbef-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12205?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "ca00ec812758f77e01dcad891d1928733c7980b6"}

src/gui/widgets/Knob.cpp Outdated Show resolved Hide resolved
src/gui/widgets/Knob.cpp Outdated Show resolved Hide resolved
src/gui/widgets/Knob.cpp Outdated Show resolved Hide resolved
src/gui/widgets/Knob.cpp Outdated Show resolved Hide resolved
src/gui/widgets/Knob.cpp Outdated Show resolved Hide resolved
@PhysSong
Copy link
Member

PhysSong commented Jan 4, 2021

It's now ready to review/merge.

src/gui/widgets/Knob.cpp Outdated Show resolved Hide resolved
src/gui/widgets/Knob.cpp Show resolved Hide resolved
Co-authored-by: Dominic Clark <mrdomclark@gmail.com>
@PhysSong PhysSong changed the title HTML text support for knob label Support HTML markup for knob labels Jan 28, 2021
@PhysSong PhysSong merged commit ed4df52 into LMMS:master Jan 28, 2021
IanCaio pushed a commit to IanCaio/lmms that referenced this pull request Mar 28, 2021
Co-authored-by: Hyunjin Song <tteu.ingog@gmail.com>
Co-authored-by: Dominic Clark <mrdomclark@gmail.com>
devnexen pushed a commit to devnexen/lmms that referenced this pull request Apr 10, 2021
Co-authored-by: Hyunjin Song <tteu.ingog@gmail.com>
Co-authored-by: Dominic Clark <mrdomclark@gmail.com>
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Co-authored-by: Hyunjin Song <tteu.ingog@gmail.com>
Co-authored-by: Dominic Clark <mrdomclark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants