Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File browser fixes: recursive filtering and removed duplicates. Fixed #3047 and #3180. #3184

Merged
merged 1 commit into from Jan 9, 2017

Conversation

@karmux
Copy link
Contributor

karmux commented Dec 27, 2016

Expanding directories wasn't completely recursive before and filtering couldn't detect correctly that subdirectories have children.

Fixed showing double intruments for Zyn by removing the following line that was added to enhance filtering recursively in 4206705:
addItems( path + cur_file + QDir::separator() );

@karmux karmux changed the title Fixed #3047 and #3180. File browser fixes: recursive filtering and removed duplicates. Fixed #3047 and #3180. Dec 29, 2016
Copy link
Member

Umcaruje left a comment

Tested this out, can confirm it fixes both of the issues. Will keep open for some time if anyone else has feedback, merging after that.

@Umcaruje Umcaruje merged commit 674a2fb into LMMS:master Jan 9, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
liushuyu added a commit to tonychee7000/lmms that referenced this pull request Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.