New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix eliding issue on fx mixer fader #3241

Merged
merged 1 commit into from Jan 24, 2017

Conversation

Projects
None yet
4 participants
@BaraMGB
Contributor

BaraMGB commented Jan 12, 2017

fixes #3237

Windows builds for testing can be found here: https://github.com/BaraMGB/lmms/releases/tag/v1.2rc2.8

@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB Jan 12, 2017

Contributor

@miketurn @musikBear can you test this?

Contributor

BaraMGB commented Jan 12, 2017

@miketurn @musikBear can you test this?

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Jan 23, 2017

Member

@miketurn @musikBear can you test this?

Bump.

@BaraMGB I don't see this on linux.

Member

zonkmachine commented Jan 23, 2017

@miketurn @musikBear can you test this?

Bump.

@BaraMGB I don't see this on linux.

@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB Jan 23, 2017

Contributor

@zonkmachine yes it depends on the used font. You can see it on Windows. In this PR the font metrics is calculated on the fader label font. Before that it's calculated on the widgets font and delivered wrong values.

Contributor

BaraMGB commented Jan 23, 2017

@zonkmachine yes it depends on the used font. You can see it on Windows. In this PR the font metrics is calculated on the fader label font. Before that it's calculated on the widgets font and delivered wrong values.

@musikBear

This comment has been minimized.

Show comment
Hide comment
@musikBear

musikBear Jan 23, 2017

@BaraMGB sorry, yes i will dl and test


Tested.
You done great!
both assigned instrumnts from song-editor and B&B-editor shows the whole name without truncation 👍

musikBear commented Jan 23, 2017

@BaraMGB sorry, yes i will dl and test


Tested.
You done great!
both assigned instrumnts from song-editor and B&B-editor shows the whole name without truncation 👍

@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB Jan 23, 2017

Contributor

Then this should be merged. Any objections here @zonkmachine?

Contributor

BaraMGB commented Jan 23, 2017

Then this should be merged. Any objections here @zonkmachine?

@BaraMGB BaraMGB merged commit a4c65b5 into LMMS:master Jan 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miketurn

This comment has been minimized.

Show comment
Hide comment
@miketurn

miketurn Jan 27, 2017

Contributor

@BaraMGB
Sorry I missed your request to test this
Thank You for fixing the issue
@musikBear
Thank You for testing this

Contributor

miketurn commented Jan 27, 2017

@BaraMGB
Sorry I missed your request to test this
Thank You for fixing the issue
@musikBear
Thank You for testing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment