SideBarButton set text below the icon#3256
Conversation
|
👍 great job :) |
|
Unrelated to this PR, but the side-tabs needs more contrast from each other. The description is indistinguishable from the two icons. @RebeccaDeField |
|
@tresf something like this design in my mockup could work? |
👍 |
I guess this one can easily made in the styles.css |
|
@BaraMGB Yes i was thinking the same. I could probably dig out my css book and have a look to see how to do this, well along with qtcreator :) , tho I hope the experts step in and do this i.e @RebeccaDeField et all :) |
|
in the styles.css line 497 changed to: Should I add this to this PR? |
|
@BaraMGB did adding the background conflict with the original PR, as i see the icon is now below the text in your last image? |
|
I changed the styles.css in master for be quick. ;) |
|
looks not bad. |
|
Better but still requires more contrast. The Instrument Buttons are about as close as we should allow (despite the similarities in color, they have additional bevel and shading which makes them standout from the background).
|
|
This is looking good, people :) I do agree with @tresf that if we are adding this to enhance the contrast, we might want to step up the contrast a bit more on that label. |
|
Here are some colors that should work well for the sidebar tab. Horizontal gradient: Should look something like this |
|
Thanks to @RebeccaDeField 👍
|
|
|
||
| SideBar QToolButton:checked { | ||
| background: none; | ||
| background: qlineargradient(spread:reflect, x1:0, y1:0, x2:0, y2:1, stop:0 #4b525b, stop:1 #2f333a); |
There was a problem hiding this comment.
@BaraMGB code style formatting... You've used spaces instead of a tab.
|
Just one minor code formatting change, then we can merge this. |
|
done ;) |
* SideBarButton set text below the icon * change color of checked sidebarbutton * adds a space to the sideBarButton title * add gradient to checked side bar button * whitespaces
4 participants
this would fix #3234 (comment)
