New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SideBarButton set text below the icon #3256

Merged
merged 5 commits into from Feb 6, 2017

Conversation

Projects
None yet
4 participants
@BaraMGB
Contributor

BaraMGB commented Jan 13, 2017

this would fix #3234 (comment)
2017-01-13-104015_1920x1080_scrot

@mikobuntu

This comment has been minimized.

Show comment
Hide comment
@mikobuntu

mikobuntu Jan 13, 2017

Contributor

👍 great job :)

Contributor

mikobuntu commented Jan 13, 2017

👍 great job :)

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Jan 13, 2017

Member

Unrelated to this PR, but the side-tabs needs more contrast from each other. The description is indistinguishable from the two icons. @RebeccaDeField

Member

tresf commented Jan 13, 2017

Unrelated to this PR, but the side-tabs needs more contrast from each other. The description is indistinguishable from the two icons. @RebeccaDeField

@mikobuntu

This comment has been minimized.

Show comment
Hide comment
@mikobuntu

mikobuntu Jan 13, 2017

Contributor

@tresf something like this design in my mockup could work?
sidebar

Contributor

mikobuntu commented Jan 13, 2017

@tresf something like this design in my mockup could work?
sidebar

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Jan 13, 2017

Member

@tresf something like this design in my mockup could work?

👍

Member

tresf commented Jan 13, 2017

@tresf something like this design in my mockup could work?

👍

@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB Jan 13, 2017

Contributor

something like this design in my mockup could work?

I guess this one can easily made in the styles.css

Contributor

BaraMGB commented Jan 13, 2017

something like this design in my mockup could work?

I guess this one can easily made in the styles.css

@mikobuntu

This comment has been minimized.

Show comment
Hide comment
@mikobuntu

mikobuntu Jan 13, 2017

Contributor

@BaraMGB Yes i was thinking the same. I could probably dig out my css book and have a look to see how to do this, well along with qtcreator :) , tho I hope the experts step in and do this i.e @RebeccaDeField et all :)

Contributor

mikobuntu commented Jan 13, 2017

@BaraMGB Yes i was thinking the same. I could probably dig out my css book and have a look to see how to do this, well along with qtcreator :) , tho I hope the experts step in and do this i.e @RebeccaDeField et all :)

@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB Jan 13, 2017

Contributor

in the styles.css line 497 changed to:
background: #2f353b;
looks like:
2017-01-13-201705_1280x800_scrot

Should I add this to this PR?

Contributor

BaraMGB commented Jan 13, 2017

in the styles.css line 497 changed to:
background: #2f353b;
looks like:
2017-01-13-201705_1280x800_scrot

Should I add this to this PR?

@mikobuntu

This comment has been minimized.

Show comment
Hide comment
@mikobuntu

mikobuntu Jan 13, 2017

Contributor

@BaraMGB did adding the background conflict with the original PR, as i see the icon is now below the text in your last image?

Contributor

mikobuntu commented Jan 13, 2017

@BaraMGB did adding the background conflict with the original PR, as i see the icon is now below the text in your last image?

@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB Jan 13, 2017

Contributor

I changed the styles.css in master for be quick. ;)

Contributor

BaraMGB commented Jan 13, 2017

I changed the styles.css in master for be quick. ;)

@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB Jan 13, 2017

Contributor

2017-01-13-214328_1280x800_scrot

looks not bad.

Contributor

BaraMGB commented Jan 13, 2017

2017-01-13-214328_1280x800_scrot

looks not bad.

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Jan 13, 2017

Member

Better but still requires more contrast. The Instrument Buttons are about as close as we should allow (despite the similarities in color, they have additional bevel and shading which makes them standout from the background).

image

Member

tresf commented Jan 13, 2017

Better but still requires more contrast. The Instrument Buttons are about as close as we should allow (despite the similarities in color, they have additional bevel and shading which makes them standout from the background).

image

@RebeccaDeField

This comment has been minimized.

Show comment
Hide comment
@RebeccaDeField

RebeccaDeField Jan 13, 2017

Contributor

This is looking good, people :) I do agree with @tresf that if we are adding this to enhance the contrast, we might want to step up the contrast a bit more on that label.

Contributor

RebeccaDeField commented Jan 13, 2017

This is looking good, people :) I do agree with @tresf that if we are adding this to enhance the contrast, we might want to step up the contrast a bit more on that label.

@RebeccaDeField

This comment has been minimized.

Show comment
Hide comment
@RebeccaDeField

RebeccaDeField Jan 21, 2017

Contributor

Here are some colors that should work well for the sidebar tab.

Horizontal gradient:
Stop 1: #4b525b
Stop 2: #2f333a

Should look something like this
1

@BaraMGB

Contributor

RebeccaDeField commented Jan 21, 2017

Here are some colors that should work well for the sidebar tab.

Horizontal gradient:
Stop 1: #4b525b
Stop 2: #2f333a

Should look something like this
1

@BaraMGB

@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB Jan 23, 2017

Contributor

Thanks to @RebeccaDeField 👍

2017-01-23-131900_1920x1080_scrot

Contributor

BaraMGB commented Jan 23, 2017

Thanks to @RebeccaDeField 👍

2017-01-23-131900_1920x1080_scrot

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Feb 5, 2017

Member

Just one minor code formatting change, then we can merge this.

Member

tresf commented Feb 5, 2017

Just one minor code formatting change, then we can merge this.

@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB Feb 6, 2017

Contributor

done ;)

Contributor

BaraMGB commented Feb 6, 2017

done ;)

@tresf tresf merged commit 3070cec into LMMS:master Feb 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment