Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAvoid crash on gui when rendering from command line and no write access #3322
Conversation
|
The other option is to fix it in AudioFileDevice.cpp |
|
Pushed method two on a separate commit for comparison. I vote no. 2 |
src/core/audio/AudioFileDevice.cpp
Outdated
| ExportProjectDialog::tr( "Could not open file %1 " | ||
| QString title, message; | ||
| title = ExportProjectDialog::tr( "Could not open file" ); | ||
| message = ExportProjectDialog::tr( "Could not open file %1 " | ||
| "for writing.\nPlease make " | ||
| "sure you have write-" | ||
| "permission to the file and " |
This comment has been minimized.
This comment has been minimized.
zonkmachine
force-pushed the
zonkmachine:renderdirpermission
branch
from
e31c562
to
f9cb176
|
Settled for no.2 . Done... |
src/core/audio/AudioFileDevice.cpp
Outdated
| } | ||
| else | ||
| { | ||
| printf( "%s\n", message.toUtf8().constData() ); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
zonkmachine
force-pushed the
zonkmachine:renderdirpermission
branch
from
f9cb176
to
21b52aa
|
Code looks fine. |
|
Thanks! Merge... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
zonkmachine commentedFeb 4, 2017
Fixes #2902
Something like this?