Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid crash on gui when rendering from command line and no write access #3322

Merged
merged 1 commit into from Feb 4, 2017

Conversation

@zonkmachine
Copy link
Member

zonkmachine commented Feb 4, 2017

Fixes #2902

Something like this?

@zonkmachine
Copy link
Member Author

zonkmachine commented Feb 4, 2017

The other option is to fix it in AudioFileDevice.cpp
Add "GuiApplication.h" as suggested in #2902 printf something and EXIT_FAILURE when no gui. Both works just fine.

@zonkmachine
Copy link
Member Author

zonkmachine commented Feb 4, 2017

Pushed method two on a separate commit for comparison. I vote no. 2

ExportProjectDialog::tr( "Could not open file %1 "
QString title, message;
title = ExportProjectDialog::tr( "Could not open file" );
message = ExportProjectDialog::tr( "Could not open file %1 "
"for writing.\nPlease make "
"sure you have write-"
"permission to the file and "

This comment has been minimized.

Copy link
@zonkmachine

zonkmachine Feb 4, 2017

Author Member

write-permission?

-> write permission

@zonkmachine zonkmachine force-pushed the zonkmachine:renderdirpermission branch from e31c562 to f9cb176 Feb 4, 2017
@zonkmachine
Copy link
Member Author

zonkmachine commented Feb 4, 2017

Settled for no.2 . Done... 🚂

@tresf
tresf approved these changes Feb 4, 2017
}
else
{
printf( "%s\n", message.toUtf8().constData() );

This comment has been minimized.

Copy link
@jasp00

jasp00 Feb 4, 2017

Member

fprintf( stderr, "%s\n",

This comment has been minimized.

Copy link
@zonkmachine

zonkmachine Feb 4, 2017

Author Member

Fixed!

@zonkmachine zonkmachine force-pushed the zonkmachine:renderdirpermission branch from f9cb176 to 21b52aa Feb 4, 2017
Copy link
Member

jasp00 left a comment

Code looks fine.

@zonkmachine
Copy link
Member Author

zonkmachine commented Feb 4, 2017

Thanks! Merge...

@zonkmachine zonkmachine merged commit e40a6bc into LMMS:master Feb 4, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zonkmachine zonkmachine deleted the zonkmachine:renderdirpermission branch Feb 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.