Skip to content

set new initial width of piano roll editor#3334

Merged
tresf merged 1 commit into
LMMS:masterfrom
BaraMGB:pianorollstartsize
Feb 8, 2017
Merged

set new initial width of piano roll editor#3334
tresf merged 1 commit into
LMMS:masterfrom
BaraMGB:pianorollstartsize

Conversation

@BaraMGB

@BaraMGB BaraMGB commented Feb 7, 2017

Copy link
Copy Markdown
Contributor

fixes #3299

set the size equal to automation editor window.

@tresf

tresf commented Feb 7, 2017

Copy link
Copy Markdown
Member

The toolbar method seemed a bit more dynamic. Is there a reason why this began failing (collapsible toolbar perhaps?)

@mikobuntu

Copy link
Copy Markdown
Contributor

@tres I'm presuming the collapsible toolbar method will still work after this PR gets implemented as it seems to only initialize a set width on opening ? , If so I think at least the user will still get these option if they decide to shrink the Piano_Roll window.
I just find that I have to stretch out the window every single time I use LMMS which can be annoying ( less clicks/dragging window size means more music being created ) .

@BaraMGB

BaraMGB commented Feb 8, 2017

Copy link
Copy Markdown
Contributor Author

The toolbar method seemed a bit more dynamic. Is there a reason why this began failing (collapsible toolbar perhaps?)

@tresf yes, I guess thats the reason. The toolbar is broken into parts. I don't quite get it. Seems it uses the standard Qt Toolbar. But I don't see how to get a sizehint() from it.

@tresf

tresf commented Feb 8, 2017

Copy link
Copy Markdown
Member

@mikobuntu I think you misread my concern. My concern is why this calculated value became hard-coded, not so much about the toolbar behavior.

@BaraMGB my concern here is that as we start to write more code around high DPI displays, we need to move away from magic width and height parameters.

Since this fix is a hard requirement of 1.2, I'll merge as-is, but we need to move away from magic numbers as a project goal.

@tresf tresf merged commit ea88c90 into LMMS:master Feb 8, 2017
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants