New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash on export per command line with sample track #3341

Merged
merged 1 commit into from Feb 11, 2017

Conversation

Projects
None yet
2 participants
@BaraMGB
Contributor

BaraMGB commented Feb 10, 2017

this should fix #3338

@zonkmachine can you look at this?

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Feb 10, 2017

Member

Now the file loads and exports fine but never hands back to main() . The Render Manger is stuck reporting 100% .

Member

zonkmachine commented Feb 10, 2017

Now the file loads and exports fine but never hands back to main() . The Render Manger is stuck reporting 100% .

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Feb 10, 2017

Member

Sometimes it renders just fine. I think I've seen this before. Just once in a while a render will fail to complete. It may be that you've poked another bug a bit. I'll continue testing this to see if I can find a pattern in it.

Member

zonkmachine commented Feb 10, 2017

Sometimes it renders just fine. I think I've seen this before. Just once in a while a render will fail to complete. It may be that you've poked another bug a bit. I'll continue testing this to see if I can find a pattern in it.

@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB Feb 10, 2017

Contributor

Does it depends on the project?

Contributor

BaraMGB commented Feb 10, 2017

Does it depends on the project?

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Feb 11, 2017

Member

Does it depends on the project?

It seem to depend on the length of the samples. I'm testing this with noise samples of various length and with a 15 second sample in the project there is about 50% chance of the renderer getting stuck after export.

Member

zonkmachine commented Feb 11, 2017

Does it depends on the project?

It seem to depend on the length of the samples. I'm testing this with noise samples of various length and with a 15 second sample in the project there is about 50% chance of the renderer getting stuck after export.

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Feb 11, 2017

Member

Sorry. I went back 50 commits and this bug is there also. It's hard to see a real pattern in it though other than the sample track being involved. This commit fixes the issue reported and should be merged. I can probe into the hanging renderer a bit more and write a new issue for it.

Member

zonkmachine commented Feb 11, 2017

Sorry. I went back 50 commits and this bug is there also. It's hard to see a real pattern in it though other than the sample track being involved. This commit fixes the issue reported and should be merged. I can probe into the hanging renderer a bit more and write a new issue for it.

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Feb 11, 2017

Member

The hanging render on longer Sample Tracks is an SDL thing.
I'm not done bisecting this but it may have happened around these commits 8497d39 e55ec80

Member

zonkmachine commented Feb 11, 2017

The hanging render on longer Sample Tracks is an SDL thing.
I'm not done bisecting this but it may have happened around these commits 8497d39 e55ec80

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Feb 11, 2017

Member

New issue opened for the SDL issues here: #3344
I suggest you merge this.

Member

zonkmachine commented Feb 11, 2017

New issue opened for the SDL issues here: #3344
I suggest you merge this.

@BaraMGB BaraMGB merged commit f937357 into LMMS:master Feb 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB Feb 11, 2017

Contributor

Okay. Thanks for the investigation

Contributor

BaraMGB commented Feb 11, 2017

Okay. Thanks for the investigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment