Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-document menu icons on macOS / OS X #3363

Merged
merged 3 commits into from Feb 17, 2017

Conversation

follower
Copy link
Contributor

See: #3349

Displaying menu icons on macOS/OS X does not fit the standard OS
guidelines unless they represent documents. See LMMS#3349.

Note: Requires a follow up Qt bug workaround to show icons in some
submenus.
@@ -893,6 +893,10 @@ void MainWindow::updateRecentlyOpenedProjectsMenu()
{
m_recentlyOpenedProjectsMenu->addAction(
embed::getIconPixmap( "project_file" ), *it );
#ifdef LMMS_BUILD_APPLE
m_recentlyOpenedProjectsMenu->actions().last()->setIconVisibleInMenu(false); // Workaround for https://bugreports.qt.io/browse/QTBUG-44565
Copy link
Member

@tresf tresf Feb 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this would be cleaner

m_recentlyOpenedProjectsMenu->actions().last()->setIconVisibleInMenu(false); // Per QTBUG-44565
m_recentlyOpenedProjectsMenu->actions().last()->setIconVisibleInMenu(true);

Alternately, you could put the comment on it's own line, which has the downside of taking it slightly out of context.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did wonder about URL vs bug number but went with the full URL since that's what we used in #3350.

I'd tend toward still indicating it's a workaround, so would prefer to go with:

m_recentlyOpenedProjectsMenu->actions().last()->setIconVisibleInMenu(false);  // QTBUG-44565 workaround

@tresf tresf merged commit b25655f into LMMS:master Feb 17, 2017
@follower
Copy link
Contributor Author

Thanks for helping getting this in merge-able state and merging it! :)

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Remove icons from non-document menus on macOS

Matches Apple user interface guidelines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants