Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-document menu icons on macOS / OS X #3363

Merged
merged 3 commits into from Feb 17, 2017

Conversation

@follower
Copy link
Contributor

@follower follower commented Feb 16, 2017

See: #3349

follower added 2 commits Feb 16, 2017
Displaying menu icons on macOS/OS X does not fit the standard OS
guidelines unless they represent documents. See #3349.

Note: Requires a follow up Qt bug workaround to show icons in some
submenus.
@@ -893,6 +893,10 @@ void MainWindow::updateRecentlyOpenedProjectsMenu()
{
m_recentlyOpenedProjectsMenu->addAction(
embed::getIconPixmap( "project_file" ), *it );
#ifdef LMMS_BUILD_APPLE
m_recentlyOpenedProjectsMenu->actions().last()->setIconVisibleInMenu(false); // Workaround for https://bugreports.qt.io/browse/QTBUG-44565

This comment has been minimized.

@tresf

tresf Feb 16, 2017
Member

I feel this would be cleaner

m_recentlyOpenedProjectsMenu->actions().last()->setIconVisibleInMenu(false); // Per QTBUG-44565
m_recentlyOpenedProjectsMenu->actions().last()->setIconVisibleInMenu(true);

Alternately, you could put the comment on it's own line, which has the downside of taking it slightly out of context.

This comment has been minimized.

@follower

follower Feb 17, 2017
Author Contributor

I did wonder about URL vs bug number but went with the full URL since that's what we used in #3350.

I'd tend toward still indicating it's a workaround, so would prefer to go with:

m_recentlyOpenedProjectsMenu->actions().last()->setIconVisibleInMenu(false);  // QTBUG-44565 workaround
@tresf tresf merged commit b25655f into LMMS:master Feb 17, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@follower
Copy link
Contributor Author

@follower follower commented Feb 17, 2017

Thanks for helping getting this in merge-able state and merging it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.