Don't count muted tracks in track length #3390

Merged
merged 2 commits into from Mar 1, 2017

Conversation

Projects
None yet
2 participants
@zonkmachine
Member

zonkmachine commented Feb 28, 2017

Fixes #1733

When rendering, don't count muted tracks in Song::updateLength() or muted TCO's in Track::length()

Edit2: This seem to work just fine.

Name Muting track Muting TCO
Instrument Track
BBTrack
Sample Track
Automation Track
@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Mar 1, 2017

Member

Still a bit of an oops around Sample Tracks and BBTracks.
Tested thoroughly. This works.

Member

zonkmachine commented Mar 1, 2017

Still a bit of an oops around Sample Tracks and BBTracks.
Tested thoroughly. This works.

@zonkmachine zonkmachine merged commit 06e4033 into LMMS:master Mar 1, 2017

@zonkmachine zonkmachine deleted the zonkmachine:renderlength branch Mar 1, 2017

@jasp00

This comment has been minimized.

Show comment
Hide comment
@jasp00

jasp00 Mar 17, 2017

Member

I am not sure this was a bug. Mute buttons can be automated, so a muted track could be part of an export. I am not certain "mute" should equal "disable". If it does, automation for these buttons should be dropped and an upgrade path should be written.

Member

jasp00 commented Mar 17, 2017

I am not sure this was a bug. Mute buttons can be automated, so a muted track could be part of an export. I am not certain "mute" should equal "disable". If it does, automation for these buttons should be dropped and an upgrade path should be written.

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Apr 11, 2017

Member

@jasp00 OK. I won't have time to fix this so proceed as you see fit or revert.

Member

zonkmachine commented Apr 11, 2017

@jasp00 OK. I won't have time to fix this so proceed as you see fit or revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment