Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't count muted tracks in track length #3390

Merged
merged 2 commits into from Mar 1, 2017

Conversation

zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented Feb 28, 2017

Fixes #1733

When rendering, don't count muted tracks in Song::updateLength() or muted TCO's in Track::length()

Edit2: This seem to work just fine.

Name Muting track Muting TCO
Instrument Track
BBTrack
Sample Track
Automation Track

@zonkmachine
Copy link
Member Author

zonkmachine commented Mar 1, 2017

Still a bit of an oops around Sample Tracks and BBTracks.
Tested thoroughly. This works.

@zonkmachine zonkmachine merged commit 06e4033 into LMMS:master Mar 1, 2017
@zonkmachine zonkmachine deleted the renderlength branch Mar 1, 2017
@jasp00
Copy link
Member

jasp00 commented Mar 17, 2017

I am not sure this was a bug. Mute buttons can be automated, so a muted track could be part of an export. I am not certain "mute" should equal "disable". If it does, automation for these buttons should be dropped and an upgrade path should be written.

@zonkmachine
Copy link
Member Author

zonkmachine commented Apr 11, 2017

@jasp00 OK. I won't have time to fix this so proceed as you see fit or revert.

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
* Don't count muted tracks to length on render

* Don't count muted TCO's to length on render
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants