New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haiku update #3399

Merged
merged 3 commits into from Mar 4, 2017

Conversation

Projects
None yet
3 participants
@korli
Contributor

korli commented Mar 4, 2017

The first commit from waddlesplash allows to run as root.
The two others commits fix the build on Haiku, though the one with unistd.h isn't specific to Haiku.

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Mar 4, 2017

Member

Why would you want to run as root?

Also, we have an override flag that can be used, does it not work?

Member

tresf commented Mar 4, 2017

Why would you want to run as root?

Also, we have an override flag that can be used, does it not work?

@korli

This comment has been minimized.

Show comment
Hide comment
@korli

korli Mar 4, 2017

Contributor

Running as root is the default on Haiku. I can remove that commit if you prefer.

Contributor

korli commented Mar 4, 2017

Running as root is the default on Haiku. I can remove that commit if you prefer.

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Mar 4, 2017

Member

If that is the norm, OK, then people can run it by default, it is just strange to read as a Linux/Unix user.

Member

tresf commented Mar 4, 2017

If that is the norm, OK, then people can run it by default, it is just strange to read as a Linux/Unix user.

@korli

This comment has been minimized.

Show comment
Hide comment
@korli

korli Mar 4, 2017

Contributor

@waddlesplash your opinion on the "Allow running as root on Haiku." commit?

Contributor

korli commented Mar 4, 2017

@waddlesplash your opinion on the "Allow running as root on Haiku." commit?

@waddlesplash

This comment has been minimized.

Show comment
Hide comment
@waddlesplash

waddlesplash Mar 4, 2017

Contributor

@tresf Haiku has POSIX multiuser, but the GUI all runs as root for BeOS compatibility. That won't change till after R1, most likely.

So keeping that change in there makes sense to me.

Contributor

waddlesplash commented Mar 4, 2017

@tresf Haiku has POSIX multiuser, but the GUI all runs as root for BeOS compatibility. That won't change till after R1, most likely.

So keeping that change in there makes sense to me.

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Mar 4, 2017

Member

So keeping that change in there makes sense to me.

👍

Member

tresf commented Mar 4, 2017

So keeping that change in there makes sense to me.

👍

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Mar 4, 2017

Member

@korli for consistency can we switch the statement to defined(LMMS_BUILD_HAIKU)

https://github.com/LMMS/lmms/blob/master/include/lmms_math.h#L37

Member

tresf commented Mar 4, 2017

@korli for consistency can we switch the statement to defined(LMMS_BUILD_HAIKU)

https://github.com/LMMS/lmms/blob/master/include/lmms_math.h#L37

@korli

This comment has been minimized.

Show comment
Hide comment
@korli

korli Mar 4, 2017

Contributor

It's now updated.

Contributor

korli commented Mar 4, 2017

It's now updated.

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Mar 4, 2017

Member

It's now updated.

Thanks. Will merge once Travis succeeds.

Member

tresf commented Mar 4, 2017

It's now updated.

Thanks. Will merge once Travis succeeds.

@tresf tresf merged commit 80c5b7d into LMMS:master Mar 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

PaulBatchelor added a commit to PaulBatchelor/lmms that referenced this pull request Mar 5, 2017

Haiku fixes (#3399)
* Allow running as root on Haiku.
* include unistd.h for ::read and ::write.
* Link libnetwork on Haiku.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment