New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TimeLineWidget overflow #3410

Merged
merged 1 commit into from Mar 8, 2017

Conversation

Projects
2 participants
@zonkmachine
Copy link
Member

zonkmachine commented Mar 6, 2017

In response to #3284

@zonkmachine zonkmachine merged commit 9545f96 into LMMS:master Mar 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zonkmachine zonkmachine added this to Done in Release 1.2.0 RC3 Mar 8, 2017

@lukas-w

This comment has been minimized.

Copy link
Member

lukas-w commented Mar 8, 2017

I think it would be best to fix all occurrences (see comment) by providing a function that does this, and using that instead of having the same calculation seven times in a single file.

@zonkmachine

This comment has been minimized.

Copy link
Member Author

zonkmachine commented Mar 13, 2017

I think it would be best to fix all occurrences (see comment) by providing a function that does this, and using that instead of having the same calculation seven times in a single file.

OK. I left #3284 open so maybe continue there?

@zonkmachine zonkmachine deleted the zonkmachine:timelineoverflow branch Mar 13, 2017

@lukas-w

This comment has been minimized.

Copy link
Member

lukas-w commented Mar 13, 2017

Yup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment