New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right Mouse Button To Erase Nodes In Automation Editor Cursor Icon... #3414

Merged
merged 4 commits into from Mar 13, 2017

Conversation

Projects
None yet
2 participants
@uro5h
Contributor

uro5h commented Mar 7, 2017

Right Mouse Button To Erase Nodes In Automation Editor Cursor Icon Does Not Change #3310

@uro5h uro5h changed the title from #3310 Right Mouse Button To Erase Nodes In Automation Editor Cursor Icon... to Right Mouse Button To Erase Nodes In Automation Editor Cursor Icon... Mar 7, 2017

Show outdated Hide outdated include/AutomationEditor.h
Show outdated Hide outdated src/gui/editors/AutomationEditor.cpp
@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje Mar 8, 2017

Member

Tested out the PR, works nice, but some changes are needed.

P.S. Lepo je videti da postoje ljudi u Beogradu koji se zanimaju za LMMS :)
(English translation: Nice to see that there are people in Belgrade that take interest in LMMS)

Member

Umcaruje commented Mar 8, 2017

Tested out the PR, works nice, but some changes are needed.

P.S. Lepo je videti da postoje ljudi u Beogradu koji se zanimaju za LMMS :)
(English translation: Nice to see that there are people in Belgrade that take interest in LMMS)

@uro5h

This comment has been minimized.

Show comment
Hide comment
@uro5h

uro5h Mar 9, 2017

Contributor

Hvala (Thanks), @Umcaruje .

🍻

Contributor

uro5h commented Mar 9, 2017

Hvala (Thanks), @Umcaruje .

🍻

@uro5h

This comment has been minimized.

Show comment
Hide comment
@uro5h

uro5h Mar 9, 2017

Contributor

@Umcaruje,

I have made suggested changes, also removed unused member from PianoRoll class. Do you require squashed pull requests?

Also there is an issue with triggering MousePressEvent, then MouseReleaseEvent on automation point (without MouseMoveEvent), which doesn't delete the point, but I guess I can file a new issue for it, as I believe (based on a quick look) it is related to state handling (m_action) instead of cursor switching, therefore irrelevant for this pull request. What do you think?

Contributor

uro5h commented Mar 9, 2017

@Umcaruje,

I have made suggested changes, also removed unused member from PianoRoll class. Do you require squashed pull requests?

Also there is an issue with triggering MousePressEvent, then MouseReleaseEvent on automation point (without MouseMoveEvent), which doesn't delete the point, but I guess I can file a new issue for it, as I believe (based on a quick look) it is related to state handling (m_action) instead of cursor switching, therefore irrelevant for this pull request. What do you think?

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje Mar 9, 2017

Member

Do you require squashed pull requests?

We just squash on merge with Github, so there's no need for you to do it manually.

Also there is an issue with triggering MousePressEvent, then MouseReleaseEvent on automation point (without MouseMoveEvent), which doesn't delete the point, but I guess I can file a new issue for it, as I believe (based on a quick look) it is related to state handling (m_action) instead of cursor switching, therefore irrelevant for this pull request. What do you think?

Yeah, if that issue is outside of the scope of this PR, feel free to open a new issue for it. Better to have several small PR's than one big one :)

I'll test this tommorow, the code LGTM, if all goes well in testing, I'll merge 👍

Member

Umcaruje commented Mar 9, 2017

Do you require squashed pull requests?

We just squash on merge with Github, so there's no need for you to do it manually.

Also there is an issue with triggering MousePressEvent, then MouseReleaseEvent on automation point (without MouseMoveEvent), which doesn't delete the point, but I guess I can file a new issue for it, as I believe (based on a quick look) it is related to state handling (m_action) instead of cursor switching, therefore irrelevant for this pull request. What do you think?

Yeah, if that issue is outside of the scope of this PR, feel free to open a new issue for it. Better to have several small PR's than one big one :)

I'll test this tommorow, the code LGTM, if all goes well in testing, I'll merge 👍

@Umcaruje Umcaruje merged commit e879fad into LMMS:master Mar 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment