Right Mouse Button To Erase Nodes In Automation Editor Cursor Icon...

[uro5h]

Right Mouse Button To Erase Nodes In Automation Editor Cursor Icon Does Not Change #3310

[Umcaruje]

Since you end up only using m_mouseDownRight you should remove the m_mouseDownLeft as it's not used anywhere.

[uro5h]

Agreed, will remove this one. Also, suggested change(s) might be applicable to PianoRoll as it is never used also.

lmms/src/gui/editors/PianoRoll.cpp

Line 1925 in 85ed63b

m_mouseDownLeft = false;

(Only line where it is used)

[Umcaruje]

You could also add a change for the cursor when automation points are moved, like in the piano roll:

lmms/src/gui/editors/PianoRoll.cpp

Lines 3136 to 3152 in 85ed63b

	case ModeDraw:
	if( m_mouseDownRight )
	{
	cursor = s_toolErase;
	}
	else if( m_action == ActionMoveNote )
	{
	cursor = s_toolMove;
	}
	else
	{
	cursor = s_toolDraw;
	}
	break;
	case ModeErase: cursor = s_toolErase; break;
	case ModeSelect: cursor = s_toolSelect; break;
	case ModeEditDetuning: cursor = s_toolOpen; break;

So we keep consitency.

[uro5h]

👍

[Umcaruje]

Tested out the PR, works nice, but some changes are needed.

P.S. Lepo je videti da postoje ljudi u Beogradu koji se zanimaju za LMMS :)
(English translation: Nice to see that there are people in Belgrade that take interest in LMMS)

[uro5h]

Hvala (Thanks), @Umcaruje .

🍻

[uro5h]

@Umcaruje,

I have made suggested changes, also removed unused member from PianoRoll class. Do you require squashed pull requests?

Also there is an issue with triggering MousePressEvent, then MouseReleaseEvent on automation point (without MouseMoveEvent), which doesn't delete the point, but I guess I can file a new issue for it, as I believe (based on a quick look) it is related to state handling (m_action) instead of cursor switching, therefore irrelevant for this pull request. What do you think?

[Umcaruje]

Do you require squashed pull requests?

We just squash on merge with Github, so there's no need for you to do it manually.

Also there is an issue with triggering MousePressEvent, then MouseReleaseEvent on automation point (without MouseMoveEvent), which doesn't delete the point, but I guess I can file a new issue for it, as I believe (based on a quick look) it is related to state handling (m_action) instead of cursor switching, therefore irrelevant for this pull request. What do you think?

Yeah, if that issue is outside of the scope of this PR, feel free to open a new issue for it. Better to have several small PR's than one big one :)

I'll test this tommorow, the code LGTM, if all goes well in testing, I'll merge 👍