Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Add SF2 support for macOS #3446
Those guidelines don't apply, it's not our code. This is a +1 one-liner directly from Homebrew upstream. I'd like to attach something, but I'd rather not make the diff any larger than one line. Advice is welcome.
Doesn't apply.... GPL 2.0 is completely valid in this case, since the BSD-2 can be downgraded to GPL 2.0.
The copyright information is missing from the file, so this is an upstream bug. Even upstream specifies to use "Homebrew contributors" which is against the standard you've just created. This is superfluous. I'd argue this file isn't even source code. It's a config file. There's really no copyrightable logic in it from a legal perspective.
I've added it, but this is nitpicking to a new level.
@tresf, you know it, I know it, but a newcomer will not.
Yet there is a class with a definition of bottle, install and test. As I see it, it is not clearly a configuration file. Better safe than sorry.
@GamingStar thanks for your unit testing today on Discord. From what I am reading online,
When we swapped out the fluidsynth library on your machine with one that was built using debug flags (to strip all optimization flags), it still crashed in the same fashion.
Some additional information... You're on MacOS 10.12. My build machine is on 10.11 and one other community member on Discord was on 10.12 as well however only your machine exhibits this crash. I believe your MacBook Pro is several years older than ours so it may be lacking certain CPU features.
The most effective way to troubleshoot this crash is to get a better backtrace of the problem, and that is done by creating a debug build and running a debugger against the codebase.
This takes a while to configure, build and then debug but without a machine to reproduce on our hands our tied.
Our apple build tutorial is here: https://github.com/LMMS/lmms/wiki/Compiling-lmms-(Apple)
Once we can isolate the cause we can begin to fix this problem.
Here's some more information on it...
In the event of
This is a lengthier process due to performance issues with macOS in a VM, but I'll begin the process now and link a new installer once completed.