Skip to content

fixes crash on click on compact track label button#3463

Merged
lukas-w merged 2 commits into
LMMS:stable-1.2from
BaraMGB:tracklabelbuttonbug
Mar 30, 2017
Merged

fixes crash on click on compact track label button#3463
lukas-w merged 2 commits into
LMMS:stable-1.2from
BaraMGB:tracklabelbuttonbug

Conversation

@BaraMGB

@BaraMGB BaraMGB commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

fixes #3454

@jasp00

jasp00 commented Mar 30, 2017

Copy link
Copy Markdown
Member

It would be better if you unconditionally create and hide m_renameLineEdit in the constructor.

@BaraMGB

BaraMGB commented Mar 30, 2017

Copy link
Copy Markdown
Contributor Author

Thank you for the help, @jasp00

@lukas-w lukas-w merged commit f8bf07b into LMMS:stable-1.2 Mar 30, 2017
@jasp00

jasp00 commented Mar 30, 2017

Copy link
Copy Markdown
Member

I do not get this workflow. master needs this patch too, but a direct commit overrides Travis guard.

@tresf

tresf commented Mar 30, 2017

Copy link
Copy Markdown
Member

I do not get this workflow. master needs this patch too, but a direct commit overrides Travis guard.

In regards to stable-x.x --> master, here's some examples of how we've done this in the past... 23f720f 815a70a 00cb2b1

@jasp00

jasp00 commented Mar 31, 2017

Copy link
Copy Markdown
Member

here's some examples of how we've done this in the past...

But these still override Travis checks.

@tresf

tresf commented Mar 31, 2017

Copy link
Copy Markdown
Member

But these still override Travis checks.

Are you trying to bypass the CI testing since it's already been merged? We don't do that and I'm not sure we want to.

@jasp00

jasp00 commented Mar 31, 2017

Copy link
Copy Markdown
Member

Oh, you do sync PRs, such as #1115, #1129, and #1148. How do you exclude patches specific to the stable branch?

@tresf

tresf commented Mar 31, 2017

Copy link
Copy Markdown
Member

How do you exclude patches specific to the stable branch?

Vesa used to hit these occasionally. If they don't apply to master chances are something has changed and they won't merge due to conflict.

The only way I'm aware is through the manual process of >>>>>>>>> conflict-resolution... e.g. 8b9868e

e.g.

# Conflicts:
#	src/gui/FileBrowser.cpp

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compact track buttons leads to crash

4 participants