Skip to content

Dual Filter Plugin Redesign - #3484

Merged
Umcaruje merged 2 commits into
LMMS:stable-1.2from
RebeccaDeField:stable-1.2
Apr 27, 2017
Merged

Dual Filter Plugin Redesign#3484
Umcaruje merged 2 commits into
LMMS:stable-1.2from
RebeccaDeField:stable-1.2

Conversation

@RebeccaDeField

@RebeccaDeField RebeccaDeField commented Apr 3, 2017

Copy link
Copy Markdown
Contributor

In this pull request, I have recreated the Dual Filter plugin redesign proposed by @simonvanderveldt in #3093 as a part of our efforts here.

shot-2017-04-26_17-45-24

@Umcaruje @BaraMGB

@RebeccaDeField RebeccaDeField mentioned this pull request Apr 3, 2017
14 tasks
@BaraMGB

BaraMGB commented Apr 3, 2017

Copy link
Copy Markdown
Contributor

That looks good to me. 👍

@RebeccaDeField

Copy link
Copy Markdown
Contributor Author

@Umcaruje I plan on merging today if you don't have any changes 😊

@Umcaruje

Umcaruje commented Apr 4, 2017

Copy link
Copy Markdown
Member

@Umcaruje I plan on merging today if you don't have any changes 😊
Sorry I was busy so I didn't have time to comment.

The box size is off by 2 pixels, and the third knob's position is off by a pixel. I'll post a fixed mockup asap.

@Umcaruje

Umcaruje commented Apr 4, 2017

Copy link
Copy Markdown
Member

Actually, sorry, the knob spacing is not the same on the 2 boxes, it's either 1 or 2 pixels off. It should all be on the same value and the padding of the box should be the same on both sides.

@Umcaruje

Umcaruje commented Apr 4, 2017

Copy link
Copy Markdown
Member

b1d130fa-17f6-11e7-811d-d0f5cb37d9e2
Here, I made the boxes thinner by 1px, aligned the knobs in them. I also changed the boxes' position so the spacing between the edges and the mix knob is the same. I also reduced the size of the dropdown by 1px.

These are unfortunately not code changes, just a quick mockup

@Umcaruje

Umcaruje commented Apr 4, 2017

Copy link
Copy Markdown
Member

b1d130fa-17f6-11e7-811d-d0f5cb37d9e2

It looks even better to me if you deliberately move the knobs 1px off horizontal center, cause of the LED

@Umcaruje

Umcaruje commented Apr 4, 2017

Copy link
Copy Markdown
Member

Also do we want a line connecting the boxes like in the stereo matrix plugin? So it's clear the mix is between the two filters?

@RebeccaDeField

Copy link
Copy Markdown
Contributor Author

@Umcaruje Wonderful feedback, thanks! A mockup works just fine for me. I'll play with the spacing and try your idea to connect the boxes.

@Umcaruje

Copy link
Copy Markdown
Member

I'm merging this in 12 hours if there are no objections.

@Umcaruje
Umcaruje merged commit 2f51062 into LMMS:stable-1.2 Apr 27, 2017
PhysSong pushed a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017
* Dual Filter

* Design Tweaks
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
* Dual Filter

* Design Tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants