Skip to content

Fixed #3182. Always using master channel for preset previews.#3503

Merged
tresf merged 3 commits into
LMMS:masterfrom
karmux:3182_preset_previews_always_using_master_channel
Apr 16, 2017
Merged

Fixed #3182. Always using master channel for preset previews.#3503
tresf merged 3 commits into
LMMS:masterfrom
karmux:3182_preset_previews_always_using_master_channel

Conversation

@karmux

@karmux karmux commented Apr 13, 2017

Copy link
Copy Markdown
Contributor

Fixed #3182.

@Umcaruje

Copy link
Copy Markdown
Member

Tested this out, works like a charm!
How I tested: routed an instrument to channel 5, added a clipper there to crazily distort the sound, so I know it's getting routed, and made a preset.

When previewing the preset goes to master, when adding it back to song editor, goes to FX 5 👍

The code looks good to me too, only thing I didn't notice that m_previewMode is not getting initalised to false and I don't know if that can make some problems, but I haven't encountered any while testing so it might not be needed.

@Umcaruje

Copy link
Copy Markdown
Member

I think this fix should be targeted at stable-1.2.

@tresf tresf merged commit 5e58d3c into LMMS:master Apr 16, 2017
tresf pushed a commit that referenced this pull request Apr 16, 2017
* Fixed #3182. Always using master channel for preset previews.
@tresf

tresf commented Apr 16, 2017

Copy link
Copy Markdown
Member

Merged and cherry-picked to stable-1.2 via 2df5682.

@karmux karmux deleted the 3182_preset_previews_always_using_master_channel branch April 28, 2017 20:44
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
…MS#3503)

* Fixed LMMS#3182. Always using master channel for preset previews.
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
…MS#3503)

* Fixed LMMS#3182. Always using master channel for preset previews.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants