Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #3182. Always using master channel for preset previews. #3503

Merged

Conversation

@karmux
Copy link
Contributor

karmux commented Apr 13, 2017

Fixed #3182.

@Umcaruje
Copy link
Member

Umcaruje commented Apr 14, 2017

Tested this out, works like a charm!
How I tested: routed an instrument to channel 5, added a clipper there to crazily distort the sound, so I know it's getting routed, and made a preset.

When previewing the preset goes to master, when adding it back to song editor, goes to FX 5 👍

The code looks good to me too, only thing I didn't notice that m_previewMode is not getting initalised to false and I don't know if that can make some problems, but I haven't encountered any while testing so it might not be needed.

@Umcaruje
Copy link
Member

Umcaruje commented Apr 14, 2017

I think this fix should be targeted at stable-1.2.

@tresf tresf merged commit 5e58d3c into LMMS:master Apr 16, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
tresf added a commit that referenced this pull request Apr 16, 2017
* Fixed #3182. Always using master channel for preset previews.
@tresf
Copy link
Member

tresf commented Apr 16, 2017

Merged and cherry-picked to stable-1.2 via 2df5682.

@karmux karmux deleted the karmux:3182_preset_previews_always_using_master_channel branch Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.