Replacement metronome samples #3513

Merged
merged 6 commits into from May 17, 2017

Conversation

Projects
None yet
6 participants
@Mark-Agent003
Member

Mark-Agent003 commented Apr 27, 2017

Replacement metronome sounds

image

Mark-Agent003 added some commits Apr 27, 2017

Add files via upload
Replacement metronome sounds :)
Added replacement default background
The background came from the splash screen

@Mark-Agent003 Mark-Agent003 changed the title from Replacement metrenome samples to Replacement metrenome samples and new default background Apr 27, 2017

@Umcaruje Umcaruje changed the title from Replacement metrenome samples and new default background to Replacement metronome samples and new default background Apr 29, 2017

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje Apr 30, 2017

Member

This keeps failing travis on mac ... 😕

Member

Umcaruje commented Apr 30, 2017

This keeps failing travis on mac ... 😕

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Apr 30, 2017

Member

This keeps failing travis on mac ... 😕

@Mark-Agent003's branch is missing fluid-synth.rb. Probably missing a fast-forward along the way. Confusing, but should be OK.

Member

tresf commented Apr 30, 2017

This keeps failing travis on mac ... 😕

@Mark-Agent003's branch is missing fluid-synth.rb. Probably missing a fast-forward along the way. Confusing, but should be OK.

@Mark-Agent003

This comment has been minimized.

Show comment
Hide comment
@Mark-Agent003

Mark-Agent003 Apr 30, 2017

Member

I'm confused. Is the Travis failing a problem, or are we good to go?

Member

Mark-Agent003 commented Apr 30, 2017

I'm confused. Is the Travis failing a problem, or are we good to go?

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Apr 30, 2017

Member

The problem is unrelated so good from a CI perspective.

Member

tresf commented Apr 30, 2017

The problem is unrelated so good from a CI perspective.

@Mark-Agent003

This comment has been minimized.

Show comment
Hide comment
@Mark-Agent003

Mark-Agent003 Apr 30, 2017

Member

Alright. What do I need to do?

Member

Mark-Agent003 commented Apr 30, 2017

Alright. What do I need to do?

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Apr 30, 2017

Member

Nothing, just waiting on some to review and approve. We're a bit backlogged.

Member

tresf commented Apr 30, 2017

Nothing, just waiting on some to review and approve. We're a bit backlogged.

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf May 2, 2017

Member

@Mark-Agent003 Just noticed this also comes with a new tiled background although the PR doesn't set it by default. @RebeccaDeField, I'll defer this decision to you.

image

Member

tresf commented May 2, 2017

@Mark-Agent003 Just noticed this also comes with a new tiled background although the PR doesn't set it by default. @RebeccaDeField, I'll defer this decision to you.

image

@Pyrif

This comment has been minimized.

Show comment
Hide comment
@Pyrif

Pyrif May 2, 2017

I took a listen to the new metronome. I personally think the measure click is good but the beat click could use a bit of work. Perhaps using a slightly shorter, lower-pitch version of the measure click instead?

Pyrif commented May 2, 2017

I took a listen to the new metronome. I personally think the measure click is good but the beat click could use a bit of work. Perhaps using a slightly shorter, lower-pitch version of the measure click instead?

@Mark-Agent003

This comment has been minimized.

Show comment
Hide comment
@Mark-Agent003

Mark-Agent003 May 2, 2017

Member

@UnityParadox , do you like this better? I did exactly what you said, but I also made the measure click sound less like a bubble popping 😀

Member

Mark-Agent003 commented May 2, 2017

@UnityParadox , do you like this better? I did exactly what you said, but I also made the measure click sound less like a bubble popping 😀

@Pyrif

This comment has been minimized.

Show comment
Hide comment
@Pyrif

Pyrif May 3, 2017

@Mark-Agent003 Indeed, much nicer! =)

Pyrif commented May 3, 2017

@Mark-Agent003 Indeed, much nicer! =)

@RebeccaDeField

This comment has been minimized.

Show comment
Hide comment
@RebeccaDeField

RebeccaDeField May 4, 2017

Contributor

@Mark-Agent003 Thank you for your work on this 😊

I tested your background proposal and I think we're going to keep the bg simple and clean. Can you remove the additional background from this pull request so that it only includes your updates to the metronome?

Please feel free to upload a version of the theme that includes your background on our Sharing Platform.

Contributor

RebeccaDeField commented May 4, 2017

@Mark-Agent003 Thank you for your work on this 😊

I tested your background proposal and I think we're going to keep the bg simple and clean. Can you remove the additional background from this pull request so that it only includes your updates to the metronome?

Please feel free to upload a version of the theme that includes your background on our Sharing Platform.

@Mark-Agent003

This comment has been minimized.

Show comment
Hide comment
Member

Mark-Agent003 commented May 10, 2017

Done.

@Mark-Agent003 Mark-Agent003 changed the title from Replacement metronome samples and new default background to Replacement metronome samples May 16, 2017

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf May 16, 2017

Member

Can we get a second set of ears on this? I think the old version sound more like a metronome "click".

Here's a zip containing both:
new_vs_old.zip

Member

tresf commented May 16, 2017

Can we get a second set of ears on this? I think the old version sound more like a metronome "click".

Here's a zip containing both:
new_vs_old.zip

@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB May 17, 2017

Contributor

The new click sounds more modern. The attack is enough for working with. I like it.

Contributor

BaraMGB commented May 17, 2017

The new click sounds more modern. The attack is enough for working with. I like it.

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje May 17, 2017

Member

I like the new one better too 👍

Member

Umcaruje commented May 17, 2017

I like the new one better too 👍

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf May 17, 2017

Member

Great! 3 thumbs up. Merging.

Member

tresf commented May 17, 2017

Great! 3 thumbs up. Merging.

@tresf tresf changed the base branch from master to stable-1.2 May 17, 2017

@tresf tresf merged commit c0b910e into LMMS:stable-1.2 May 17, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017

Replacement metronome samples (#3513)
Replacement metronome sounds

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017

Replacement metronome samples (#3513)
Replacement metronome sounds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment