Skip to content

Replacement metronome samples#3513

Merged
tresf merged 6 commits into
LMMS:stable-1.2from
WrillicR:master
May 17, 2017
Merged

Replacement metronome samples#3513
tresf merged 6 commits into
LMMS:stable-1.2from
WrillicR:master

Conversation

@WrillicR

@WrillicR WrillicR commented Apr 27, 2017

Copy link
Copy Markdown
Member

Replacement metronome sounds

image

Replacement metronome sounds :)
The background came from the splash screen
@WrillicR WrillicR changed the title Replacement metrenome samples Replacement metrenome samples and new default background Apr 27, 2017
@Umcaruje Umcaruje changed the title Replacement metrenome samples and new default background Replacement metronome samples and new default background Apr 29, 2017
@Umcaruje

Copy link
Copy Markdown
Member

This keeps failing travis on mac ... 😕

@tresf

tresf commented Apr 30, 2017

Copy link
Copy Markdown
Member

This keeps failing travis on mac ... 😕

@Mark-Agent003's branch is missing fluid-synth.rb. Probably missing a fast-forward along the way. Confusing, but should be OK.

@WrillicR

Copy link
Copy Markdown
Member Author

I'm confused. Is the Travis failing a problem, or are we good to go?

@tresf

tresf commented Apr 30, 2017

Copy link
Copy Markdown
Member

The problem is unrelated so good from a CI perspective.

@WrillicR

Copy link
Copy Markdown
Member Author

Alright. What do I need to do?

@WrillicR WrillicR closed this Apr 30, 2017
@WrillicR WrillicR reopened this Apr 30, 2017
@tresf

tresf commented Apr 30, 2017

Copy link
Copy Markdown
Member

Nothing, just waiting on some to review and approve. We're a bit backlogged.

@tresf

tresf commented May 2, 2017

Copy link
Copy Markdown
Member

@Mark-Agent003 Just noticed this also comes with a new tiled background although the PR doesn't set it by default. @RebeccaDeField, I'll defer this decision to you.

image

@Hey-Holokin

Copy link
Copy Markdown

I took a listen to the new metronome. I personally think the measure click is good but the beat click could use a bit of work. Perhaps using a slightly shorter, lower-pitch version of the measure click instead?

@WrillicR

WrillicR commented May 2, 2017

Copy link
Copy Markdown
Member Author

@UnityParadox , do you like this better? I did exactly what you said, but I also made the measure click sound less like a bubble popping 😀

@Hey-Holokin

Copy link
Copy Markdown

@Mark-Agent003 Indeed, much nicer! =)

@RebeccaDeField

Copy link
Copy Markdown
Contributor

@Mark-Agent003 Thank you for your work on this 😊

I tested your background proposal and I think we're going to keep the bg simple and clean. Can you remove the additional background from this pull request so that it only includes your updates to the metronome?

Please feel free to upload a version of the theme that includes your background on our Sharing Platform.

@WrillicR

Copy link
Copy Markdown
Member Author

Done.

@WrillicR WrillicR changed the title Replacement metronome samples and new default background Replacement metronome samples May 16, 2017
@tresf

tresf commented May 16, 2017

Copy link
Copy Markdown
Member

Can we get a second set of ears on this? I think the old version sound more like a metronome "click".

Here's a zip containing both:
new_vs_old.zip

@BaraMGB

BaraMGB commented May 17, 2017

Copy link
Copy Markdown
Contributor

The new click sounds more modern. The attack is enough for working with. I like it.

@Umcaruje

Copy link
Copy Markdown
Member

I like the new one better too 👍

@tresf

tresf commented May 17, 2017

Copy link
Copy Markdown
Member

Great! 3 thumbs up. Merging.

@tresf tresf changed the base branch from master to stable-1.2 May 17, 2017 14:09
@tresf tresf merged commit c0b910e into LMMS:stable-1.2 May 17, 2017
PhysSong pushed a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017
Replacement metronome sounds
PhysSong pushed a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017
Replacement metronome sounds
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Replacement metronome sounds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants