Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flanger LFO rate syncronised #3521

Merged
merged 1 commit into from May 17, 2017
Merged

Flanger LFO rate syncronised #3521

merged 1 commit into from May 17, 2017

Conversation

@curlymorphic
Copy link
Contributor

@curlymorphic curlymorphic commented May 1, 2017

The LFO rate was not correctly synchronizing to tempo

This has been rectified, to utilize the TempoSyncKnob as intended, returning a period,
instead of a frequency. The knob now reports the correct values in the GUI.

fixes #3335

@zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented May 3, 2017

With the chosen values the tempo sync menu now leaves out the longest time signatures, whole note and eight beats. I think long sweep times is especially useful for flangers. Here is what it looked like before.

flangertempo

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented May 3, 2017

@zonkmachine

Good catch, I will revise

@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented May 3, 2017

I have updated the PR, to restore the syncing of 8 beats notes,
@zonkmachine nice work for spotting that.

@zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented May 5, 2017

I have updated the PR, to restore the syncing of 8 beats notes,

Works. The 5 second maximum period is in my opinion much to small. I want to be able to sweep the flanger over a long timer, a minute or so. Like a real hippie.

The LFO rate was not correctly syncronising to tempo

This has been rectifited, to utalise the TempoSyncKnob as intended, returning a period,
instead of a frequency. The knob now reports the correct values in the GUI.

Flanger LFO maximum period incressed to 60 seconds
@curlymorphic
Copy link
Contributor Author

@curlymorphic curlymorphic commented May 5, 2017

I have adjusted the maximum period to be 60 seconds, This does sound nice now,

@Umcaruje Umcaruje added this to the 1.2.0 milestone May 14, 2017
@zonkmachine zonkmachine merged commit 300058d into LMMS:stable-1.2 May 17, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017
The LFO rate was not correctly syncronising to tempo

This has been rectifited, to utalise the TempoSyncKnob as intended, returning a period,
instead of a frequency. The knob now reports the correct values in the GUI.

Flanger LFO maximum period incressed to 60 seconds
PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017
The LFO rate was not correctly syncronising to tempo

This has been rectifited, to utalise the TempoSyncKnob as intended, returning a period,
instead of a frequency. The knob now reports the correct values in the GUI.

Flanger LFO maximum period incressed to 60 seconds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.