New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove glitching from the Flanger and Delay plugins #3524

Merged
merged 1 commit into from May 17, 2017

Conversation

Projects
None yet
3 participants
@curlymorphic
Contributor

curlymorphic commented May 1, 2017

The previous delay code was incorrectly not utalising the whole buffer, causing glitches when
incressing the delay time, due to outputting incorrect data, This was apparent when using the
lfo in the Delay and Flanger plugins.

This has been rectified. The read index is now offset from the write index. and the complete buffer
is used in a circular fashon.

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine May 13, 2017

Member

It looks like there still are some glitches in there. In the example there are glitches and occasional beeps, like a buffer replaying the bitinbader sine once in a while.
flangernoise2.mmp.zip

Member

zonkmachine commented May 13, 2017

It looks like there still are some glitches in there. In the example there are glitches and occasional beeps, like a buffer replaying the bitinbader sine once in a while.
flangernoise2.mmp.zip

@Umcaruje Umcaruje added this to the 1.2.0 milestone May 14, 2017

Remove glitching from the Flanger and Delay plugins
The previous delay code was incorrectly not utalising the whole buffer, causing glitches when
incressing the delay time, due to outputting incorrect data, This was apparent when using the
lfo in the Delay and Flanger plugins.

This has been rectified. The read index is now offset from the write index. and the complete buffer
is used in a circular fashon.

Flanger - resolved issue where the lfo could create negative delay lengths
@curlymorphic

This comment has been minimized.

Show comment
Hide comment
@curlymorphic

curlymorphic May 14, 2017

Contributor

@zonkmachine Thank you for the project, That reviled a bug with short delay times, The previous code used the lfo in a way that could result in negative delay lengths, the cause of randomness.

I have revised the code to eliminate this effect.

Contributor

curlymorphic commented May 14, 2017

@zonkmachine Thank you for the project, That reviled a bug with short delay times, The previous code used the lfo in a way that could result in negative delay lengths, the cause of randomness.

I have revised the code to eliminate this effect.

@zonkmachine

Fix confirmed!

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine May 15, 2017

Member

I've tested this PR and #3521 together now and I think they should be merged.

Member

zonkmachine commented May 15, 2017

I've tested this PR and #3521 together now and I think they should be merged.

@zonkmachine zonkmachine merged commit b432707 into LMMS:stable-1.2 May 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017

Remove glitching from the Flanger and Delay plugins (#3524)
The previous delay code was incorrectly not utalising the whole buffer, causing glitches when
incressing the delay time, due to outputting incorrect data, This was apparent when using the
lfo in the Delay and Flanger plugins.

This has been rectified. The read index is now offset from the write index. and the complete buffer is used in a circular fashon.

Flanger - resolved issue where the lfo could create negative delay lengths

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017

Remove glitching from the Flanger and Delay plugins (#3524)
The previous delay code was incorrectly not utalising the whole buffer, causing glitches when
incressing the delay time, due to outputting incorrect data, This was apparent when using the
lfo in the Delay and Flanger plugins.

This has been rectified. The read index is now offset from the write index. and the complete buffer is used in a circular fashon.

Flanger - resolved issue where the lfo could create negative delay lengths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment